* [PATCH] ia64: fix min_low_pfn/max_low_pfn build errors
@ 2020-08-29 0:01 Randy Dunlap
2020-08-29 21:39 ` David Rientjes
2020-09-01 4:19 ` Mike Rapoport
0 siblings, 2 replies; 4+ messages in thread
From: Randy Dunlap @ 2020-08-29 0:01 UTC (permalink / raw)
To: linux-kernel
Cc: Randy Dunlap, kernel test robot, linux-mm, Andrew Morton,
David Rientjes, Mike Rapoport, Tony Luck, Fenghua Yu, linux-ia64
Fix min_low_pfn/max_low_pfn build errors for arch/ia64/: (e.g.)
ERROR: "max_low_pfn" [drivers/rpmsg/virtio_rpmsg_bus.ko] undefined!
ERROR: "min_low_pfn" [drivers/rpmsg/virtio_rpmsg_bus.ko] undefined!
ERROR: "min_low_pfn" [drivers/hwtracing/intel_th/intel_th_msu.ko] undefined!
ERROR: "max_low_pfn" [drivers/hwtracing/intel_th/intel_th_msu.ko] undefined!
ERROR: "min_low_pfn" [drivers/crypto/cavium/nitrox/n5pf.ko] undefined!
ERROR: "max_low_pfn" [drivers/crypto/cavium/nitrox/n5pf.ko] undefined!
ERROR: "max_low_pfn" [drivers/md/dm-integrity.ko] undefined!
ERROR: "min_low_pfn" [drivers/md/dm-integrity.ko] undefined!
ERROR: "max_low_pfn" [crypto/tcrypt.ko] undefined!
ERROR: "min_low_pfn" [crypto/tcrypt.ko] undefined!
ERROR: "min_low_pfn" [security/keys/encrypted-keys/encrypted-keys.ko] undefined!
ERROR: "max_low_pfn" [security/keys/encrypted-keys/encrypted-keys.ko] undefined!
ERROR: "min_low_pfn" [arch/ia64/kernel/mca_recovery.ko] undefined!
ERROR: "max_low_pfn" [arch/ia64/kernel/mca_recovery.ko] undefined!
David suggested just exporting min_low_pfn & max_low_pfn in
mm/memblock.c:
https://lore.kernel.org/lkml/alpine.DEB.2.22.394.2006291911220.1118534@chino.kir.corp.google.com/
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: linux-mm@kvack.org
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: David Rientjes <rientjes@google.com>
Cc: Mike Rapoport <rppt@linux.ibm.com>
Cc: Tony Luck <tony.luck@intel.com>
Cc: Fenghua Yu <fenghua.yu@intel.com>
Cc: linux-ia64@vger.kernel.org
---
arch/ia64/kernel/ia64_ksyms.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- linux-next-20200825.orig/arch/ia64/kernel/ia64_ksyms.c
+++ linux-next-20200825/arch/ia64/kernel/ia64_ksyms.c
@@ -3,7 +3,7 @@
* Architecture-specific kernel symbols
*/
-#ifdef CONFIG_VIRTUAL_MEM_MAP
+#if defined(CONFIG_VIRTUAL_MEM_MAP) || defined(CONFIG_DISCONTIGMEM)
#include <linux/compiler.h>
#include <linux/export.h>
#include <linux/memblock.h>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ia64: fix min_low_pfn/max_low_pfn build errors
2020-08-29 0:01 [PATCH] ia64: fix min_low_pfn/max_low_pfn build errors Randy Dunlap
@ 2020-08-29 21:39 ` David Rientjes
2020-09-01 4:19 ` Mike Rapoport
1 sibling, 0 replies; 4+ messages in thread
From: David Rientjes @ 2020-08-29 21:39 UTC (permalink / raw)
To: Randy Dunlap
Cc: linux-kernel, kernel test robot, linux-mm, Andrew Morton,
Mike Rapoport, Tony Luck, Fenghua Yu, linux-ia64
On Fri, 28 Aug 2020, Randy Dunlap wrote:
> Fix min_low_pfn/max_low_pfn build errors for arch/ia64/: (e.g.)
>
> ERROR: "max_low_pfn" [drivers/rpmsg/virtio_rpmsg_bus.ko] undefined!
> ERROR: "min_low_pfn" [drivers/rpmsg/virtio_rpmsg_bus.ko] undefined!
> ERROR: "min_low_pfn" [drivers/hwtracing/intel_th/intel_th_msu.ko] undefined!
> ERROR: "max_low_pfn" [drivers/hwtracing/intel_th/intel_th_msu.ko] undefined!
> ERROR: "min_low_pfn" [drivers/crypto/cavium/nitrox/n5pf.ko] undefined!
> ERROR: "max_low_pfn" [drivers/crypto/cavium/nitrox/n5pf.ko] undefined!
> ERROR: "max_low_pfn" [drivers/md/dm-integrity.ko] undefined!
> ERROR: "min_low_pfn" [drivers/md/dm-integrity.ko] undefined!
> ERROR: "max_low_pfn" [crypto/tcrypt.ko] undefined!
> ERROR: "min_low_pfn" [crypto/tcrypt.ko] undefined!
> ERROR: "min_low_pfn" [security/keys/encrypted-keys/encrypted-keys.ko] undefined!
> ERROR: "max_low_pfn" [security/keys/encrypted-keys/encrypted-keys.ko] undefined!
> ERROR: "min_low_pfn" [arch/ia64/kernel/mca_recovery.ko] undefined!
> ERROR: "max_low_pfn" [arch/ia64/kernel/mca_recovery.ko] undefined!
>
> David suggested just exporting min_low_pfn & max_low_pfn in
> mm/memblock.c:
> https://lore.kernel.org/lkml/alpine.DEB.2.22.394.2006291911220.1118534@chino.kir.corp.google.com/
>
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: linux-mm@kvack.org
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Cc: David Rientjes <rientjes@google.com>
> Cc: Mike Rapoport <rppt@linux.ibm.com>
> Cc: Tony Luck <tony.luck@intel.com>
> Cc: Fenghua Yu <fenghua.yu@intel.com>
> Cc: linux-ia64@vger.kernel.org
Acked-by: David Rientjes <rientjes@google.com>
Thanks Randy!
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ia64: fix min_low_pfn/max_low_pfn build errors
2020-08-29 0:01 [PATCH] ia64: fix min_low_pfn/max_low_pfn build errors Randy Dunlap
2020-08-29 21:39 ` David Rientjes
@ 2020-09-01 4:19 ` Mike Rapoport
2020-09-01 15:08 ` Luck, Tony
1 sibling, 1 reply; 4+ messages in thread
From: Mike Rapoport @ 2020-09-01 4:19 UTC (permalink / raw)
To: Tony Luck
Cc: Randy Dunlap, linux-kernel, kernel test robot, linux-mm,
Andrew Morton, David Rientjes, Fenghua Yu, linux-ia64
Tony,
I can take it via the memblock tree, would appreciate an Ack.
On Fri, Aug 28, 2020 at 05:01:26PM -0700, Randy Dunlap wrote:
> Fix min_low_pfn/max_low_pfn build errors for arch/ia64/: (e.g.)
>
> ERROR: "max_low_pfn" [drivers/rpmsg/virtio_rpmsg_bus.ko] undefined!
> ERROR: "min_low_pfn" [drivers/rpmsg/virtio_rpmsg_bus.ko] undefined!
> ERROR: "min_low_pfn" [drivers/hwtracing/intel_th/intel_th_msu.ko] undefined!
> ERROR: "max_low_pfn" [drivers/hwtracing/intel_th/intel_th_msu.ko] undefined!
> ERROR: "min_low_pfn" [drivers/crypto/cavium/nitrox/n5pf.ko] undefined!
> ERROR: "max_low_pfn" [drivers/crypto/cavium/nitrox/n5pf.ko] undefined!
> ERROR: "max_low_pfn" [drivers/md/dm-integrity.ko] undefined!
> ERROR: "min_low_pfn" [drivers/md/dm-integrity.ko] undefined!
> ERROR: "max_low_pfn" [crypto/tcrypt.ko] undefined!
> ERROR: "min_low_pfn" [crypto/tcrypt.ko] undefined!
> ERROR: "min_low_pfn" [security/keys/encrypted-keys/encrypted-keys.ko] undefined!
> ERROR: "max_low_pfn" [security/keys/encrypted-keys/encrypted-keys.ko] undefined!
> ERROR: "min_low_pfn" [arch/ia64/kernel/mca_recovery.ko] undefined!
> ERROR: "max_low_pfn" [arch/ia64/kernel/mca_recovery.ko] undefined!
>
> David suggested just exporting min_low_pfn & max_low_pfn in
> mm/memblock.c:
> https://lore.kernel.org/lkml/alpine.DEB.2.22.394.2006291911220.1118534@chino.kir.corp.google.com/
>
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: linux-mm@kvack.org
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Cc: David Rientjes <rientjes@google.com>
> Cc: Mike Rapoport <rppt@linux.ibm.com>
> Cc: Tony Luck <tony.luck@intel.com>
> Cc: Fenghua Yu <fenghua.yu@intel.com>
> Cc: linux-ia64@vger.kernel.org
> ---
> arch/ia64/kernel/ia64_ksyms.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- linux-next-20200825.orig/arch/ia64/kernel/ia64_ksyms.c
> +++ linux-next-20200825/arch/ia64/kernel/ia64_ksyms.c
> @@ -3,7 +3,7 @@
> * Architecture-specific kernel symbols
> */
>
> -#ifdef CONFIG_VIRTUAL_MEM_MAP
> +#if defined(CONFIG_VIRTUAL_MEM_MAP) || defined(CONFIG_DISCONTIGMEM)
> #include <linux/compiler.h>
> #include <linux/export.h>
> #include <linux/memblock.h>
--
Sincerely yours,
Mike.
^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: [PATCH] ia64: fix min_low_pfn/max_low_pfn build errors
2020-09-01 4:19 ` Mike Rapoport
@ 2020-09-01 15:08 ` Luck, Tony
0 siblings, 0 replies; 4+ messages in thread
From: Luck, Tony @ 2020-09-01 15:08 UTC (permalink / raw)
To: Mike Rapoport
Cc: Randy Dunlap, linux-kernel, lkp, linux-mm, Andrew Morton,
David Rientjes, Yu, Fenghua, linux-ia64
> I can take it via the memblock tree, would appreciate an Ack.
Thanks
Acked-by: Tony Luck <tony.luck@intel.com>
-Tony
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-09-01 15:10 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-29 0:01 [PATCH] ia64: fix min_low_pfn/max_low_pfn build errors Randy Dunlap
2020-08-29 21:39 ` David Rientjes
2020-09-01 4:19 ` Mike Rapoport
2020-09-01 15:08 ` Luck, Tony
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox