From: Mike Rapoport <rppt@linux.ibm.com>
To: Tony Luck <tony.luck@intel.com>
Cc: Randy Dunlap <rdunlap@infradead.org>,
linux-kernel@vger.kernel.org, kernel test robot <lkp@intel.com>,
linux-mm@kvack.org, Andrew Morton <akpm@linux-foundation.org>,
David Rientjes <rientjes@google.com>,
Fenghua Yu <fenghua.yu@intel.com>,
linux-ia64@vger.kernel.org
Subject: Re: [PATCH] ia64: fix min_low_pfn/max_low_pfn build errors
Date: Tue, 1 Sep 2020 07:19:02 +0300 [thread overview]
Message-ID: <20200901041902.GC424181@linux.ibm.com> (raw)
In-Reply-To: <20200829000126.2463-1-rdunlap@infradead.org>
Tony,
I can take it via the memblock tree, would appreciate an Ack.
On Fri, Aug 28, 2020 at 05:01:26PM -0700, Randy Dunlap wrote:
> Fix min_low_pfn/max_low_pfn build errors for arch/ia64/: (e.g.)
>
> ERROR: "max_low_pfn" [drivers/rpmsg/virtio_rpmsg_bus.ko] undefined!
> ERROR: "min_low_pfn" [drivers/rpmsg/virtio_rpmsg_bus.ko] undefined!
> ERROR: "min_low_pfn" [drivers/hwtracing/intel_th/intel_th_msu.ko] undefined!
> ERROR: "max_low_pfn" [drivers/hwtracing/intel_th/intel_th_msu.ko] undefined!
> ERROR: "min_low_pfn" [drivers/crypto/cavium/nitrox/n5pf.ko] undefined!
> ERROR: "max_low_pfn" [drivers/crypto/cavium/nitrox/n5pf.ko] undefined!
> ERROR: "max_low_pfn" [drivers/md/dm-integrity.ko] undefined!
> ERROR: "min_low_pfn" [drivers/md/dm-integrity.ko] undefined!
> ERROR: "max_low_pfn" [crypto/tcrypt.ko] undefined!
> ERROR: "min_low_pfn" [crypto/tcrypt.ko] undefined!
> ERROR: "min_low_pfn" [security/keys/encrypted-keys/encrypted-keys.ko] undefined!
> ERROR: "max_low_pfn" [security/keys/encrypted-keys/encrypted-keys.ko] undefined!
> ERROR: "min_low_pfn" [arch/ia64/kernel/mca_recovery.ko] undefined!
> ERROR: "max_low_pfn" [arch/ia64/kernel/mca_recovery.ko] undefined!
>
> David suggested just exporting min_low_pfn & max_low_pfn in
> mm/memblock.c:
> https://lore.kernel.org/lkml/alpine.DEB.2.22.394.2006291911220.1118534@chino.kir.corp.google.com/
>
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: linux-mm@kvack.org
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Cc: David Rientjes <rientjes@google.com>
> Cc: Mike Rapoport <rppt@linux.ibm.com>
> Cc: Tony Luck <tony.luck@intel.com>
> Cc: Fenghua Yu <fenghua.yu@intel.com>
> Cc: linux-ia64@vger.kernel.org
> ---
> arch/ia64/kernel/ia64_ksyms.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- linux-next-20200825.orig/arch/ia64/kernel/ia64_ksyms.c
> +++ linux-next-20200825/arch/ia64/kernel/ia64_ksyms.c
> @@ -3,7 +3,7 @@
> * Architecture-specific kernel symbols
> */
>
> -#ifdef CONFIG_VIRTUAL_MEM_MAP
> +#if defined(CONFIG_VIRTUAL_MEM_MAP) || defined(CONFIG_DISCONTIGMEM)
> #include <linux/compiler.h>
> #include <linux/export.h>
> #include <linux/memblock.h>
--
Sincerely yours,
Mike.
next prev parent reply other threads:[~2020-09-01 4:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-29 0:01 Randy Dunlap
2020-08-29 21:39 ` David Rientjes
2020-09-01 4:19 ` Mike Rapoport [this message]
2020-09-01 15:08 ` Luck, Tony
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200901041902.GC424181@linux.ibm.com \
--to=rppt@linux.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=fenghua.yu@intel.com \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lkp@intel.com \
--cc=rdunlap@infradead.org \
--cc=rientjes@google.com \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox