From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 497A6C433E7 for ; Mon, 31 Aug 2020 19:15:59 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id E96AF2068F for ; Mon, 31 Aug 2020 19:15:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="atYzD5gp" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E96AF2068F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 4E2E36B0003; Mon, 31 Aug 2020 15:15:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 46C896B0037; Mon, 31 Aug 2020 15:15:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 35EB58E0001; Mon, 31 Aug 2020 15:15:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0080.hostedemail.com [216.40.44.80]) by kanga.kvack.org (Postfix) with ESMTP id 189336B0003 for ; Mon, 31 Aug 2020 15:15:58 -0400 (EDT) Received: from smtpin21.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id C0A938248068 for ; Mon, 31 Aug 2020 19:15:57 +0000 (UTC) X-FDA: 77211818754.21.wind03_251011527092 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin21.hostedemail.com (Postfix) with ESMTP id 98870180442C0 for ; Mon, 31 Aug 2020 19:15:57 +0000 (UTC) X-HE-Tag: wind03_251011527092 X-Filterd-Recvd-Size: 2432 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf02.hostedemail.com (Postfix) with ESMTP for ; Mon, 31 Aug 2020 19:15:57 +0000 (UTC) Received: from X1 (unknown [65.49.58.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 69CBE2068F; Mon, 31 Aug 2020 19:15:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1598901356; bh=GDy1fsI36v2ZyxfLvzTCNTXvzujrkKd4Gu/L2okdFrQ=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=atYzD5gpMnIG6BFdeJ/em0LdLf1SHIZektt7yokFaON6dBOuazpy6TdDZ1BDD4kRJ 7ibDldGN9Kh+T9Fz1RkWQHzdztYTxNdYBenNZkEWvazPxsPj0n9jfVuGJHpOk3HtB7 QYaGjrSXSPNiPT7D2uOWcEtCkPml7P6EQnn8sEac= Date: Mon, 31 Aug 2020 12:15:53 -0700 From: Andrew Morton To: Christian Borntraeger Cc: Gerald Schaefer , Linus Torvalds , linux-mm , LKML , Vasily Gorbik , Alexander Gordeev , linux-s390@vger.kernel.org, Heiko Carstens , Claudio Imbrenda Subject: Re: [RFC PATCH 0/2] mm/gup: fix gup_fast with dynamic page table folding Message-Id: <20200831121553.8be5dcdbdbc5256846ac513e@linux-foundation.org> In-Reply-To: <9071c9fa-ba6a-90dc-2d7a-8b155141d890@de.ibm.com> References: <20200828140314.8556-1-gerald.schaefer@linux.ibm.com> <9071c9fa-ba6a-90dc-2d7a-8b155141d890@de.ibm.com> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.32; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 98870180442C0 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam01 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000006, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, 31 Aug 2020 13:53:36 +0200 Christian Borntraeger wrote: > > > On 28.08.20 16:03, Gerald Schaefer wrote: > have some feedback soon if option 1 or option 2 would be acceptable > from a common code perspective. Andrew, who of the mm people would > be the right one to decide? Jason and John Hubbard are doing most of the work in there at present, Both patches look OK to me from a non-s390 perspective. Unless we plan to implement Jason's more-general approach this time, I'd be inclined to defer to the s390 people as to the preferred implementation.