From: Wei Yang <richard.weiyang@linux.alibaba.com>
To: mike.kravetz@oracle.com, akpm@linux-foundation.org
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, bhe@redhat.com,
Wei Yang <richard.weiyang@linux.alibaba.com>
Subject: [Patch v3 2/7] mm/hugetlb: remove VM_BUG_ON(!nrg) in get_file_region_entry_from_cache()
Date: Mon, 31 Aug 2020 10:23:46 +0800 [thread overview]
Message-ID: <20200831022351.20916-3-richard.weiyang@linux.alibaba.com> (raw)
In-Reply-To: <20200831022351.20916-1-richard.weiyang@linux.alibaba.com>
We are sure to get a valid file_region, otherwise the
VM_BUG_ON(resv->region_cache_count <= 0) at the very beginning would be
triggered.
Let's remove the redundant one.
Signed-off-by: Wei Yang <richard.weiyang@linux.alibaba.com>
Reviewed-by: Mike Kravetz <mike.kravetz@oracle.com>
---
mm/hugetlb.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/mm/hugetlb.c b/mm/hugetlb.c
index db6af2654f12..fbaf49bc1d26 100644
--- a/mm/hugetlb.c
+++ b/mm/hugetlb.c
@@ -240,7 +240,6 @@ get_file_region_entry_from_cache(struct resv_map *resv, long from, long to)
resv->region_cache_count--;
nrg = list_first_entry(&resv->region_cache, struct file_region, link);
- VM_BUG_ON(!nrg);
list_del(&nrg->link);
nrg->from = from;
--
2.20.1 (Apple Git-117)
next prev parent reply other threads:[~2020-08-31 2:24 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-31 2:23 [Patch v3 0/7] mm/hugetlb: code refine and simplification Wei Yang
2020-08-31 2:23 ` [Patch v3 1/7] mm/hugetlb: not necessary to coalesce regions recursively Wei Yang
2020-08-31 2:23 ` Wei Yang [this message]
2020-08-31 2:23 ` [Patch v3 3/7] mm/hugetlb: use list_splice to merge two list at once Wei Yang
2020-08-31 2:23 ` [Patch v3 4/7] mm/hugetlb: count file_region to be added when regions_needed != NULL Wei Yang
2020-08-31 2:23 ` [Patch v3 5/7] mm/hugetlb: a page from buddy is not on any list Wei Yang
2020-08-31 2:23 ` [Patch v3 6/7] mm/hugetlb: narrow the hugetlb_lock protection area during preparing huge page Wei Yang
2020-08-31 2:23 ` [Patch v3 7/7] mm/hugetlb: take the free hpage during the iteration directly Wei Yang
2020-08-31 23:06 ` Mike Kravetz
2020-09-01 1:42 ` Wei Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200831022351.20916-3-richard.weiyang@linux.alibaba.com \
--to=richard.weiyang@linux.alibaba.com \
--cc=akpm@linux-foundation.org \
--cc=bhe@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mike.kravetz@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox