From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 954E6C433E7 for ; Sun, 30 Aug 2020 10:18:45 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 5927320738 for ; Sun, 30 Aug 2020 10:18:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="cgWN+UpB" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5927320738 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 08CC86B000A; Sun, 30 Aug 2020 06:18:45 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 015D96B000C; Sun, 30 Aug 2020 06:18:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DFC5A6B000D; Sun, 30 Aug 2020 06:18:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0170.hostedemail.com [216.40.44.170]) by kanga.kvack.org (Postfix) with ESMTP id D454D6B000A for ; Sun, 30 Aug 2020 06:18:44 -0400 (EDT) Received: from smtpin12.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 9EE662493 for ; Sun, 30 Aug 2020 10:18:44 +0000 (UTC) X-FDA: 77206836168.12.spoon17_0102cff27086 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin12.hostedemail.com (Postfix) with ESMTP id 6BD3C1800EB3D for ; Sun, 30 Aug 2020 10:18:44 +0000 (UTC) X-HE-Tag: spoon17_0102cff27086 X-Filterd-Recvd-Size: 5770 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf03.hostedemail.com (Postfix) with ESMTP for ; Sun, 30 Aug 2020 10:18:43 +0000 (UTC) Received: from kernel.org (unknown [87.70.91.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 7F69220738; Sun, 30 Aug 2020 10:18:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1598782722; bh=sRD04fQkd7ArwvwEzVrpFGIAtRfVKXTA5eBOjfae0nY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=cgWN+UpBHbinEyxZtXkegtbYJGDbuJ+YNBBJFlAwGNoxYapiivYV4080E3L2xMoYl HNyQpk5USDSZCxFaOw3sL8yI/hcE7dKTtGb+yjZBkhhsbvDLN9m4OSHe67qgIR7FsB 6c0gsA8gwj5ojXAxmeVg0/R5kHFC2Iu1CHDAqwDo= Date: Sun, 30 Aug 2020 13:18:37 +0300 From: Mike Rapoport To: Nicholas Piggin Cc: linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Arnd Bergmann Subject: Re: [PATCH v2 00/23] Use asm-generic for mmu_context no-op functions Message-ID: <20200830101837.GB423750@kernel.org> References: <20200826145249.745432-1-npiggin@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200826145249.745432-1-npiggin@gmail.com> X-Rspamd-Queue-Id: 6BD3C1800EB3D X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam05 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Aug 27, 2020 at 12:52:26AM +1000, Nicholas Piggin wrote: > It would be nice to be able to modify mmu_context functions or add a > hook without updating all architectures, many of which will be no-ops. > > The motivation for this series is a change to lazy mmu handling, but > this series stands on its own as a good cleanup whether or not we end > up making that change. I really like this series, I just have some small comments in reply to patch 1, otherwise feel free to add Acked-by: Mike Rapoport > Arnd, is this something you could take through your asm-generic tree? > (assuming arch maintainers are okay with it) > > Thanks, > Nick > > Since v1: > - Added acks and feedback from various people. > - Fixed a nommu build error caught by ktp. > - Dropped unicore32. > > Nicholas Piggin (23): > asm-generic: add generic MMU versions of mmu context functions > alpha: use asm-generic/mmu_context.h for no-op implementations > arc: use asm-generic/mmu_context.h for no-op implementations > arm: use asm-generic/mmu_context.h for no-op implementations > arm64: use asm-generic/mmu_context.h for no-op implementations > csky: use asm-generic/mmu_context.h for no-op implementations > hexagon: use asm-generic/mmu_context.h for no-op implementations > ia64: use asm-generic/mmu_context.h for no-op implementations > m68k: use asm-generic/mmu_context.h for no-op implementations > microblaze: use asm-generic/mmu_context.h for no-op implementations > mips: use asm-generic/mmu_context.h for no-op implementations > nds32: use asm-generic/mmu_context.h for no-op implementations > nios2: use asm-generic/mmu_context.h for no-op implementations > openrisc: use asm-generic/mmu_context.h for no-op implementations > parisc: use asm-generic/mmu_context.h for no-op implementations > powerpc: use asm-generic/mmu_context.h for no-op implementations > riscv: use asm-generic/mmu_context.h for no-op implementations > s390: use asm-generic/mmu_context.h for no-op implementations > sh: use asm-generic/mmu_context.h for no-op implementations > sparc: use asm-generic/mmu_context.h for no-op implementations > um: use asm-generic/mmu_context.h for no-op implementations > x86: use asm-generic/mmu_context.h for no-op implementations > xtensa: use asm-generic/mmu_context.h for no-op implementations > > arch/alpha/include/asm/mmu_context.h | 12 ++--- > arch/arc/include/asm/mmu_context.h | 17 +++--- > arch/arm/include/asm/mmu_context.h | 26 ++------- > arch/arm64/include/asm/mmu_context.h | 9 ++-- > arch/csky/include/asm/mmu_context.h | 8 ++- > arch/hexagon/include/asm/mmu_context.h | 33 ++---------- > arch/ia64/include/asm/mmu_context.h | 17 ++---- > arch/m68k/include/asm/mmu_context.h | 47 +++------------- > arch/microblaze/include/asm/mmu_context.h | 2 +- > arch/microblaze/include/asm/mmu_context_mm.h | 8 +-- > arch/microblaze/include/asm/processor.h | 3 -- > arch/mips/include/asm/mmu_context.h | 11 ++-- > arch/nds32/include/asm/mmu_context.h | 10 +--- > arch/nios2/include/asm/mmu_context.h | 21 ++------ > arch/openrisc/include/asm/mmu_context.h | 8 ++- > arch/parisc/include/asm/mmu_context.h | 12 ++--- > arch/powerpc/include/asm/mmu_context.h | 22 +++----- > arch/riscv/include/asm/mmu_context.h | 22 +------- > arch/s390/include/asm/mmu_context.h | 9 ++-- > arch/sh/include/asm/mmu_context.h | 7 ++- > arch/sh/include/asm/mmu_context_32.h | 9 ---- > arch/sparc/include/asm/mmu_context_32.h | 10 ++-- > arch/sparc/include/asm/mmu_context_64.h | 10 ++-- > arch/um/include/asm/mmu_context.h | 12 ++--- > arch/x86/include/asm/mmu_context.h | 6 +++ > arch/xtensa/include/asm/mmu_context.h | 11 ++-- > arch/xtensa/include/asm/nommu_context.h | 26 +-------- > include/asm-generic/mmu_context.h | 57 +++++++++++++++----- > include/asm-generic/nommu_context.h | 19 +++++++ > 29 files changed, 166 insertions(+), 298 deletions(-) > create mode 100644 include/asm-generic/nommu_context.h > > -- > 2.23.0 > > -- Sincerely yours, Mike.