From: Mike Rapoport <rppt@kernel.org>
To: Nicholas Piggin <npiggin@gmail.com>
Cc: linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-mm@kvack.org, Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCH v2 00/23] Use asm-generic for mmu_context no-op functions
Date: Sun, 30 Aug 2020 13:18:37 +0300 [thread overview]
Message-ID: <20200830101837.GB423750@kernel.org> (raw)
In-Reply-To: <20200826145249.745432-1-npiggin@gmail.com>
On Thu, Aug 27, 2020 at 12:52:26AM +1000, Nicholas Piggin wrote:
> It would be nice to be able to modify mmu_context functions or add a
> hook without updating all architectures, many of which will be no-ops.
>
> The motivation for this series is a change to lazy mmu handling, but
> this series stands on its own as a good cleanup whether or not we end
> up making that change.
I really like this series, I just have some small comments in reply to
patch 1, otherwise feel free to add
Acked-by: Mike Rapoport <rppt@linux.ibm.com>
> Arnd, is this something you could take through your asm-generic tree?
> (assuming arch maintainers are okay with it)
>
> Thanks,
> Nick
>
> Since v1:
> - Added acks and feedback from various people.
> - Fixed a nommu build error caught by ktp.
> - Dropped unicore32.
>
> Nicholas Piggin (23):
> asm-generic: add generic MMU versions of mmu context functions
> alpha: use asm-generic/mmu_context.h for no-op implementations
> arc: use asm-generic/mmu_context.h for no-op implementations
> arm: use asm-generic/mmu_context.h for no-op implementations
> arm64: use asm-generic/mmu_context.h for no-op implementations
> csky: use asm-generic/mmu_context.h for no-op implementations
> hexagon: use asm-generic/mmu_context.h for no-op implementations
> ia64: use asm-generic/mmu_context.h for no-op implementations
> m68k: use asm-generic/mmu_context.h for no-op implementations
> microblaze: use asm-generic/mmu_context.h for no-op implementations
> mips: use asm-generic/mmu_context.h for no-op implementations
> nds32: use asm-generic/mmu_context.h for no-op implementations
> nios2: use asm-generic/mmu_context.h for no-op implementations
> openrisc: use asm-generic/mmu_context.h for no-op implementations
> parisc: use asm-generic/mmu_context.h for no-op implementations
> powerpc: use asm-generic/mmu_context.h for no-op implementations
> riscv: use asm-generic/mmu_context.h for no-op implementations
> s390: use asm-generic/mmu_context.h for no-op implementations
> sh: use asm-generic/mmu_context.h for no-op implementations
> sparc: use asm-generic/mmu_context.h for no-op implementations
> um: use asm-generic/mmu_context.h for no-op implementations
> x86: use asm-generic/mmu_context.h for no-op implementations
> xtensa: use asm-generic/mmu_context.h for no-op implementations
>
> arch/alpha/include/asm/mmu_context.h | 12 ++---
> arch/arc/include/asm/mmu_context.h | 17 +++---
> arch/arm/include/asm/mmu_context.h | 26 ++-------
> arch/arm64/include/asm/mmu_context.h | 9 ++--
> arch/csky/include/asm/mmu_context.h | 8 ++-
> arch/hexagon/include/asm/mmu_context.h | 33 ++----------
> arch/ia64/include/asm/mmu_context.h | 17 ++----
> arch/m68k/include/asm/mmu_context.h | 47 +++-------------
> arch/microblaze/include/asm/mmu_context.h | 2 +-
> arch/microblaze/include/asm/mmu_context_mm.h | 8 +--
> arch/microblaze/include/asm/processor.h | 3 --
> arch/mips/include/asm/mmu_context.h | 11 ++--
> arch/nds32/include/asm/mmu_context.h | 10 +---
> arch/nios2/include/asm/mmu_context.h | 21 ++------
> arch/openrisc/include/asm/mmu_context.h | 8 ++-
> arch/parisc/include/asm/mmu_context.h | 12 ++---
> arch/powerpc/include/asm/mmu_context.h | 22 +++-----
> arch/riscv/include/asm/mmu_context.h | 22 +-------
> arch/s390/include/asm/mmu_context.h | 9 ++--
> arch/sh/include/asm/mmu_context.h | 7 ++-
> arch/sh/include/asm/mmu_context_32.h | 9 ----
> arch/sparc/include/asm/mmu_context_32.h | 10 ++--
> arch/sparc/include/asm/mmu_context_64.h | 10 ++--
> arch/um/include/asm/mmu_context.h | 12 ++---
> arch/x86/include/asm/mmu_context.h | 6 +++
> arch/xtensa/include/asm/mmu_context.h | 11 ++--
> arch/xtensa/include/asm/nommu_context.h | 26 +--------
> include/asm-generic/mmu_context.h | 57 +++++++++++++++-----
> include/asm-generic/nommu_context.h | 19 +++++++
> 29 files changed, 166 insertions(+), 298 deletions(-)
> create mode 100644 include/asm-generic/nommu_context.h
>
> --
> 2.23.0
>
>
--
Sincerely yours,
Mike.
next prev parent reply other threads:[~2020-08-30 10:18 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-26 14:52 Nicholas Piggin
2020-08-26 14:52 ` [PATCH v2 01/23] asm-generic: add generic MMU versions of mmu context functions Nicholas Piggin
2020-08-26 18:13 ` kernel test robot
2020-09-01 6:49 ` Mike Rapoport
2020-09-01 7:14 ` Nicholas Piggin
2020-08-26 14:52 ` [PATCH v2 02/23] alpha: use asm-generic/mmu_context.h for no-op implementations Nicholas Piggin
2020-08-26 14:52 ` [PATCH v2 03/23] arc: " Nicholas Piggin
2020-08-26 14:52 ` [PATCH v2 04/23] arm: " Nicholas Piggin
2020-08-26 14:52 ` [PATCH v2 05/23] arm64: " Nicholas Piggin
2020-08-26 15:25 ` Catalin Marinas
2020-08-26 16:20 ` Nicholas Piggin
2020-10-27 9:59 ` Naresh Kamboju
2020-10-27 15:08 ` Arnd Bergmann
2020-08-26 18:42 ` kernel test robot
2020-08-26 18:57 ` kernel test robot
2020-08-26 23:55 ` kernel test robot
2020-08-26 14:52 ` [PATCH v2 06/23] csky: " Nicholas Piggin
2020-08-26 14:52 ` [PATCH v2 07/23] hexagon: " Nicholas Piggin
2020-08-26 14:52 ` [PATCH v2 08/23] ia64: " Nicholas Piggin
2020-08-26 14:52 ` [PATCH v2 09/23] m68k: " Nicholas Piggin
2020-08-27 9:33 ` Geert Uytterhoeven
2020-09-01 6:23 ` Nicholas Piggin
2020-09-01 7:03 ` Geert Uytterhoeven
2020-09-01 7:50 ` Nicholas Piggin
2020-08-26 14:52 ` [PATCH v2 10/23] microblaze: " Nicholas Piggin
2020-08-31 14:15 ` Michal Simek
2020-09-01 6:15 ` Nicholas Piggin
2020-09-01 6:41 ` Michal Simek
2020-09-01 7:09 ` Nicholas Piggin
2020-08-26 14:52 ` [PATCH v2 11/23] mips: " Nicholas Piggin
2020-08-26 14:52 ` [PATCH v2 12/23] nds32: " Nicholas Piggin
2020-08-28 10:09 ` Greentime Hu
2020-08-26 14:52 ` [PATCH v2 13/23] nios2: " Nicholas Piggin
2020-08-26 14:52 ` [PATCH v2 14/23] openrisc: " Nicholas Piggin
2020-08-26 14:52 ` [PATCH v2 15/23] parisc: " Nicholas Piggin
2020-08-29 9:09 ` Helge Deller
2020-08-26 14:52 ` [PATCH v2 16/23] powerpc: " Nicholas Piggin
2020-09-01 7:30 ` Michael Ellerman
2020-08-26 14:52 ` [PATCH v2 17/23] riscv: " Nicholas Piggin
2020-08-26 16:42 ` Pekka Enberg
2020-08-26 14:52 ` [PATCH v2 18/23] s390: " Nicholas Piggin
2020-08-26 14:52 ` [PATCH v2 19/23] sh: " Nicholas Piggin
2020-08-26 14:52 ` [PATCH v2 20/23] sparc: " Nicholas Piggin
2020-08-26 14:52 ` [PATCH v2 21/23] um: " Nicholas Piggin
2020-08-26 14:52 ` [PATCH v2 22/23] x86: " Nicholas Piggin
2020-08-26 14:52 ` [PATCH v2 23/23] xtensa: " Nicholas Piggin
2020-08-26 20:12 ` [PATCH v2 00/23] Use asm-generic for mmu_context no-op functions Arnd Bergmann
2020-08-30 10:18 ` Mike Rapoport [this message]
2020-09-01 6:17 ` Nicholas Piggin
2020-09-01 6:54 ` Mike Rapoport
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200830101837.GB423750@kernel.org \
--to=rppt@kernel.org \
--cc=arnd@arndb.de \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=npiggin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox