From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 54BCEC433E2 for ; Fri, 28 Aug 2020 16:53:54 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 2E28C20738 for ; Fri, 28 Aug 2020 16:53:54 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2E28C20738 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id AE92C6B0002; Fri, 28 Aug 2020 12:53:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A711D6B0003; Fri, 28 Aug 2020 12:53:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9392E6B0005; Fri, 28 Aug 2020 12:53:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0133.hostedemail.com [216.40.44.133]) by kanga.kvack.org (Postfix) with ESMTP id 7949F6B0002 for ; Fri, 28 Aug 2020 12:53:53 -0400 (EDT) Received: from smtpin16.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 35D27585C for ; Fri, 28 Aug 2020 16:53:53 +0000 (UTC) X-FDA: 77200574346.16.sky52_080943627077 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin16.hostedemail.com (Postfix) with ESMTP id EF51A100E6903 for ; Fri, 28 Aug 2020 16:53:52 +0000 (UTC) X-HE-Tag: sky52_080943627077 X-Filterd-Recvd-Size: 1963 Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by imf01.hostedemail.com (Postfix) with ESMTP for ; Fri, 28 Aug 2020 16:53:52 +0000 (UTC) IronPort-SDR: +882qIdTsqO0FC5D090Ho39WqWcrNcAcQlO32EY0wD0gBmqibGWiicZc0bg3vY+nhF68vqYms8 RwD0bHD0e5Ow== X-IronPort-AV: E=McAfee;i="6000,8403,9727"; a="220947058" X-IronPort-AV: E=Sophos;i="5.76,364,1592895600"; d="scan'208";a="220947058" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Aug 2020 09:53:51 -0700 IronPort-SDR: m37eGOiRVDtLjlEXWPDtSflNmlPbKTZq9zmm5qG3nXhxfb4GLupEcVhRzAT94U3qGkHGwFexVn x8va+e5MHItg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.76,364,1592895600"; d="scan'208";a="330006494" Received: from tassilo.jf.intel.com (HELO tassilo.localdomain) ([10.7.201.21]) by orsmga008.jf.intel.com with ESMTP; 28 Aug 2020 09:53:51 -0700 Received: by tassilo.localdomain (Postfix, from userid 1000) id DD0ED301C54; Fri, 28 Aug 2020 07:59:50 -0700 (PDT) Date: Fri, 28 Aug 2020 07:59:50 -0700 From: Andi Kleen To: Muchun Song Cc: mike.kravetz@oracle.com, akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] mm/hugetlb: Fix a race between hugetlb sysctl handlers Message-ID: <20200828145950.GS1509399@tassilo.jf.intel.com> References: <20200828031146.43035-1-songmuchun@bytedance.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200828031146.43035-1-songmuchun@bytedance.com> X-Rspamd-Queue-Id: EF51A100E6903 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam02 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > Fixes: e5ff215941d5 ("hugetlb: multiple hstates for multiple page sizes") I believe the Fixes line is still not correct. The original patch didn't have that problem. Please identify which patch added the problematic code. -Andi