* [PATCH] mm/test: use the new SKIP() macro
@ 2020-08-27 19:04 Ralph Campbell
2020-08-28 11:13 ` Jason Gunthorpe
0 siblings, 1 reply; 2+ messages in thread
From: Ralph Campbell @ 2020-08-27 19:04 UTC (permalink / raw)
To: linux-mm, linux-kselftest, linux-kernel
Cc: Jerome Glisse, John Hubbard, Shuah Khan, Andrew Morton, Ralph Campbell
Some tests might not be able to be run if resources like huge pages are
not available. Mark these tests as skipped instead of simply passing.
Signed-off-by: Ralph Campbell <rcampbell@nvidia.com>
---
This applies to linux-mm and is for Andrew Morton's tree.
tools/testing/selftests/vm/hmm-tests.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tools/testing/selftests/vm/hmm-tests.c b/tools/testing/selftests/vm/hmm-tests.c
index 93fc5cadce61..0a28a6a29581 100644
--- a/tools/testing/selftests/vm/hmm-tests.c
+++ b/tools/testing/selftests/vm/hmm-tests.c
@@ -680,7 +680,7 @@ TEST_F(hmm, anon_write_hugetlbfs)
n = gethugepagesizes(pagesizes, 4);
if (n <= 0)
- return;
+ SKIP(return, "Huge page size could not be determined");
for (idx = 0; --n > 0; ) {
if (pagesizes[n] < pagesizes[idx])
idx = n;
@@ -694,7 +694,7 @@ TEST_F(hmm, anon_write_hugetlbfs)
buffer->ptr = get_hugepage_region(size, GHR_STRICT);
if (buffer->ptr == NULL) {
free(buffer);
- return;
+ SKIP(return, "Huge page could not be allocated");
}
buffer->fd = -1;
--
2.20.1
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] mm/test: use the new SKIP() macro
2020-08-27 19:04 [PATCH] mm/test: use the new SKIP() macro Ralph Campbell
@ 2020-08-28 11:13 ` Jason Gunthorpe
0 siblings, 0 replies; 2+ messages in thread
From: Jason Gunthorpe @ 2020-08-28 11:13 UTC (permalink / raw)
To: Ralph Campbell
Cc: linux-mm, linux-kselftest, linux-kernel, Jerome Glisse,
John Hubbard, Shuah Khan, Andrew Morton
On Thu, Aug 27, 2020 at 12:04:00PM -0700, Ralph Campbell wrote:
> Some tests might not be able to be run if resources like huge pages are
> not available. Mark these tests as skipped instead of simply passing.
>
> Signed-off-by: Ralph Campbell <rcampbell@nvidia.com>
> ---
>
> This applies to linux-mm and is for Andrew Morton's tree.
>
> tools/testing/selftests/vm/hmm-tests.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>
Jason
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-08-28 11:13 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-27 19:04 [PATCH] mm/test: use the new SKIP() macro Ralph Campbell
2020-08-28 11:13 ` Jason Gunthorpe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox