From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 79E4FC433E1 for ; Thu, 27 Aug 2020 01:59:06 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 3B3662073A for ; Thu, 27 Aug 2020 01:59:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="kHlQVYZ0" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3B3662073A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id A365C6B0008; Wed, 26 Aug 2020 21:59:05 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9BEDB6B000A; Wed, 26 Aug 2020 21:59:05 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 886586B000C; Wed, 26 Aug 2020 21:59:05 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0062.hostedemail.com [216.40.44.62]) by kanga.kvack.org (Postfix) with ESMTP id 6DA936B0008 for ; Wed, 26 Aug 2020 21:59:05 -0400 (EDT) Received: from smtpin09.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 2284A3647 for ; Thu, 27 Aug 2020 01:59:05 +0000 (UTC) X-FDA: 77194690650.09.spoon42_3806b6c27069 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin09.hostedemail.com (Postfix) with ESMTP id F1920180AD811 for ; Thu, 27 Aug 2020 01:59:04 +0000 (UTC) X-HE-Tag: spoon42_3806b6c27069 X-Filterd-Recvd-Size: 2488 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf50.hostedemail.com (Postfix) with ESMTP for ; Thu, 27 Aug 2020 01:59:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=beWNVzgZ354ZbYDM6UV+ImYXsPQb9Cek38D6FY5zogI=; b=kHlQVYZ0dfhndpz3lruubqFXd7 kDM4vgr2g4JnOsZ5zEZYuY5WSd+PYVvD7KvsZJfnk4TnSzTYv1ADR1vWWrJRseC/g7vqWZP/I85Qp hqbr5AuxYNCSNfrz+wVO/13obIwhIVlPsQkFwqOqV11exTPtkUhG+/6URj82GigTXKL4warHFqgWa d8Ii9JN19GyA4t+ZjCnZBT3YQ6k2cKDICQ3Ci4SBGMcXDMTfxYkzfU7dcYbBuWbrMUaNgWZRLpZto POa4gXz8hOzblVz49gvxAd6+rTKpbYWChHoRAvjmikEj1ZBMHiSIxEOxFhCsCtw5Fj+5hicQ4jGCt klwkeiHQ==; Received: from willy by casper.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1kB7Bl-0006Wb-O0; Thu, 27 Aug 2020 01:58:53 +0000 Date: Thu, 27 Aug 2020 02:58:53 +0100 From: Matthew Wilcox To: Yafang Shao Cc: david@fromorbit.com, hch@infradead.org, darrick.wong@oracle.com, mhocko@kernel.org, akpm@linux-foundation.org, linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v7 2/2] xfs: avoid transaction reservation recursion Message-ID: <20200827015853.GA14765@casper.infradead.org> References: <20200827013444.24270-1-laoar.shao@gmail.com> <20200827013444.24270-3-laoar.shao@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200827013444.24270-3-laoar.shao@gmail.com> X-Rspamd-Queue-Id: F1920180AD811 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam02 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Aug 27, 2020 at 09:34:44AM +0800, Yafang Shao wrote: > @@ -1500,9 +1500,9 @@ iomap_do_writepage(struct page *page, struct writeback_control *wbc, void *data) > > /* > * Given that we do not allow direct reclaim to call us, we should > - * never be called in a recursive filesystem reclaim context. > + * never be called while in a filesystem transaction. > */ > - if (WARN_ON_ONCE(current->flags & PF_MEMALLOC_NOFS)) > + if (WARN_ON_ONCE(wbc->fstrans_recursion)) > goto redirty; Erm, Dave said: > I think we should just remove > the check completely from iomap_writepage() and move it up into > xfs_vm_writepage() and xfs_vm_writepages(). ie everywhere you set this new bit, just check current->journal_info.