From: Yafang Shao <laoar.shao@gmail.com>
To: david@fromorbit.com, hch@infradead.org, darrick.wong@oracle.com,
willy@infradead.org, mhocko@kernel.org,
akpm@linux-foundation.org
Cc: linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-mm@kvack.org, Yafang Shao <laoar.shao@gmail.com>
Subject: [PATCH v7 0/2] avoid xfs transaction reservation recursion
Date: Thu, 27 Aug 2020 09:34:42 +0800 [thread overview]
Message-ID: <20200827013444.24270-1-laoar.shao@gmail.com> (raw)
This patchset avoids transaction reservation recursion by reintroducing
the discarded PF_FSTRANS in a new way, suggested by Dave. In this new
implementation, four new helpers are introduced, which are
xfs_trans_context_{set, clear, update} and fstrans_context_active,
suggested by Dave. And re-using the task->journal_info to indicates
whehter the task is in fstrans or not, suggested by Willy
Patch #1 is picked from Willy's patchset "Overhaul memalloc_no*"[1]
[1] https://lore.kernel.org/linux-mm/20200625113122.7540-1-willy@infradead.org/
v7:
- check fstrans recursion for XFS only, by introducing a new member in
struct writeback_control.
v6:
- add Michal's ack and comment in patch #1.
v5:
- pick one of Willy's patch
- introduce four new helpers, per Dave
v4:
- retitle from "xfs: introduce task->in_fstrans for transaction reservation recursion protection"
- reuse current->journal_info, per Willy
Matthew Wilcox (Oracle) (1):
mm: Add become_kswapd and restore_kswapd
Yafang Shao (1):
xfs: avoid transaction reservation recursion
fs/iomap/buffered-io.c | 4 ++--
fs/xfs/libxfs/xfs_btree.c | 14 ++++++++------
fs/xfs/xfs_aops.c | 11 +++++++++--
fs/xfs/xfs_linux.h | 4 ----
fs/xfs/xfs_trans.c | 19 +++++++++----------
fs/xfs/xfs_trans.h | 30 ++++++++++++++++++++++++++++++
include/linux/sched/mm.h | 23 +++++++++++++++++++++++
include/linux/writeback.h | 3 +++
mm/vmscan.c | 16 +---------------
9 files changed, 85 insertions(+), 39 deletions(-)
--
2.18.4
next reply other threads:[~2020-08-27 1:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-27 1:34 Yafang Shao [this message]
2020-08-27 1:34 ` [PATCH v7 1/2] mm: Add become_kswapd and restore_kswapd Yafang Shao
2020-08-27 1:34 ` [PATCH v7 2/2] xfs: avoid transaction reservation recursion Yafang Shao
2020-08-27 1:58 ` Matthew Wilcox
2020-08-27 2:13 ` Yafang Shao
2020-08-27 2:42 ` Dave Chinner
2020-08-27 2:59 ` Yafang Shao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200827013444.24270-1-laoar.shao@gmail.com \
--to=laoar.shao@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=darrick.wong@oracle.com \
--cc=david@fromorbit.com \
--cc=hch@infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-xfs@vger.kernel.org \
--cc=mhocko@kernel.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox