From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EB515C433DF for ; Wed, 26 Aug 2020 18:17:29 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 85A2D207BC for ; Wed, 26 Aug 2020 18:17:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chrisdown.name header.i=@chrisdown.name header.b="MxnkLlVm" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 85A2D207BC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chrisdown.name Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id C67A56B0003; Wed, 26 Aug 2020 14:17:28 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C18B56B0006; Wed, 26 Aug 2020 14:17:28 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B07B86B0008; Wed, 26 Aug 2020 14:17:28 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0107.hostedemail.com [216.40.44.107]) by kanga.kvack.org (Postfix) with ESMTP id 9A1636B0003 for ; Wed, 26 Aug 2020 14:17:28 -0400 (EDT) Received: from smtpin27.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 485258248047 for ; Wed, 26 Aug 2020 18:17:28 +0000 (UTC) X-FDA: 77193527376.27.show56_1f1779327066 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin27.hostedemail.com (Postfix) with ESMTP id 14F503D663 for ; Wed, 26 Aug 2020 18:17:28 +0000 (UTC) X-HE-Tag: show56_1f1779327066 X-Filterd-Recvd-Size: 3534 Received: from mail-wr1-f68.google.com (mail-wr1-f68.google.com [209.85.221.68]) by imf45.hostedemail.com (Postfix) with ESMTP for ; Wed, 26 Aug 2020 18:17:27 +0000 (UTC) Received: by mail-wr1-f68.google.com with SMTP id c15so2770760wrs.11 for ; Wed, 26 Aug 2020 11:17:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chrisdown.name; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=y6ou1YIg6/FSZwY6sCFlxyJXSS2U1nvtnVmIFITiGPk=; b=MxnkLlVmtCcScdoWsKa8tkyeuJTdWCXa+GhoLiRAMUculUoCi6QlgZqMBu50pdj1E2 ENHqlArPo/uwpjZ7fjUAItyvX4NA/RGIirDmsw3a58G37cfKzv/UDyAqjYGifh8t+30d MJdnHS+XiGwEP2ZyX3m2e9ASoK19I/qva0lWY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=y6ou1YIg6/FSZwY6sCFlxyJXSS2U1nvtnVmIFITiGPk=; b=YsrQb5xtaE0zCEtnVPgv6ifw+KcsnDnM09MxknPvn7rYMQL7JiDsghar49DRrTR5QS /4/pxF7+fo0B3GO7XVVS8ABIbTYx87yBI+Jq8ndDG4GH5wAJzP8TVj8/fNuXmbgwKm/i SkN9U1d2JW2IfKyupEd+jB7jE+mBOOGKMVt7QwI2hF6btz4WczXKqBfeaW4OKWnZn7Sn vURX6DvGkNk6KvwZZt4eEPfImC2mtqWc7UkJHxtI0y6PNIpiOAGXP4sQNoDBl4vLn0lw 7DbXp6xgVnKF5PJ/osfhJYfv+d5Q/fqn4qwYIeTszTw/6NR2xt4JJ5njOlEBdmZV5MYW ENMQ== X-Gm-Message-State: AOAM530QHK9YU9xQvHV207reSjyJCHJhVZr+H+cy3d69rypZJyn16Mwv zdt0R9Hc+pgjwiMhEFXMu7g7bg== X-Google-Smtp-Source: ABdhPJyGF58PxyEr+qbqcdQwHAQEk+hu1MR5ecSAWIYbHlJJCdRwZbU1YlLYxCkFy3QQ2wJ40JOTKw== X-Received: by 2002:adf:b1cf:: with SMTP id r15mr17866122wra.118.1598465846190; Wed, 26 Aug 2020 11:17:26 -0700 (PDT) Received: from localhost ([2a01:4b00:8432:8a00:63de:dd93:20be:f460]) by smtp.gmail.com with ESMTPSA id o2sm7485419wrj.21.2020.08.26.11.17.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 Aug 2020 11:17:25 -0700 (PDT) Date: Wed, 26 Aug 2020 19:17:25 +0100 From: Chris Down To: Xunlei Pang Cc: Johannes Weiner , Michal Hocko , Andrew Morton , Vladimir Davydov , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v2] mm: memcg: Fix memcg reclaim soft lockup Message-ID: <20200826181725.GA893402@chrisdown.name> References: <1598449622-108748-1-git-send-email-xlpang@linux.alibaba.com> <20200826141044.GA831829@chrisdown.name> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20200826141044.GA831829@chrisdown.name> User-Agent: Mutt/1.14.6 (2020-07-11) X-Rspamd-Queue-Id: 14F503D663 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam05 X-Bogosity: Ham, tests=bogofilter, spamicity=0.001045, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Chris Down writes: >Xunlei Pang writes: >>Add cond_resched() at the upper shrink_node_memcgs() to solve this >>issue, and any other possible issue like meomry.min protection. > >I understand the general intent of the patch, but could you clarify >your concern around memory protection? Oh, I see, your concern is just preemption in general rather than a fixing anything for the memory protection side. In which case, go for it, but I agree with Michael that it would be nice to send v3 with a clarifying comment. Acked-by: Chris Down