From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B5E7DC433E3 for ; Wed, 26 Aug 2020 14:10:49 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 781512078D for ; Wed, 26 Aug 2020 14:10:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chrisdown.name header.i=@chrisdown.name header.b="K6SqQUN8" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 781512078D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chrisdown.name Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 019A86B0003; Wed, 26 Aug 2020 10:10:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F0AFD6B0005; Wed, 26 Aug 2020 10:10:48 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E21166B0006; Wed, 26 Aug 2020 10:10:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0118.hostedemail.com [216.40.44.118]) by kanga.kvack.org (Postfix) with ESMTP id C92516B0003 for ; Wed, 26 Aug 2020 10:10:48 -0400 (EDT) Received: from smtpin11.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 836518248047 for ; Wed, 26 Aug 2020 14:10:48 +0000 (UTC) X-FDA: 77192905776.11.gold73_000141227065 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin11.hostedemail.com (Postfix) with ESMTP id 4D074180F8B8B for ; Wed, 26 Aug 2020 14:10:48 +0000 (UTC) X-HE-Tag: gold73_000141227065 X-Filterd-Recvd-Size: 3208 Received: from mail-qk1-f193.google.com (mail-qk1-f193.google.com [209.85.222.193]) by imf45.hostedemail.com (Postfix) with ESMTP for ; Wed, 26 Aug 2020 14:10:47 +0000 (UTC) Received: by mail-qk1-f193.google.com with SMTP id m7so1912505qki.12 for ; Wed, 26 Aug 2020 07:10:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chrisdown.name; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=07tvp8tVnrNw0e+tjr1QQnFIWOj/9N9xxnjDg1Dj00Y=; b=K6SqQUN8bdHK9sa+izhojjrbFpSuAwM1EM8gaAaK2UQZcDkd7jp4MSY9sWz+TgOC9q Ew/yxmU3JV0Qj/Wi0mw9w6VbwioBytFjVidB+UdF1T4c6UHFwcWGrBe4CT0q4M3aErez cVhOcHqjMFlaqBOXb9WKF666y6UVO1pGelyuA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=07tvp8tVnrNw0e+tjr1QQnFIWOj/9N9xxnjDg1Dj00Y=; b=DQZG7zLqMnL9M+8gaZpEaXod2+Yi3cQ3UplLXGg8oi1q9kV+tbshynZICRtwMCjiW3 ILv/BnnXssR7USoAYUUy8ndGsJ0dWWvLFPfuUGoyEzduCFe5DcphliYOazOsoPbBqPgZ S3jG2e9V92XThUqgWMVMgvQR5BL+U8Un0kfy46i9gQw7gXUX+iOj87hQilQF6IyQ9RaO QVTmch/LavSi80mczfZ2s0elIPOeNKeTSelyHiX6EbJpxwHmNNVJnH4NkSuFaTBnWyyp G+tX5YXwhySj7gc1SrPhTc0gwg7gSyl8nNVlJYdkatawywgGIOqPk240ot6i5SVD/pBV lXAg== X-Gm-Message-State: AOAM530XqkTA30GW8/TwI6QNbgyBIUknpntK79K/2S9dA4Lc9T8JR2fc 0foIO3xnC86isG1RK6aFSwDZ8w== X-Google-Smtp-Source: ABdhPJxZa4zJgLUey7TcyfqsJlg8vcBGdBaX+/p8GayLjM0Nnrm1I869irmbDo9IbceOBPOgmWa4iA== X-Received: by 2002:a37:7407:: with SMTP id p7mr14409179qkc.350.1598451047035; Wed, 26 Aug 2020 07:10:47 -0700 (PDT) Received: from localhost ([2620:10d:c091:480::1:fd2b]) by smtp.gmail.com with ESMTPSA id b23sm2041262qtp.41.2020.08.26.07.10.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 Aug 2020 07:10:46 -0700 (PDT) Date: Wed, 26 Aug 2020 15:10:44 +0100 From: Chris Down To: Xunlei Pang Cc: Johannes Weiner , Michal Hocko , Andrew Morton , Vladimir Davydov , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v2] mm: memcg: Fix memcg reclaim soft lockup Message-ID: <20200826141044.GA831829@chrisdown.name> References: <1598449622-108748-1-git-send-email-xlpang@linux.alibaba.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <1598449622-108748-1-git-send-email-xlpang@linux.alibaba.com> User-Agent: Mutt/1.14.6 (2020-07-11) X-Rspamd-Queue-Id: 4D074180F8B8B X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam02 X-Bogosity: Ham, tests=bogofilter, spamicity=0.012229, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Xunlei, Xunlei Pang writes: >Add cond_resched() at the upper shrink_node_memcgs() to solve this >issue, and any other possible issue like meomry.min protection. I understand the general intent of the patch, but could you clarify your concern around memory protection?