From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B8E4EC433E1 for ; Wed, 26 Aug 2020 13:01:58 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 7C19F20707 for ; Wed, 26 Aug 2020 13:01:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="rA8b32iO" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7C19F20707 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 0F7176B0003; Wed, 26 Aug 2020 09:01:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0A8746B0005; Wed, 26 Aug 2020 09:01:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id ED9C26B0006; Wed, 26 Aug 2020 09:01:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0194.hostedemail.com [216.40.44.194]) by kanga.kvack.org (Postfix) with ESMTP id D61D56B0003 for ; Wed, 26 Aug 2020 09:01:57 -0400 (EDT) Received: from smtpin16.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 68D14363F for ; Wed, 26 Aug 2020 13:01:57 +0000 (UTC) X-FDA: 77192732274.16.coal02_350733b27064 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin16.hostedemail.com (Postfix) with ESMTP id 06314100E5487 for ; Wed, 26 Aug 2020 13:01:52 +0000 (UTC) X-HE-Tag: coal02_350733b27064 X-Filterd-Recvd-Size: 2179 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf12.hostedemail.com (Postfix) with ESMTP for ; Wed, 26 Aug 2020 13:01:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=5u1D5S4hoVeCokFlRoXkBVpzv2N9WFWKvXd4EhVfhi4=; b=rA8b32iOdfxrZ/AbJyc/6/cBOA B8Bddh4hnWGDFx6m7P99J4EWdzI8+2+wK8G50+THis5kC2M+0Stkb4r1EjeJ607sDckOUdik4yjU7 eKZBNyp63OMiX8VnVEMcqEaz55bOC+VJ8ieLJWvRjE8tfRRWRyCpdPgZRpS6JPwghd3+r2jq1uZ0c +uXrVPtP2mW2B9BLt7s89IXAtiMLNDmK/WpCEp9nq/nMzGjKy40vxKaueDMxl6TOddgBK4V26eAtO kXkFJQ2+r5f6I3eihxFu2j9uVWDsNZ4bvVH4OVliy0f5Dpk/D8EwqHfp9GmzVF6+4mNULTJrhZJnt 20rPuOUw==; Received: from willy by casper.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1kAv3K-0002lN-QU; Wed, 26 Aug 2020 13:01:22 +0000 Date: Wed, 26 Aug 2020 14:01:22 +0100 From: Matthew Wilcox To: Jinyang He Cc: Huacai Chen , Jiaxun Yang , Andrew Morton , linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Tiezhu Yang , Xuefeng Li Subject: Re: [PATCH] MIPS: Loongson: Fix complie errors without CONFIG_SMP Message-ID: <20200826130122.GR17456@casper.infradead.org> References: <1598446407-8845-1-git-send-email-hejinyang@loongson.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1598446407-8845-1-git-send-email-hejinyang@loongson.cn> X-Rspamd-Queue-Id: 06314100E5487 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam04 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Aug 26, 2020 at 08:53:27PM +0800, Jinyang He wrote: > +++ b/arch/mips/include/asm/mach-loongson64/topology.h > @@ -4,7 +4,11 @@ > > #ifdef CONFIG_NUMA > > +#ifdef CONFIG_SMP > #define cpu_to_node(cpu) (cpu_logical_map(cpu) >> 2) > +#else > +#define cpu_to_node(cpu) 0 > +#endif Are you saying you've enabled NUMA without enabling SMP? Does that make sense?