From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C7135C433E1 for ; Wed, 26 Aug 2020 00:26:35 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 874642075E for ; Wed, 26 Aug 2020 00:26:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="hPbl4cLB" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 874642075E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 1EC418D0002; Tue, 25 Aug 2020 20:26:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1761A6B0007; Tue, 25 Aug 2020 20:26:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 03D428D0002; Tue, 25 Aug 2020 20:26:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0245.hostedemail.com [216.40.44.245]) by kanga.kvack.org (Postfix) with ESMTP id DED106B0006 for ; Tue, 25 Aug 2020 20:26:34 -0400 (EDT) Received: from smtpin10.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 93F881E1D for ; Wed, 26 Aug 2020 00:26:34 +0000 (UTC) X-FDA: 77190828708.10.pail47_061388f27060 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin10.hostedemail.com (Postfix) with ESMTP id 6900C169F9A for ; Wed, 26 Aug 2020 00:26:34 +0000 (UTC) X-HE-Tag: pail47_061388f27060 X-Filterd-Recvd-Size: 3095 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf11.hostedemail.com (Postfix) with ESMTP for ; Wed, 26 Aug 2020 00:26:33 +0000 (UTC) Received: from localhost.localdomain (c-73-231-172-41.hsd1.ca.comcast.net [73.231.172.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 206AA2075E; Wed, 26 Aug 2020 00:26:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1598401593; bh=iGuCdEza2nK/cqoHm5knAZs6jvpE13QKstHUiR1xJjc=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=hPbl4cLB0VYK6qrXhcJ59CHxQCmqJPUL8rtYRFGc3cTDBbl14eLVKMgYHEUNVKlOk JNBUOOO74WeChL2pndCpUFnyznvcD3rVlIOqhlMs8XB0bwUrG8RGhXLozotq9xMvfa E8vqc64d4r+2XM2LNZUH4aaxMxfuuZJ5pRLe8p3w= Date: Tue, 25 Aug 2020 17:26:30 -0700 From: Andrew Morton To: Oscar Salvador Cc: Dan Carpenter , linux-mm@kvack.org, nao.horiguchi@gmail.com Subject: Re: [bug report] mm,hwpoison: refactor soft_offline_huge_page and __soft_offline_page Message-Id: <20200825172630.f8a7b49f9d44ddbb6430bf58@linux-foundation.org> In-Reply-To: <20200825103922.GB18748@linux> References: <20200825102546.GA272697@mwanda> <20200825103513.GA18748@linux> <20200825103922.GB18748@linux> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 6900C169F9A X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam05 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, 25 Aug 2020 12:39:22 +0200 Oscar Salvador wrote: > On Tue, Aug 25, 2020 at 12:35:17PM +0200, Oscar Salvador wrote: > > > mm/memory-failure.c > > > 1749 static bool isolate_page(struct page *page, struct list_head *pagelist) > > > 1750 { > > > 1751 bool isolated = false; > > > 1752 bool lru = PageLRU(page); > > > 1753 > > > 1754 if (PageHuge(page)) { > > > 1755 isolated = isolate_huge_page(page, pagelist); > > > 1756 } else { > > > 1757 if (lru) > > > 1758 isolated = !isolate_lru_page(page); > > > 1759 else > > > 1760 isolated = !isolate_movable_page(page, ISOLATE_UNEVICTABLE); > > > 1761 > > > 1762 if (isolated) > > > 1763 list_add(&page->lru, pagelist); > > > 1764 > > > 1765 return -EBUSY; > > > > > > return false;? > > > > No, I this is a mistake, I guess it popped there when Naoya rebased. > > > > That return -EBUSY should be go. > > I'll let Andrew know, thanks. > > Unless I'm blind, it seems it wasn't Naoya's mistake either [1] > > @Andrew, any idea what happened here? That "return -EBUSY" should not be there. > > [1] https://patchwork.kernel.org/patch/11704101/ Yup, thanks. That patchset has required quite a bit of conflict resolution and I obviously failed to delete that line.