From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 99AB4C433DF for ; Tue, 25 Aug 2020 15:35:08 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 654BD20782 for ; Tue, 25 Aug 2020 15:35:08 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 654BD20782 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id E99B56B0024; Tue, 25 Aug 2020 11:35:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E48DD8D0001; Tue, 25 Aug 2020 11:35:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D37EC6B0027; Tue, 25 Aug 2020 11:35:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0180.hostedemail.com [216.40.44.180]) by kanga.kvack.org (Postfix) with ESMTP id B9A496B0024 for ; Tue, 25 Aug 2020 11:35:07 -0400 (EDT) Received: from smtpin25.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 7D4BD181AEF21 for ; Tue, 25 Aug 2020 15:35:07 +0000 (UTC) X-FDA: 77189489454.25.cave17_34103b72705c Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin25.hostedemail.com (Postfix) with ESMTP id 028511804E943 for ; Tue, 25 Aug 2020 15:34:51 +0000 (UTC) X-HE-Tag: cave17_34103b72705c X-Filterd-Recvd-Size: 2069 Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by imf06.hostedemail.com (Postfix) with ESMTP for ; Tue, 25 Aug 2020 15:34:50 +0000 (UTC) IronPort-SDR: xMEr+hXvWO//EGtLpyEHuIqRlvkoxKBmn2kHP2DlEj921xEcuFy23fcZyiFbMcbYtuD+u0YlyP 4weKYy8ngYmw== X-IronPort-AV: E=McAfee;i="6000,8403,9723"; a="153709468" X-IronPort-AV: E=Sophos;i="5.76,353,1592895600"; d="scan'208";a="153709468" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Aug 2020 08:34:49 -0700 IronPort-SDR: vzkXNWqHEhv+u8xJUKhBznoFEov86BCFyq+MANnIg2WkjyXzZyoTaqIIBur1AYG6N2rzf5JWKf OayyfXViTUbw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.76,353,1592895600"; d="scan'208";a="328898092" Received: from tassilo.jf.intel.com (HELO tassilo.localdomain) ([10.7.201.21]) by orsmga008.jf.intel.com with ESMTP; 25 Aug 2020 08:34:49 -0700 Received: by tassilo.localdomain (Postfix, from userid 1000) id 2C1D1301C53; Tue, 25 Aug 2020 08:25:09 -0700 (PDT) Date: Tue, 25 Aug 2020 08:25:09 -0700 From: Andi Kleen To: Muchun Song Cc: mike.kravetz@oracle.com, akpm@linux-foundation.org, npiggin@suse.de, agl@us.ibm.com, nacc@us.ibm.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm/hugetlb: Fix a race between hugetlb sysctl handlers Message-ID: <20200825152509.GO1509399@tassilo.jf.intel.com> References: <20200822095328.61306-1-songmuchun@bytedance.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200822095328.61306-1-songmuchun@bytedance.com> X-Rspamd-Queue-Id: 028511804E943 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam03 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > Fixes: e5ff215941d5 ("hugetlb: multiple hstates for multiple page sizes") I don't think the Fixes line is correct. The original patch just used a global variable and didn't have this race. It must have been added later in some other patch that added hugetlb_sysctl_handler_common. -Andi