From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A8604C433DF for ; Tue, 25 Aug 2020 10:35:22 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 722EA20715 for ; Tue, 25 Aug 2020 10:35:22 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 722EA20715 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id F2F4D6B002E; Tue, 25 Aug 2020 06:35:21 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EE02C6B0030; Tue, 25 Aug 2020 06:35:21 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DF5D76B0031; Tue, 25 Aug 2020 06:35:21 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0138.hostedemail.com [216.40.44.138]) by kanga.kvack.org (Postfix) with ESMTP id CA7056B002E for ; Tue, 25 Aug 2020 06:35:21 -0400 (EDT) Received: from smtpin11.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 89ADD3629 for ; Tue, 25 Aug 2020 10:35:21 +0000 (UTC) X-FDA: 77188734042.11.knot68_63096562705b Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin11.hostedemail.com (Postfix) with ESMTP id 5570E180F8B81 for ; Tue, 25 Aug 2020 10:35:21 +0000 (UTC) X-HE-Tag: knot68_63096562705b X-Filterd-Recvd-Size: 2280 Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by imf45.hostedemail.com (Postfix) with ESMTP for ; Tue, 25 Aug 2020 10:35:20 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 21C01B118; Tue, 25 Aug 2020 10:35:50 +0000 (UTC) Date: Tue, 25 Aug 2020 12:35:17 +0200 From: Oscar Salvador To: Dan Carpenter Cc: linux-mm@kvack.org, nao.horiguchi@gmail.com Subject: Re: [bug report] mm,hwpoison: refactor soft_offline_huge_page and __soft_offline_page Message-ID: <20200825103513.GA18748@linux> References: <20200825102546.GA272697@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200825102546.GA272697@mwanda> User-Agent: Mutt/1.10.1 (2018-07-13) X-Rspamd-Queue-Id: 5570E180F8B81 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam01 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Aug 25, 2020 at 01:25:46PM +0300, Dan Carpenter wrote: > Hello Oscar Salvador, > > The patch e5bcf91e5cc6: "mm,hwpoison: refactor soft_offline_huge_page > and __soft_offline_page" from Aug 20, 2020, leads to the following > static checker warning: > > mm/memory-failure.c:1765 isolate_page() > warn: signedness bug returning '(-16)' Hi Dan, thanks for spotting this. > > mm/memory-failure.c > 1749 static bool isolate_page(struct page *page, struct list_head *pagelist) > 1750 { > 1751 bool isolated = false; > 1752 bool lru = PageLRU(page); > 1753 > 1754 if (PageHuge(page)) { > 1755 isolated = isolate_huge_page(page, pagelist); > 1756 } else { > 1757 if (lru) > 1758 isolated = !isolate_lru_page(page); > 1759 else > 1760 isolated = !isolate_movable_page(page, ISOLATE_UNEVICTABLE); > 1761 > 1762 if (isolated) > 1763 list_add(&page->lru, pagelist); > 1764 > 1765 return -EBUSY; > > return false;? No, I this is a mistake, I guess it popped there when Naoya rebased. That return -EBUSY should be go. I'll let Andrew know, thanks. -- Oscar Salvador SUSE L3