Re: [bug report] mm,hwpoison: refactor soft_offline_huge_page and __soft_offline_page

[Oscar Salvador <osalvador@suse.de>]

On Tue, Aug 25, 2020 at 01:25:46PM +0300, Dan Carpenter wrote:
> Hello Oscar Salvador,
> 
> The patch e5bcf91e5cc6: "mm,hwpoison: refactor soft_offline_huge_page
> and __soft_offline_page" from Aug 20, 2020, leads to the following
> static checker warning:
> 
> 	mm/memory-failure.c:1765 isolate_page()
> 	warn: signedness bug returning '(-16)'

Hi Dan,

thanks for spotting this.

> 
> mm/memory-failure.c
>   1749  static bool isolate_page(struct page *page, struct list_head *pagelist)
>   1750  {
>   1751          bool isolated = false;
>   1752          bool lru = PageLRU(page);
>   1753  
>   1754          if (PageHuge(page)) {
>   1755                  isolated = isolate_huge_page(page, pagelist);
>   1756          } else {
>   1757                  if (lru)
>   1758                          isolated = !isolate_lru_page(page);
>   1759                  else
>   1760                          isolated = !isolate_movable_page(page, ISOLATE_UNEVICTABLE);
>   1761  
>   1762                  if (isolated)
>   1763                          list_add(&page->lru, pagelist);
>   1764  
>   1765                  return -EBUSY;
> 
> return false;?

No, I this is a mistake, I guess it popped there when Naoya rebased.

That return -EBUSY should be go.
I'll let Andrew know, thanks.

-- 
Oscar Salvador
SUSE L3