From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Michal Hocko <mhocko@suse.com>
Cc: Qian Cai <cai@lca.pw>, Alex Shi <alex.shi@linux.alibaba.com>,
akpm@linux-foundation.org, Johannes Weiner <hannes@cmpxchg.org>,
Vladimir Davydov <vdavydov.dev@gmail.com>,
cgroups@vger.kernel.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, linux-next@vger.kernel.org
Subject: Re: [Resend PATCH 1/6] mm/memcg: warning on !memcg after readahead page charged
Date: Tue, 25 Aug 2020 09:00:54 +1000 [thread overview]
Message-ID: <20200825090054.3c5dd68a@canb.auug.org.au> (raw)
In-Reply-To: <20200824151045.GC3415@dhcp22.suse.cz>
[-- Attachment #1: Type: text/plain, Size: 1375 bytes --]
Hi Michal,
On Mon, 24 Aug 2020 17:10:45 +0200 Michal Hocko <mhocko@suse.com> wrote:
>
> On Mon 24-08-20 10:52:02, Qian Cai wrote:
> > On Thu, Aug 20, 2020 at 10:58:50AM -0400, Qian Cai wrote:
> > > On Tue, Aug 11, 2020 at 07:10:27PM +0800, Alex Shi wrote:
> > > > Since readahead page is charged on memcg too, in theory we don't have to
> > > > check this exception now. Before safely remove them all, add a warning
> > > > for the unexpected !memcg.
> > > >
> > > > Signed-off-by: Alex Shi <alex.shi@linux.alibaba.com>
> > > > Acked-by: Michal Hocko <mhocko@suse.com>
> > >
> > > This will trigger,
> >
> > Andrew, Stephen, can you drop this series for now? I did manage to trigger this
> > warning on all arches, powerpc, x86 and arm64 (below).
>
> Yes, I do agree. See http://lkml.kernel.org/r/20200824151013.GB3415@dhcp22.suse.cz
OK, I have removed the following from linux-next for today:
c443db77c9f3 ("mm/thp: narrow lru locking")
18bafefba73d ("mm/thp: remove code path which never got into")
5fb6c0683017 ("mm/thp: clean up lru_add_page_tail")
9d1d568727a8 ("mm/thp: move lru_add_page_tail func to huge_memory.c")
47eb331560ff ("mm/memcg: bail out early from swap accounting when memcg is disabled")
4b0d99a64d78 ("mm/memcg: warning on !memcg after readahead page charged")
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2020-08-24 23:01 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-11 11:10 Alex Shi
2020-08-11 11:10 ` [Resend PATCH 2/6] mm/memcg: remove useless check on page->mem_cgroup Alex Shi
2020-08-11 11:30 ` Michal Hocko
2020-08-11 12:42 ` Alex Shi
2020-08-11 12:54 ` Alex Shi
2020-08-11 13:56 ` Michal Hocko
2020-08-12 3:25 ` Alex Shi
2020-08-13 6:20 ` Michal Hocko
2020-08-13 9:45 ` Alex Shi
2020-08-13 11:01 ` Michal Hocko
2020-08-11 11:10 ` [Resend PATCH 3/6] mm/thp: move lru_add_page_tail func to huge_memory.c Alex Shi
2020-08-11 11:10 ` [Resend PATCH 4/6] mm/thp: clean up lru_add_page_tail Alex Shi
2020-08-11 11:10 ` [Resend PATCH 5/6] mm/thp: remove code path which never got into Alex Shi
2020-08-11 11:10 ` [Resend PATCH 6/6] mm/thp: narrow lru locking Alex Shi
2020-08-20 14:58 ` [Resend PATCH 1/6] mm/memcg: warning on !memcg after readahead page charged Qian Cai
2020-08-21 8:01 ` Michal Hocko
2020-08-21 12:39 ` Qian Cai
2020-08-21 13:48 ` Michal Hocko
2020-08-24 15:10 ` Michal Hocko
2020-08-25 1:25 ` Alex Shi
2020-08-25 2:04 ` Hugh Dickins
2020-08-27 6:00 ` Hugh Dickins
2020-08-25 7:25 ` Michal Hocko
2020-08-24 14:52 ` Qian Cai
2020-08-24 15:10 ` Michal Hocko
2020-08-24 23:00 ` Stephen Rothwell [this message]
2020-08-24 23:14 ` Alex Shi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200825090054.3c5dd68a@canb.auug.org.au \
--to=sfr@canb.auug.org.au \
--cc=akpm@linux-foundation.org \
--cc=alex.shi@linux.alibaba.com \
--cc=cai@lca.pw \
--cc=cgroups@vger.kernel.org \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-next@vger.kernel.org \
--cc=mhocko@suse.com \
--cc=vdavydov.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox