From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 835E2C433E3 for ; Tue, 25 Aug 2020 02:11:37 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id F16A42072D for ; Tue, 25 Aug 2020 02:11:36 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F16A42072D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.alibaba.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 90FC4900023; Mon, 24 Aug 2020 22:11:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8BFED8D0002; Mon, 24 Aug 2020 22:11:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7D7D6900023; Mon, 24 Aug 2020 22:11:36 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0032.hostedemail.com [216.40.44.32]) by kanga.kvack.org (Postfix) with ESMTP id 69ACC8D0002 for ; Mon, 24 Aug 2020 22:11:36 -0400 (EDT) Received: from smtpin23.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 349C2181AEF1A for ; Tue, 25 Aug 2020 02:11:36 +0000 (UTC) X-FDA: 77187464592.23.lake31_260cbb527058 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin23.hostedemail.com (Postfix) with ESMTP id 07D2F37604 for ; Tue, 25 Aug 2020 02:11:35 +0000 (UTC) X-HE-Tag: lake31_260cbb527058 X-Filterd-Recvd-Size: 2858 Received: from out30-131.freemail.mail.aliyun.com (out30-131.freemail.mail.aliyun.com [115.124.30.131]) by imf26.hostedemail.com (Postfix) with ESMTP for ; Tue, 25 Aug 2020 02:11:34 +0000 (UTC) X-Alimail-AntiSpam:AC=PASS;BC=-1|-1;BR=01201311R321e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e01358;MF=richard.weiyang@linux.alibaba.com;NM=1;PH=DS;RN=9;SR=0;TI=SMTPD_---0U6n3GN5_1598321489; Received: from localhost(mailfrom:richard.weiyang@linux.alibaba.com fp:SMTPD_---0U6n3GN5_1598321489) by smtp.aliyun-inc.com(127.0.0.1); Tue, 25 Aug 2020 10:11:29 +0800 Date: Tue, 25 Aug 2020 10:11:29 +0800 From: Wei Yang To: Oscar Salvador Cc: David Hildenbrand , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Michal Hocko , Andrew Morton , Wei Yang , Baoquan He , Pankaj Gupta Subject: Re: [PATCH v2 02/10] mm/memory_hotplug: enforce section granularity when onlining/offlining Message-ID: <20200825021129.GA78808@L-31X9LVDL-1304.local> Reply-To: Wei Yang References: <20200819175957.28465-1-david@redhat.com> <20200819175957.28465-3-david@redhat.com> <20200824103917.GB6315@linux> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200824103917.GB6315@linux> X-Rspamd-Queue-Id: 07D2F37604 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam04 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Aug 24, 2020 at 12:39:18PM +0200, Oscar Salvador wrote: >On Wed, Aug 19, 2020 at 07:59:49PM +0200, David Hildenbrand wrote: >> Already two people (including me) tried to offline subsections, because >> the function looks like it can deal with it. But we really can only >> online/offline full sections that are properly aligned (e.g., we can only >> mark full sections online/offline via SECTION_IS_ONLINE). >> >> Add a simple safety net to document the restriction now. Current users >> (core and powernv/memtrace) respect these restrictions. > >It's been a while since I looked at sub-section handling stuff so sorry to ask >this, but was it true that we can hot-{remove,add} sub-section granularity, while >we can only online /offline on section granularity? > Seems you are right. >> >> Acked-by: Michal Hocko >> Cc: Andrew Morton >> Cc: Michal Hocko >> Cc: Wei Yang >> Cc: Baoquan He >> Cc: Pankaj Gupta >> Cc: Oscar Salvador >> Signed-off-by: David Hildenbrand > >Reviewed-by: Oscar Salvador > > >-- >Oscar Salvador >SUSE L3 -- Wei Yang Help you, Help me