From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5DAA2C433E1 for ; Mon, 24 Aug 2020 19:22:23 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 122FD2078D for ; Mon, 24 Aug 2020 19:22:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="hB78woS9" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 122FD2078D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 9AB378D0005; Mon, 24 Aug 2020 15:22:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 95BB88D0003; Mon, 24 Aug 2020 15:22:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 870B38D0005; Mon, 24 Aug 2020 15:22:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0087.hostedemail.com [216.40.44.87]) by kanga.kvack.org (Postfix) with ESMTP id 733058D0003 for ; Mon, 24 Aug 2020 15:22:22 -0400 (EDT) Received: from smtpin22.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 3225A1EF1 for ; Mon, 24 Aug 2020 19:22:22 +0000 (UTC) X-FDA: 77186433324.22.dust79_0e08f3627055 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin22.hostedemail.com (Postfix) with ESMTP id B4B5A18038E68 for ; Mon, 24 Aug 2020 19:22:21 +0000 (UTC) X-HE-Tag: dust79_0e08f3627055 X-Filterd-Recvd-Size: 2624 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf04.hostedemail.com (Postfix) with ESMTP for ; Mon, 24 Aug 2020 19:22:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=kYjuOG42Pf1wUxE3HuOUosmUkIHVzXaCDeTnguR2S+w=; b=hB78woS93z82XwwFsV7G/ATAG8 C0SM1mmWjKAl/yzV/7UkikVcMgxdHFKOo8uWwYoxDOIfynZUuCOokRpnyKKvJa4O/hujdcFNx/3zt Plkq6oRbJJclVBQ2UyfXi9SMfWhr4hNk7sCQITVQJwJ4Vq4tlXnA9/aIwhySYtzTksla+ts0CJOcl ZdUghgSdZpdoEycIpMHVX2zx1CISvNY5h6JHi72L3T3pmgGjgufMNiio6WB7bQUTO0IjyboPmc0VR zaCm1ojsYb4PYufBWQ/n1h2WQtwtImtjmPmg8YZ/WZCZP9boCKoGhm6SOGpbvsDn0DK/mexegKk4d LVI4TQfw==; Received: from willy by casper.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1kAI2o-0004PU-M2; Mon, 24 Aug 2020 19:22:14 +0000 Date: Mon, 24 Aug 2020 20:22:14 +0100 From: Matthew Wilcox To: Andrew Morton Cc: Miaohe Lin , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm/mempool: Add 'else' to split mutually exclusive case Message-ID: <20200824192214.GF17456@casper.infradead.org> References: <20200824115354.7879-1-linmiaohe@huawei.com> <20200824121840.4cd7eb3dce03e8e1473221b3@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200824121840.4cd7eb3dce03e8e1473221b3@linux-foundation.org> X-Rspamd-Queue-Id: B4B5A18038E68 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam03 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000032, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Aug 24, 2020 at 12:18:40PM -0700, Andrew Morton wrote: > On Mon, 24 Aug 2020 07:53:54 -0400 Miaohe Lin wrote: > > > Add else to split mutually exclusive case and avoid some unnecessary check. > > > > --- a/mm/mempool.c > > +++ b/mm/mempool.c > > @@ -60,9 +60,8 @@ static void check_element(mempool_t *pool, void *element) > > /* Mempools backed by slab allocator */ > > if (pool->free == mempool_free_slab || pool->free == mempool_kfree) > > __check_element(pool, element, ksize(element)); > > - > > /* Mempools backed by page allocator */ > > - if (pool->free == mempool_free_pages) { > > + else if (pool->free == mempool_free_pages) { > > int order = (int)(long)pool->pool_data; > > void *addr = kmap_atomic((struct page *)element); > > > > It doesn't seem to change code generation (compiler is smart), but I > think it helps readability. Not with the comments where they are