From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CBA8DC433E1 for ; Mon, 24 Aug 2020 15:11:18 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id A605B206F0 for ; Mon, 24 Aug 2020 15:11:18 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A605B206F0 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 415C56B0010; Mon, 24 Aug 2020 11:11:18 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3C5D86B0022; Mon, 24 Aug 2020 11:11:18 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 302FF6B0023; Mon, 24 Aug 2020 11:11:18 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0030.hostedemail.com [216.40.44.30]) by kanga.kvack.org (Postfix) with ESMTP id 189C06B0010 for ; Mon, 24 Aug 2020 11:11:18 -0400 (EDT) Received: from smtpin27.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id ABD6F180ACF76 for ; Mon, 24 Aug 2020 15:11:17 +0000 (UTC) X-FDA: 77185800594.27.aunt31_37001fe27054 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin27.hostedemail.com (Postfix) with ESMTP id DBEBC3DA32 for ; Mon, 24 Aug 2020 15:10:49 +0000 (UTC) X-HE-Tag: aunt31_37001fe27054 X-Filterd-Recvd-Size: 1954 Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by imf04.hostedemail.com (Postfix) with ESMTP for ; Mon, 24 Aug 2020 15:10:49 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id E3AABAB8B; Mon, 24 Aug 2020 15:11:17 +0000 (UTC) Date: Mon, 24 Aug 2020 17:10:45 +0200 From: Michal Hocko To: Qian Cai Cc: Alex Shi , akpm@linux-foundation.org, Johannes Weiner , Vladimir Davydov , cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, sfr@canb.auug.org.au, linux-next@vger.kernel.org Subject: Re: [Resend PATCH 1/6] mm/memcg: warning on !memcg after readahead page charged Message-ID: <20200824151045.GC3415@dhcp22.suse.cz> References: <1597144232-11370-1-git-send-email-alex.shi@linux.alibaba.com> <20200820145850.GA4622@lca.pw> <20200824145201.GB4337@lca.pw> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200824145201.GB4337@lca.pw> X-Rspamd-Queue-Id: DBEBC3DA32 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam04 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon 24-08-20 10:52:02, Qian Cai wrote: > On Thu, Aug 20, 2020 at 10:58:50AM -0400, Qian Cai wrote: > > On Tue, Aug 11, 2020 at 07:10:27PM +0800, Alex Shi wrote: > > > Since readahead page is charged on memcg too, in theory we don't have to > > > check this exception now. Before safely remove them all, add a warning > > > for the unexpected !memcg. > > > > > > Signed-off-by: Alex Shi > > > Acked-by: Michal Hocko > > > > This will trigger, > > Andrew, Stephen, can you drop this series for now? I did manage to trigger this > warning on all arches, powerpc, x86 and arm64 (below). Yes, I do agree. See http://lkml.kernel.org/r/20200824151013.GB3415@dhcp22.suse.cz -- Michal Hocko SUSE Labs