From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 54FFBC433E1 for ; Mon, 24 Aug 2020 10:58:21 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id EF69D20738 for ; Mon, 24 Aug 2020 10:58:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EF69D20738 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 7336E6B0005; Mon, 24 Aug 2020 06:58:20 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6EA916B0007; Mon, 24 Aug 2020 06:58:20 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5D1506B0008; Mon, 24 Aug 2020 06:58:20 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0132.hostedemail.com [216.40.44.132]) by kanga.kvack.org (Postfix) with ESMTP id 427EC6B0005 for ; Mon, 24 Aug 2020 06:58:20 -0400 (EDT) Received: from smtpin02.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id F39D43628 for ; Mon, 24 Aug 2020 10:58:19 +0000 (UTC) X-FDA: 77185163160.02.tin25_380d29b27052 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin02.hostedemail.com (Postfix) with ESMTP id C69D110097AA0 for ; Mon, 24 Aug 2020 10:58:19 +0000 (UTC) X-HE-Tag: tin25_380d29b27052 X-Filterd-Recvd-Size: 2053 Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by imf13.hostedemail.com (Postfix) with ESMTP for ; Mon, 24 Aug 2020 10:58:19 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 1AC73AE17; Mon, 24 Aug 2020 10:58:48 +0000 (UTC) Date: Mon, 24 Aug 2020 12:58:16 +0200 From: Oscar Salvador To: David Hildenbrand Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Michal Hocko , Andrew Morton , Wei Yang , Baoquan He , Pankaj Gupta , Mel Gorman Subject: Re: [PATCH v2 08/10] mm/page_alloc: drop stale pageblock comment in memmap_init_zone*() Message-ID: <20200824105815.GH6315@linux> References: <20200819175957.28465-1-david@redhat.com> <20200819175957.28465-9-david@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200819175957.28465-9-david@redhat.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-Rspamd-Queue-Id: C69D110097AA0 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam01 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Aug 19, 2020 at 07:59:55PM +0200, David Hildenbrand wrote: > Commit ac5d2539b238 ("mm: meminit: reduce number of times pageblocks are > set during struct page init") moved the actual zone range check, leaving > only the alignment check for pageblocks. > > Let's drop the stale comment and make the pageblock check easier to read. > > Acked-by: Michal Hocko > Cc: Andrew Morton > Cc: Michal Hocko > Cc: Wei Yang > Cc: Baoquan He > Cc: Pankaj Gupta > Cc: Oscar Salvador > Cc: Mel Gorman > Signed-off-by: David Hildenbrand Reviewed-by: Oscar Salvador -- Oscar Salvador SUSE L3