From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 63440C433DF for ; Mon, 24 Aug 2020 08:17:46 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 3033020738 for ; Mon, 24 Aug 2020 08:17:46 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3033020738 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id C9EBF6B0005; Mon, 24 Aug 2020 04:17:45 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C28C36B0006; Mon, 24 Aug 2020 04:17:45 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B17A66B0007; Mon, 24 Aug 2020 04:17:45 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0069.hostedemail.com [216.40.44.69]) by kanga.kvack.org (Postfix) with ESMTP id 94D8D6B0005 for ; Mon, 24 Aug 2020 04:17:45 -0400 (EDT) Received: from smtpin21.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 4BFEA181AEF1F for ; Mon, 24 Aug 2020 08:17:45 +0000 (UTC) X-FDA: 77184758490.21.crush79_0a091ae27051 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin21.hostedemail.com (Postfix) with ESMTP id 06F3A180442C0 for ; Mon, 24 Aug 2020 08:17:45 +0000 (UTC) X-HE-Tag: crush79_0a091ae27051 X-Filterd-Recvd-Size: 1721 Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by imf21.hostedemail.com (Postfix) with ESMTP for ; Mon, 24 Aug 2020 08:17:44 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 066AAAC58; Mon, 24 Aug 2020 08:18:13 +0000 (UTC) Date: Mon, 24 Aug 2020 10:17:41 +0200 From: Oscar Salvador To: Li Xinhai Cc: linux-mm@kvack.org, akpm@linux-foundation.org, mhocko@suse.com, david@redhat.com Subject: Re: [PATCH] mm, isolation: avoid checking unmovable pages across pageblock boundary Message-ID: <20200824081736.GA3903@linux> References: <20200824065811.383266-1-lixinhai.lxh@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200824065811.383266-1-lixinhai.lxh@gmail.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-Rspamd-Queue-Id: 06F3A180442C0 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam03 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Aug 24, 2020 at 02:58:11PM +0800, Li Xinhai wrote: > In has_unmovable_pages(), the page parameter would not always be the > first page within a pageblock (see how the page pointer is passed in from > start_isolate_page_range() after call __first_valid_page()), so that > would cause checking unmovable pages span two pageblocks. > > After this patch, the checking is enforced within one pageblock no matter > the page is first one or not, and obey the semantics of this function. > > This issue is found by code inspection. > > Signed-off-by: Li Xinhai Unless I am missing something, this looks good to me. Reviewed-by: Oscar Salvador -- Oscar Salvador SUSE L3