From: Oscar Salvador <osalvador@suse.de>
To: Li Xinhai <lixinhai.lxh@gmail.com>
Cc: linux-mm@kvack.org, akpm@linux-foundation.org, mhocko@suse.com,
david@redhat.com
Subject: Re: [PATCH] mm, isolation: avoid checking unmovable pages across pageblock boundary
Date: Mon, 24 Aug 2020 10:17:41 +0200 [thread overview]
Message-ID: <20200824081736.GA3903@linux> (raw)
In-Reply-To: <20200824065811.383266-1-lixinhai.lxh@gmail.com>
On Mon, Aug 24, 2020 at 02:58:11PM +0800, Li Xinhai wrote:
> In has_unmovable_pages(), the page parameter would not always be the
> first page within a pageblock (see how the page pointer is passed in from
> start_isolate_page_range() after call __first_valid_page()), so that
> would cause checking unmovable pages span two pageblocks.
>
> After this patch, the checking is enforced within one pageblock no matter
> the page is first one or not, and obey the semantics of this function.
>
> This issue is found by code inspection.
>
> Signed-off-by: Li Xinhai <lixinhai.lxh@gmail.com>
Unless I am missing something, this looks good to me.
Reviewed-by: Oscar Salvador <osalvador@suse.de>
--
Oscar Salvador
SUSE L3
next prev parent reply other threads:[~2020-08-24 8:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-24 6:58 Li Xinhai
2020-08-24 8:17 ` Oscar Salvador [this message]
2020-08-25 8:26 ` Michal Hocko
2020-09-08 8:30 ` David Hildenbrand
2020-09-08 8:30 ` David Hildenbrand
2020-09-14 15:00 ` Michal Hocko
2020-09-14 16:36 ` David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200824081736.GA3903@linux \
--to=osalvador@suse.de \
--cc=akpm@linux-foundation.org \
--cc=david@redhat.com \
--cc=linux-mm@kvack.org \
--cc=lixinhai.lxh@gmail.com \
--cc=mhocko@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox