From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AE799C433E1 for ; Sat, 22 Aug 2020 21:25:48 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 125A320FC3 for ; Sat, 22 Aug 2020 21:25:47 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 125A320FC3 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ucw.cz Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 6AE8E8D0003; Sat, 22 Aug 2020 17:25:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6601C8D0002; Sat, 22 Aug 2020 17:25:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 577CF8D0003; Sat, 22 Aug 2020 17:25:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0112.hostedemail.com [216.40.44.112]) by kanga.kvack.org (Postfix) with ESMTP id 3F0BD8D0002 for ; Sat, 22 Aug 2020 17:25:47 -0400 (EDT) Received: from smtpin30.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id EE8581F06 for ; Sat, 22 Aug 2020 21:25:46 +0000 (UTC) X-FDA: 77179486692.30.cave69_360958e27045 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin30.hostedemail.com (Postfix) with ESMTP id BD45E180B3C83 for ; Sat, 22 Aug 2020 21:25:46 +0000 (UTC) X-HE-Tag: cave69_360958e27045 X-Filterd-Recvd-Size: 2988 Received: from jabberwock.ucw.cz (jabberwock.ucw.cz [46.255.230.98]) by imf16.hostedemail.com (Postfix) with ESMTP for ; Sat, 22 Aug 2020 21:25:46 +0000 (UTC) Received: by jabberwock.ucw.cz (Postfix, from userid 1017) id 391521C0BB0; Sat, 22 Aug 2020 23:25:42 +0200 (CEST) Date: Sat, 22 Aug 2020 23:25:41 +0200 From: Pavel Machek To: Chris Wilson Cc: Andrew Morton , Joerg Roedel , linux-mm@kvack.org, linux-kernel@vger.kernel.org, intel-gfx@lists.freedesktop.org, Linus Torvalds , Dave Airlie , Joonas Lahtinen , Rodrigo Vivi , David Vrabel , Joerg Roedel , stable@vger.kernel.org Subject: Re: [PATCH v2] mm: Track page table modifications in __apply_to_page_range() Message-ID: <20200822212541.GB14071@amd> References: <20200821123746.16904-1-joro@8bytes.org> <20200821133548.be58a3b0881b41a32759fa04@linux-foundation.org> <159804301810.32652.14249776487575415877@build.alporthouse.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="3uo+9/B/ebqu+fSQ" Content-Disposition: inline In-Reply-To: <159804301810.32652.14249776487575415877@build.alporthouse.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-Rspamd-Queue-Id: BD45E180B3C83 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam03 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: --3uo+9/B/ebqu+fSQ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi! > > > The __apply_to_page_range() function is also used to change and/or > > > allocate page-table pages in the vmalloc area of the address space. > > > Make sure these changes get synchronized to other page-tables in the > > > system by calling arch_sync_kernel_mappings() when necessary. > >=20 > > There's no description here of the user-visible effects of the bug.=20 > > Please always provide this, especially when proposing a -stable > > backport. Take pity upon all the downstream kernel maintainers who are > > staring at this wondering whether they should risk adding it to their > > kernels. >=20 > The impact appears limited to x86-32, where apply_to_page_range may miss > updating the PMD. That leads to explosions in drivers like Is this alone supposed to fix my problems with graphics on Thinkpad X60? Let me try... Best regards, Pavel =09 --=20 (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blo= g.html --3uo+9/B/ebqu+fSQ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAl9BjVUACgkQMOfwapXb+vLhDwCgsB41bHFj++LVnm2DkfXOTwEm k7UAoLObJuOLmCfuoVbRfRzOInnL8XTV =ayRy -----END PGP SIGNATURE----- --3uo+9/B/ebqu+fSQ--