From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D7200C433DF for ; Fri, 21 Aug 2020 20:03:42 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 926602072D for ; Fri, 21 Aug 2020 20:03:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="VwpreOGQ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 926602072D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id F29098D007A; Fri, 21 Aug 2020 16:03:41 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EDA2C8D0002; Fri, 21 Aug 2020 16:03:41 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DC7B58D007A; Fri, 21 Aug 2020 16:03:41 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0097.hostedemail.com [216.40.44.97]) by kanga.kvack.org (Postfix) with ESMTP id C79618D0002 for ; Fri, 21 Aug 2020 16:03:41 -0400 (EDT) Received: from smtpin25.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 75BAD1804FAC6 for ; Fri, 21 Aug 2020 20:03:41 +0000 (UTC) X-FDA: 77175651042.25.join64_1309b1e2703c Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin25.hostedemail.com (Postfix) with ESMTP id 246F01805110B for ; Fri, 21 Aug 2020 20:03:40 +0000 (UTC) X-HE-Tag: join64_1309b1e2703c X-Filterd-Recvd-Size: 2636 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf06.hostedemail.com (Postfix) with ESMTP for ; Fri, 21 Aug 2020 20:03:38 +0000 (UTC) Received: from localhost.localdomain (c-73-231-172-41.hsd1.ca.comcast.net [73.231.172.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id CFE7F2072D; Fri, 21 Aug 2020 20:03:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1598040218; bh=yqh1mdXpcSLnQ7YmrqYC/jS5nW+Rhe7nFWcK9Uz415c=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=VwpreOGQ0XVfittG9uiZKaO2QGduoOPGTakL0fyyd5UQouefUlXlEqRUvyk0YRGpW UPrvpEBOSLctgylICILjSGmQd0rt2dagEc3p5E/mi1Ho/F001o2VnbBzKtp8UBzn8D twXYtNfvFKqRz98L9ZlGahczx9N43sfxeZHnqQaM= Date: Fri, 21 Aug 2020 13:03:37 -0700 From: Andrew Morton To: Yang Shi Cc: syzbot , Linux Kernel Mailing List , Linux MM , syzkaller-bugs@googlegroups.com, Jan Kara Subject: Re: KASAN: use-after-free Read in do_madvise Message-Id: <20200821130337.f4d1f5cd665ab149e1f43ed5@linux-foundation.org> In-Reply-To: References: <000000000000e44b7d05ad6624df@google.com> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 246F01805110B X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam01 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, 21 Aug 2020 10:15:45 -0700 Yang Shi wrote: > It looks the vma is gone. The below patch should be able to fix it: > > diff --git a/mm/madvise.c b/mm/madvise.c > index dd1d43cf026d..d4aa5f776543 100644 > --- a/mm/madvise.c > +++ b/mm/madvise.c > @@ -289,9 +289,9 @@ static long madvise_willneed(struct vm_area_struct *vma, > */ > *prev = NULL; /* tell sys_madvise we drop mmap_lock */ > get_file(file); > - mmap_read_unlock(current->mm); > offset = (loff_t)(start - vma->vm_start) > + ((loff_t)vma->vm_pgoff << PAGE_SHIFT); > + mmap_read_unlock(current->mm); > vfs_fadvise(file, offset, end - start, POSIX_FADV_WILLNEED); > fput(file); > mmap_read_lock(current->mm); Oh geeze. Can you please send this along as a real patch, cc:stable, Fixes: 692fe62433d4c? Please cc Jan!