From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 40C41C433E3 for ; Thu, 20 Aug 2020 11:37:53 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id D5A412054F for ; Thu, 20 Aug 2020 11:37:52 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=citrix.com header.i=@citrix.com header.b="YxmrXdyh" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D5A412054F Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=citrix.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 6E6038D0014; Thu, 20 Aug 2020 07:37:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6973B8D0001; Thu, 20 Aug 2020 07:37:52 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 585BE8D0014; Thu, 20 Aug 2020 07:37:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0248.hostedemail.com [216.40.44.248]) by kanga.kvack.org (Postfix) with ESMTP id 41AD88D0001 for ; Thu, 20 Aug 2020 07:37:52 -0400 (EDT) Received: from smtpin20.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id F30A012EF for ; Thu, 20 Aug 2020 11:37:51 +0000 (UTC) X-FDA: 77170747542.20.wing26_2e0a59e27030 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin20.hostedemail.com (Postfix) with ESMTP id C6FCC180C07A3 for ; Thu, 20 Aug 2020 11:37:51 +0000 (UTC) X-HE-Tag: wing26_2e0a59e27030 X-Filterd-Recvd-Size: 5884 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by imf38.hostedemail.com (Postfix) with ESMTP for ; Thu, 20 Aug 2020 11:37:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1597923471; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=ZAirrqoSKLQOVqqJWBpKueJlrlW7WlH8PvguimBoqcg=; b=YxmrXdyhYxPy1JxvDdpcIl1EY1QZLbg3DWdtVOUA/9ho2jDzHCV299am jO4OvOMjjsjsD32y/lfYnnR06gkly0F5ySPbfd9hbTL1UJU3elAdeE57d YsshbUwThUB0mL2JWkTZPuBJEdhtFwINH+LuitnjBqePRVzTt/k1PNd/f 4=; Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: 4nBaFLnRpBD3ly5eX58Un7Lg/gZ5xsv5/Atyb5KJyqp4Du0CE2K9eo3l0sHk6/iSuj0LcBplRs py/XsJnWH7CdQGPSyE9v0yfz1MTNlSBZRIqxId7A4BgJJP378Gr9g+yK8exusIK58eq7+ig1yE VMXT2qTxtvv93zngpqJ42vMERlxiMlDzOz7+ksKh5LNya7cBceZYtkNHTRCz2Wl8K1LVGTgB08 DLgsy5wuMhnM/QCgRFDIz9M8mSd0hyZIKVqkd/EUnPb0uRZumstAnrPk+F9aHn+BCzwywOcY8+ faw= X-SBRS: 2.7 X-MesageID: 25271840 X-Ironport-Server: esa1.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.76,332,1592884800"; d="scan'208";a="25271840" Date: Thu, 20 Aug 2020 13:37:41 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Dan Williams CC: , David Hildenbrand , Vishal Verma , Dave Jiang , Andrew Morton , Jason Gunthorpe , Ira Weiny , Aneesh Kumar K.V , Johannes Thumshirn , "Logan Gunthorpe" , , , Subject: Re: [PATCH v4 1/2] memremap: rename MEMORY_DEVICE_DEVDAX to MEMORY_DEVICE_GENERIC Message-ID: <20200820113741.GV828@Air-de-Roger> References: <20200811094447.31208-1-roger.pau@citrix.com> <20200811094447.31208-2-roger.pau@citrix.com> <96e34f77-8f55-d8a2-4d1f-4f4b667b0472@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline In-Reply-To: <96e34f77-8f55-d8a2-4d1f-4f4b667b0472@redhat.com> X-ClientProxiedBy: AMSPEX02CAS02.citrite.net (10.69.22.113) To AMSPEX02CL02.citrite.net (10.69.22.126) X-Rspamd-Queue-Id: C6FCC180C07A3 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam03 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Aug 11, 2020 at 11:07:36PM +0200, David Hildenbrand wrote: > On 11.08.20 11:44, Roger Pau Monne wrote: > > This is in preparation for the logic behind MEMORY_DEVICE_DEVDAX also > > being used by non DAX devices. > >=20 > > No functional change intended. > >=20 > > Signed-off-by: Roger Pau Monn=C3=A9 > > --- > > Cc: Dan Williams > > Cc: Vishal Verma > > Cc: Dave Jiang > > Cc: Andrew Morton > > Cc: Jason Gunthorpe > > Cc: Ira Weiny > > Cc: "Aneesh Kumar K.V" > > Cc: Johannes Thumshirn > > Cc: Logan Gunthorpe > > Cc: linux-nvdimm@lists.01.org > > Cc: xen-devel@lists.xenproject.org > > Cc: linux-mm@kvack.org > > --- > > drivers/dax/device.c | 2 +- > > include/linux/memremap.h | 9 ++++----- > > mm/memremap.c | 2 +- > > 3 files changed, 6 insertions(+), 7 deletions(-) > >=20 > > diff --git a/drivers/dax/device.c b/drivers/dax/device.c > > index 4c0af2eb7e19..1e89513f3c59 100644 > > --- a/drivers/dax/device.c > > +++ b/drivers/dax/device.c > > @@ -429,7 +429,7 @@ int dev_dax_probe(struct device *dev) > > return -EBUSY; > > } > > =20 > > - dev_dax->pgmap.type =3D MEMORY_DEVICE_DEVDAX; > > + dev_dax->pgmap.type =3D MEMORY_DEVICE_GENERIC; > > addr =3D devm_memremap_pages(dev, &dev_dax->pgmap); > > if (IS_ERR(addr)) > > return PTR_ERR(addr); > > diff --git a/include/linux/memremap.h b/include/linux/memremap.h > > index 5f5b2df06e61..e5862746751b 100644 > > --- a/include/linux/memremap.h > > +++ b/include/linux/memremap.h > > @@ -46,11 +46,10 @@ struct vmem_altmap { > > * wakeup is used to coordinate physical address space management (e= x: > > * fs truncate/hole punch) vs pinned pages (ex: device dma). > > * > > - * MEMORY_DEVICE_DEVDAX: > > + * MEMORY_DEVICE_GENERIC: > > * Host memory that has similar access semantics as System RAM i.e. = DMA > > - * coherent and supports page pinning. In contrast to > > - * MEMORY_DEVICE_FS_DAX, this memory is access via a device-dax > > - * character device. > > + * coherent and supports page pinning. This is for example used by D= AX devices > > + * that expose memory using a character device. > > * > > * MEMORY_DEVICE_PCI_P2PDMA: > > * Device memory residing in a PCI BAR intended for use with Peer-to= -Peer > > @@ -60,7 +59,7 @@ enum memory_type { > > /* 0 is reserved to catch uninitialized type fields */ > > MEMORY_DEVICE_PRIVATE =3D 1, > > MEMORY_DEVICE_FS_DAX, > > - MEMORY_DEVICE_DEVDAX, > > + MEMORY_DEVICE_GENERIC, > > MEMORY_DEVICE_PCI_P2PDMA, > > }; > > =20 > > diff --git a/mm/memremap.c b/mm/memremap.c > > index 03e38b7a38f1..006dace60b1a 100644 > > --- a/mm/memremap.c > > +++ b/mm/memremap.c > > @@ -216,7 +216,7 @@ void *memremap_pages(struct dev_pagemap *pgmap, i= nt nid) > > return ERR_PTR(-EINVAL); > > } > > break; > > - case MEMORY_DEVICE_DEVDAX: > > + case MEMORY_DEVICE_GENERIC: > > need_devmap_managed =3D false; > > break; > > case MEMORY_DEVICE_PCI_P2PDMA: > >=20 >=20 > No strong opinion (@Dan?), I do wonder if a separate type would make se= nse. Gentle ping. Thanks, Roger.