* [PATCH] mm/highmem: Clean up endif comments
@ 2020-08-19 18:46 ira.weiny
2020-08-20 16:31 ` Mike Rapoport
0 siblings, 1 reply; 2+ messages in thread
From: ira.weiny @ 2020-08-19 18:46 UTC (permalink / raw)
To: Andrew Morton; +Cc: Ira Weiny, linux-mm, linux-kernel
From: Ira Weiny <ira.weiny@intel.com>
The #endif at the end of the file matches up with the '#if
defined(HASHED_PAGE_VIRTUAL)' on line 374. Not the CONFIG_HIGHMEM #if
earlier.
Fix comments on both of the #endif's to indicate the correct end of
blocks for each.
Signed-off-by: Ira Weiny <ira.weiny@intel.com>
---
mm/highmem.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/mm/highmem.c b/mm/highmem.c
index 64d8dea47dd1..1352a27951e3 100644
--- a/mm/highmem.c
+++ b/mm/highmem.c
@@ -369,7 +369,7 @@ void kunmap_high(struct page *page)
}
EXPORT_SYMBOL(kunmap_high);
-#endif
+#endif /* CONFIG_HIGHMEM */
#if defined(HASHED_PAGE_VIRTUAL)
@@ -481,4 +481,4 @@ void __init page_address_init(void)
}
}
-#endif /* defined(CONFIG_HIGHMEM) && !defined(WANT_PAGE_VIRTUAL) */
+#endif /* defined(HASHED_PAGE_VIRTUAL) */
--
2.25.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] mm/highmem: Clean up endif comments
2020-08-19 18:46 [PATCH] mm/highmem: Clean up endif comments ira.weiny
@ 2020-08-20 16:31 ` Mike Rapoport
0 siblings, 0 replies; 2+ messages in thread
From: Mike Rapoport @ 2020-08-20 16:31 UTC (permalink / raw)
To: ira.weiny; +Cc: Andrew Morton, linux-mm, linux-kernel
On Wed, Aug 19, 2020 at 11:46:35AM -0700, ira.weiny@intel.com wrote:
> From: Ira Weiny <ira.weiny@intel.com>
>
> The #endif at the end of the file matches up with the '#if
> defined(HASHED_PAGE_VIRTUAL)' on line 374. Not the CONFIG_HIGHMEM #if
> earlier.
>
> Fix comments on both of the #endif's to indicate the correct end of
> blocks for each.
>
> Signed-off-by: Ira Weiny <ira.weiny@intel.com>
Reviewed-by: Mike Rapoport <rppt@linux.ibm.com>
> ---
> mm/highmem.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/mm/highmem.c b/mm/highmem.c
> index 64d8dea47dd1..1352a27951e3 100644
> --- a/mm/highmem.c
> +++ b/mm/highmem.c
> @@ -369,7 +369,7 @@ void kunmap_high(struct page *page)
> }
>
> EXPORT_SYMBOL(kunmap_high);
> -#endif
> +#endif /* CONFIG_HIGHMEM */
>
> #if defined(HASHED_PAGE_VIRTUAL)
>
> @@ -481,4 +481,4 @@ void __init page_address_init(void)
> }
> }
>
> -#endif /* defined(CONFIG_HIGHMEM) && !defined(WANT_PAGE_VIRTUAL) */
> +#endif /* defined(HASHED_PAGE_VIRTUAL) */
> --
> 2.25.1
>
>
--
Sincerely yours,
Mike.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-08-20 16:32 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-19 18:46 [PATCH] mm/highmem: Clean up endif comments ira.weiny
2020-08-20 16:31 ` Mike Rapoport
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox