From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6245BC433DF for ; Wed, 19 Aug 2020 20:12:14 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 22DF32078D for ; Wed, 19 Aug 2020 20:12:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="fJn0qJu+" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 22DF32078D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 929E66B00C3; Wed, 19 Aug 2020 16:12:13 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8B3D96B00C4; Wed, 19 Aug 2020 16:12:13 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7A3648D0037; Wed, 19 Aug 2020 16:12:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0040.hostedemail.com [216.40.44.40]) by kanga.kvack.org (Postfix) with ESMTP id 60F9B6B00C3 for ; Wed, 19 Aug 2020 16:12:13 -0400 (EDT) Received: from smtpin30.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 14BBF180AD802 for ; Wed, 19 Aug 2020 20:12:13 +0000 (UTC) X-FDA: 77168414946.30.shop44_29131b52702a Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin30.hostedemail.com (Postfix) with ESMTP id D012C180B3C85 for ; Wed, 19 Aug 2020 20:12:12 +0000 (UTC) X-HE-Tag: shop44_29131b52702a X-Filterd-Recvd-Size: 2002 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf32.hostedemail.com (Postfix) with ESMTP for ; Wed, 19 Aug 2020 20:12:12 +0000 (UTC) Received: from localhost.localdomain (c-73-231-172-41.hsd1.ca.comcast.net [73.231.172.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 60F7C2078D; Wed, 19 Aug 2020 20:12:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1597867931; bh=wCiqSWw7+dELXrP0i9ukDIaG6ZmIp6AkyvOOF38BHhE=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=fJn0qJu+brZMju6egaLEThAXIfIpqw+HI2cdO85N+QLjA8pTMhMzxD+EcD0kyLtCF CzUbgTsJGGXpdpSWLFyvrGIsHJvPrAx/Skq5fVj259IuWkDmkyBYkE9qdfHUvHuutN 2YoHbMEPsjDuhAONpVpfC2oytz3MIYXF3Ie/oXyY= Date: Wed, 19 Aug 2020 13:12:10 -0700 From: Andrew Morton To: Wei Yang Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] mm/mmap: rename __vma_unlink_common() to __vma_unlink() Message-Id: <20200819131210.dc5c045a626d1bf4475214d1@linux-foundation.org> In-Reply-To: <20200809232057.23477-1-richard.weiyang@linux.alibaba.com> References: <20200809232057.23477-1-richard.weiyang@linux.alibaba.com> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: D012C180B3C85 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam02 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, 10 Aug 2020 07:20:56 +0800 Wei Yang wrote: > __vma_unlink_common() and __vma_unlink() are counterparts. Since there is I assume you meant "__vma_link()" here? > not function named __vma_unlink(), let's rename it to __vma_unlink() to > make the code more self-explain and easy for audience to understand. > > Otherwise we may expect there are several variants of vma_unlink and > __vma_unlink_common() is used by them.