From: Andrew Morton <akpm@linux-foundation.org>
To: Wei Yang <richard.weiyang@linux.alibaba.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] mm/mmap: rename __vma_unlink_common() to __vma_unlink()
Date: Wed, 19 Aug 2020 13:12:10 -0700 [thread overview]
Message-ID: <20200819131210.dc5c045a626d1bf4475214d1@linux-foundation.org> (raw)
In-Reply-To: <20200809232057.23477-1-richard.weiyang@linux.alibaba.com>
On Mon, 10 Aug 2020 07:20:56 +0800 Wei Yang <richard.weiyang@linux.alibaba.com> wrote:
> __vma_unlink_common() and __vma_unlink() are counterparts. Since there is
I assume you meant "__vma_link()" here?
> not function named __vma_unlink(), let's rename it to __vma_unlink() to
> make the code more self-explain and easy for audience to understand.
>
> Otherwise we may expect there are several variants of vma_unlink and
> __vma_unlink_common() is used by them.
next prev parent reply other threads:[~2020-08-19 20:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-09 23:20 Wei Yang
2020-08-09 23:20 ` [PATCH 2/2] mm/mmap: leverage vma_rb_erase_ignore() to implement vma_rb_erase() Wei Yang
2020-08-19 20:12 ` Andrew Morton [this message]
2020-08-20 2:15 ` [PATCH 1/2] mm/mmap: rename __vma_unlink_common() to __vma_unlink() Wei Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200819131210.dc5c045a626d1bf4475214d1@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=richard.weiyang@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox