From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 431B1C433DF for ; Wed, 19 Aug 2020 19:37:17 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 08EB02083B for ; Wed, 19 Aug 2020 19:37:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="sXBor1Sa" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 08EB02083B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 8274B8D0053; Wed, 19 Aug 2020 15:37:16 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7D7CE8D0037; Wed, 19 Aug 2020 15:37:16 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6F00B8D0053; Wed, 19 Aug 2020 15:37:16 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0061.hostedemail.com [216.40.44.61]) by kanga.kvack.org (Postfix) with ESMTP id 58B538D0037 for ; Wed, 19 Aug 2020 15:37:16 -0400 (EDT) Received: from smtpin22.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 00FAD180AD817 for ; Wed, 19 Aug 2020 19:37:15 +0000 (UTC) X-FDA: 77168326830.22.dog77_53038bd2702a Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin22.hostedemail.com (Postfix) with ESMTP id BC09B18038E60 for ; Wed, 19 Aug 2020 19:37:15 +0000 (UTC) X-HE-Tag: dog77_53038bd2702a X-Filterd-Recvd-Size: 2298 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf24.hostedemail.com (Postfix) with ESMTP for ; Wed, 19 Aug 2020 19:37:15 +0000 (UTC) Received: from localhost.localdomain (c-73-231-172-41.hsd1.ca.comcast.net [73.231.172.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 283BB207BB; Wed, 19 Aug 2020 19:37:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1597865834; bh=FSqnN4eyzzekQI8QmT0uMExpMLfdw+JltxvAtUnqXgo=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=sXBor1SafBP+oLCCppMCOKcFNPi3DJMASjl+uB1WLxVq7KRGp76oq08t+OSFzxmRZ jsIWryqeU+FGIDsYM0RVCrFLjT1KDQQhW54jBxl6Mq84LAYaouHYxHkS/veJJyMB66 0y74lEiqQ5QQOMPfIVEk8XRQBbGyjn9dmAo8JLoY= Date: Wed, 19 Aug 2020 12:37:13 -0700 From: Andrew Morton To: Cc: Christoph Lameter , Pekka Enberg , "David Rientjes" , Joonsoo Kim , , "open list:SLAB ALLOCATOR" , open list Subject: Re: [PATCH] mm/slub: make add_full() condition more explicit Message-Id: <20200819123713.38a2509a2b7651f14db33e61@linux-foundation.org> In-Reply-To: <20200811020240.1231-1-wuyun.wu@huawei.com> References: <20200811020240.1231-1-wuyun.wu@huawei.com> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: BC09B18038E60 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam03 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, 11 Aug 2020 10:02:36 +0800 wrote: > From: Abel Wu > > The commit below is incomplete, as it didn't handle the add_full() part. > commit a4d3f8916c65 ("slub: remove useless kmem_cache_debug() before remove_full()") > > This patch checks for SLAB_STORE_USER instead of kmem_cache_debug(), > since that should be the only context in which we need the list_lock for > add_full(). > Does this contradict what the comment tells us? * This also ensures that the scanning of full * slabs from diagnostic functions will not see * any frozen slabs.