From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EA1B7C433E3 for ; Wed, 19 Aug 2020 08:27:55 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id B0090207DA for ; Wed, 19 Aug 2020 08:27:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="fbutXiAa" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B0090207DA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 41CC48D0002; Wed, 19 Aug 2020 04:27:55 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3A6AC6B0072; Wed, 19 Aug 2020 04:27:55 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 26E988D0002; Wed, 19 Aug 2020 04:27:55 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0027.hostedemail.com [216.40.44.27]) by kanga.kvack.org (Postfix) with ESMTP id 0ECE76B0071 for ; Wed, 19 Aug 2020 04:27:55 -0400 (EDT) Received: from smtpin03.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id B4B3B82499B9 for ; Wed, 19 Aug 2020 08:27:54 +0000 (UTC) X-FDA: 77166640068.03.care83_1c13f4127026 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin03.hostedemail.com (Postfix) with ESMTP id 8E33928A4E8 for ; Wed, 19 Aug 2020 08:27:54 +0000 (UTC) X-HE-Tag: care83_1c13f4127026 X-Filterd-Recvd-Size: 2379 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf40.hostedemail.com (Postfix) with ESMTP for ; Wed, 19 Aug 2020 08:27:54 +0000 (UTC) Received: from willie-the-truck (236.31.169.217.in-addr.arpa [217.169.31.236]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 8306C20738; Wed, 19 Aug 2020 08:27:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1597825673; bh=xkrOW1eiodxf6e55kbWanf+5qeDDwj1oob7ZKgc2bX4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=fbutXiAaMlm/H9YbBaBayrJHz65E2rmbWgxqxuAdUYACLzGZK6lRujSRmkHg6MBoT jkPxKn2GE0mKyF++r7fCvlhIJSNDTQcpbUNxAFV9oO15FPtc09hhUgH/hTAm9Ueu5o xhq/e/O3Z4iYD7DK533RIYA+NrqZcpkxHyKy533M= Date: Wed, 19 Aug 2020 09:27:47 +0100 From: Will Deacon To: Linus Torvalds Cc: Yang Shi , Yu Xu , Johannes Weiner , Catalin Marinas , Will Deacon , Andrew Morton , Linux-MM , Linux Kernel Mailing List , stable Subject: Re: [v3 PATCH] mm/memory.c: skip spurious TLB flush for retried page fault Message-ID: <20200819082747.GA17345@willie-the-truck> References: <20200815043041.132195-1-shy828301@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-Rspamd-Queue-Id: 8E33928A4E8 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam04 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Aug 18, 2020 at 12:01:43PM -0700, Linus Torvalds wrote: > On Mon, Aug 17, 2020 at 2:04 PM Yang Shi wrote: > > > > We could just skip the spurious TLB flush to mitigate the regression. > > Ok, this patch I will apply. Cheers. > I still hope that arm64 fixes (maybe already fixed) their spurious TLB > function, and I think we should rename it to make sure everybody > understands it's local, but in the meantime this patch hides the > regression and isn't wrong. I'll look at it for 5.10. Will