Re: [PATCH 2/3] dma-buf: heaps: add chunk heap to dmabuf heaps

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 3102 bytes --]

Hi Hyesoo,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on linus/master]
[also build test ERROR on v5.9-rc1 next-20200818]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Hyesoo-Yu/Chunk-Heap-Support-on-DMA-HEAP/20200818-154733
base:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 06a4ec1d9dc652e17ee3ac2ceb6c7cf6c2b75cdd
config: microblaze-randconfig-r016-20200818 (attached as .config)
compiler: microblaze-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=microblaze 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   drivers/dma-buf/heaps/chunk_heap.c: In function 'chunk_alloc_pages':
>> drivers/dma-buf/heaps/chunk_heap.c:72:9: error: implicit declaration of function 'alloc_pages_bulk'; did you mean 'alloc_pages_node'? [-Werror=implicit-function-declaration]
      72 |   ret = alloc_pages_bulk(base, base + pageblock_nr_pages, MIGRATE_CMA,
         |         ^~~~~~~~~~~~~~~~
         |         alloc_pages_node
   cc1: some warnings being treated as errors

# https://github.com/0day-ci/linux/commit/6032a6b2cbc0a798f6548d6f58fdd46eccaaf764
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Hyesoo-Yu/Chunk-Heap-Support-on-DMA-HEAP/20200818-154733
git checkout 6032a6b2cbc0a798f6548d6f58fdd46eccaaf764
vim +72 drivers/dma-buf/heaps/chunk_heap.c

    54	
    55	static int chunk_alloc_pages(struct chunk_heap *chunk_heap, struct page **pages,
    56				     unsigned int order, unsigned int count)
    57	{
    58		unsigned long base;
    59		unsigned int i = 0, nr_block = 0, nr_elem, ret;
    60	
    61		while (count) {
    62			/*
    63			 * If the number of scanned page block is the same as max block,
    64			 * the tries of allocation fails.
    65			 */
    66			if (nr_block++ == chunk_heap->max_num_pageblocks) {
    67				ret = -ENOMEM;
    68				goto err_bulk;
    69			}
    70			base = chunk_get_next_pfn(chunk_heap);
    71			nr_elem = min_t(unsigned int, count, pageblock_nr_pages >> order);
  > 72			ret = alloc_pages_bulk(base, base + pageblock_nr_pages, MIGRATE_CMA,
    73					       GFP_KERNEL, order, nr_elem, pages + i);
    74			if (ret < 0)
    75				goto err_bulk;
    76	
    77			i += ret;
    78			count -= ret;
    79		}
    80	
    81		return 0;
    82	
    83	err_bulk:
    84		while (i-- > 0)
    85			__free_pages(pages[i], order);
    86	
    87		return ret;
    88	}
    89	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 30661 bytes --]