From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BAEEDC433DF for ; Tue, 18 Aug 2020 10:18:00 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 7D79B204EA for ; Tue, 18 Aug 2020 10:18:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chrisdown.name header.i=@chrisdown.name header.b="s4u3GuRF" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7D79B204EA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chrisdown.name Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 0B2DF6B0029; Tue, 18 Aug 2020 06:18:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 065676B002A; Tue, 18 Aug 2020 06:18:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E6D546B002C; Tue, 18 Aug 2020 06:17:59 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0057.hostedemail.com [216.40.44.57]) by kanga.kvack.org (Postfix) with ESMTP id D23056B0029 for ; Tue, 18 Aug 2020 06:17:59 -0400 (EDT) Received: from smtpin14.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 8E8A9824556B for ; Tue, 18 Aug 2020 10:17:59 +0000 (UTC) X-FDA: 77163288678.14.fog17_42074fd2701e Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin14.hostedemail.com (Postfix) with ESMTP id 5F62918229837 for ; Tue, 18 Aug 2020 10:17:59 +0000 (UTC) X-HE-Tag: fog17_42074fd2701e X-Filterd-Recvd-Size: 4252 Received: from mail-qt1-f194.google.com (mail-qt1-f194.google.com [209.85.160.194]) by imf29.hostedemail.com (Postfix) with ESMTP for ; Tue, 18 Aug 2020 10:17:58 +0000 (UTC) Received: by mail-qt1-f194.google.com with SMTP id f19so10194291qtp.2 for ; Tue, 18 Aug 2020 03:17:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chrisdown.name; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=m1d0Rse+qIi8qOmerhrf+MBXKELTuAtcs3p/xFrqf9w=; b=s4u3GuRFjGb61CKAXSbV1lMqnOMke9WVYpJMh0BBQqdPfrVKbnnOMGI9JvyBbgPm6e x6rVvOlI1ANNxy8+m3bcc1IECDj2KsJGcWVy2WR+CvANx/bwNtWdEoEKDgNVzfp3pHop hA9rOJBnJ6hFK8QUbuzjs02965lEQZmkx0qyA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=m1d0Rse+qIi8qOmerhrf+MBXKELTuAtcs3p/xFrqf9w=; b=l0eBQ1Otw2H0HRDboA3yc2W13VxXWNpktyJhepCSDmNInG+tJVwJIEl8utuuFcN4AP DRUEEhMb+/m0OHTuI3tz4mGcWrGOvhGIFcXdU+ln2lR1XDLig5TSio7dQCdhGQAVZ4Hx hPJzE3sZ0d/iw7Y9+SLgG2BTNBT/ZTprsPTcOxSirNPMT9nEdodCfaPxBEIdkoj+N0Lq SwuOe3hnfFwWj6UBpnLeUE3LUqZWYf/I3YTOCPZm6qGyLHEof1e1OhN85iwbVLp27c6i Gxyi8/S8cGIrpym48NlTTBVBOWGo5l8I7kmg5EZhlg5hhif2Y0Xhmg5idE+xZcDo4LRs QOeQ== X-Gm-Message-State: AOAM530rn9QxF3aooMfJWHfp+4NqYpumng8dTUZioTcGwwXU9+lJbYIz phtQ3YwbFGYicoCMJgl/1aXqNA== X-Google-Smtp-Source: ABdhPJwu2U26qaTDnNyVaIc78vhIlLEidrEGudHY3cyjqUjwF2jv5oW0015yCO0u1NOmZFEU8PeD0g== X-Received: by 2002:ac8:65c2:: with SMTP id t2mr16990912qto.370.1597745878056; Tue, 18 Aug 2020 03:17:58 -0700 (PDT) Received: from localhost ([2620:10d:c091:480::1:179c]) by smtp.gmail.com with ESMTPSA id w1sm20614419qkj.90.2020.08.18.03.17.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 Aug 2020 03:17:57 -0700 (PDT) Date: Tue, 18 Aug 2020 11:17:56 +0100 From: Chris Down To: peterz@infradead.org Cc: Michal Hocko , Waiman Long , Andrew Morton , Johannes Weiner , Vladimir Davydov , Jonathan Corbet , Alexey Dobriyan , Ingo Molnar , Juri Lelli , Vincent Guittot , linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-fsdevel@vger.kernel.org, cgroups@vger.kernel.org, linux-mm@kvack.org Subject: Re: [RFC PATCH 0/8] memcg: Enable fine-grained per process memory control Message-ID: <20200818101756.GA155582@chrisdown.name> References: <20200817140831.30260-1-longman@redhat.com> <20200818091453.GL2674@hirez.programming.kicks-ass.net> <20200818092617.GN28270@dhcp22.suse.cz> <20200818095910.GM2674@hirez.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20200818095910.GM2674@hirez.programming.kicks-ass.net> User-Agent: Mutt/1.14.6 (2020-07-11) X-Rspamd-Queue-Id: 5F62918229837 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam02 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000003, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: peterz@infradead.org writes: >But then how can it run-away like Waiman suggested? Probably because he's not running with that commit at all. We and others use this to prevent runaway allocation on a huge range of production and desktop use cases and it works just fine. >/me goes look... and finds MEMCG_MAX_HIGH_DELAY_JIFFIES. > >That's a fail... :-( I'd ask that you understand a bit more about the tradeoffs and intentions of the patch before rushing in to declare its failure, considering it works just fine :-) Clamping the maximal time allows the application to take some action to remediate the situation, while still being slowed down significantly. 2 seconds per allocation batch is still absolutely plenty for any use case I've come across. If you have evidence it isn't, then present that instead of vague notions of "wrongness".