From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 37435C433DF for ; Tue, 18 Aug 2020 09:09:26 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 01BD2206B5 for ; Tue, 18 Aug 2020 09:09:25 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 01BD2206B5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.alibaba.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 9F7E76B0029; Tue, 18 Aug 2020 05:09:25 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9A9266B002A; Tue, 18 Aug 2020 05:09:25 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8BEAB6B002B; Tue, 18 Aug 2020 05:09:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0051.hostedemail.com [216.40.44.51]) by kanga.kvack.org (Postfix) with ESMTP id 73A096B0029 for ; Tue, 18 Aug 2020 05:09:25 -0400 (EDT) Received: from smtpin05.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 33093181AEF21 for ; Tue, 18 Aug 2020 09:09:25 +0000 (UTC) X-FDA: 77163115890.05.cable29_4301e2e2701e Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin05.hostedemail.com (Postfix) with ESMTP id 0241B18036FEF for ; Tue, 18 Aug 2020 09:09:24 +0000 (UTC) X-HE-Tag: cable29_4301e2e2701e X-Filterd-Recvd-Size: 2441 Received: from out30-43.freemail.mail.aliyun.com (out30-43.freemail.mail.aliyun.com [115.124.30.43]) by imf34.hostedemail.com (Postfix) with ESMTP for ; Tue, 18 Aug 2020 09:09:23 +0000 (UTC) X-Alimail-AntiSpam:AC=PASS;BC=-1|-1;BR=01201311R591e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e01422;MF=richard.weiyang@linux.alibaba.com;NM=1;PH=DS;RN=6;SR=0;TI=SMTPD_---0U67b.bN_1597741758; Received: from localhost(mailfrom:richard.weiyang@linux.alibaba.com fp:SMTPD_---0U67b.bN_1597741758) by smtp.aliyun-inc.com(127.0.0.1); Tue, 18 Aug 2020 17:09:18 +0800 Date: Tue, 18 Aug 2020 17:09:18 +0800 From: Wei Yang To: Wei Yang Cc: alexander.h.duyck@linux.intel.com, akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, david@redhat.com Subject: Re: [Patch v2] mm/page_reporting: drop stale list head check in page_reporting_cycle Message-ID: <20200818090917.GA34355@L-31X9LVDL-1304.local> Reply-To: Wei Yang References: <20200818084448.33969-1-richard.weiyang@linux.alibaba.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200818084448.33969-1-richard.weiyang@linux.alibaba.com> X-Rspamd-Queue-Id: 0241B18036FEF X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam02 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000760, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Aug 18, 2020 at 04:44:48PM +0800, Wei Yang wrote: >list_for_each_entry_safe() guarantees that we will never stumble over >the list head; "&page->lru != list" will always evaluate to true. Let's >simplify. [david@redhat.com: Changelog refine.] > >Signed-off-by: Wei Yang >Reviewed-by: David Hildenbrand >--- > mm/page_reporting.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/mm/page_reporting.c b/mm/page_reporting.c >index 3bbd471cfc81..aaaa3605123d 100644 >--- a/mm/page_reporting.c >+++ b/mm/page_reporting.c >@@ -178,7 +178,7 @@ page_reporting_cycle(struct page_reporting_dev_info *prdev, struct zone *zone, > * the new head of the free list before we release the > * zone lock. > */ >- if (&page->lru != list && !list_is_first(&page->lru, list)) >+ if (!list_is_first(&page->lru, list)) > list_rotate_to_front(&page->lru, list); > > /* release lock before waiting on report processing */ >-- >2.20.1 (Apple Git-117) -- Wei Yang Help you, Help me