* [Patch v2] mm/page_reporting: drop stale list head check in page_reporting_cycle
@ 2020-08-18 8:44 Wei Yang
2020-08-18 9:09 ` Wei Yang
2020-08-18 14:55 ` Alexander Duyck
0 siblings, 2 replies; 3+ messages in thread
From: Wei Yang @ 2020-08-18 8:44 UTC (permalink / raw)
To: alexander.h.duyck, akpm; +Cc: linux-mm, linux-kernel, david, Wei Yang
list_for_each_entry_safe() guarantees that we will never stumble over
the list head; "&page->lru != list" will always evaluate to true. Let's
simplify.
Signed-off-by: Wei Yang <richard.weiyang@linux.alibaba.com>
Reviewed-by: David Hildenbrand <david@redhat.com>
---
mm/page_reporting.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mm/page_reporting.c b/mm/page_reporting.c
index 3bbd471cfc81..aaaa3605123d 100644
--- a/mm/page_reporting.c
+++ b/mm/page_reporting.c
@@ -178,7 +178,7 @@ page_reporting_cycle(struct page_reporting_dev_info *prdev, struct zone *zone,
* the new head of the free list before we release the
* zone lock.
*/
- if (&page->lru != list && !list_is_first(&page->lru, list))
+ if (!list_is_first(&page->lru, list))
list_rotate_to_front(&page->lru, list);
/* release lock before waiting on report processing */
--
2.20.1 (Apple Git-117)
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Patch v2] mm/page_reporting: drop stale list head check in page_reporting_cycle
2020-08-18 8:44 [Patch v2] mm/page_reporting: drop stale list head check in page_reporting_cycle Wei Yang
@ 2020-08-18 9:09 ` Wei Yang
2020-08-18 14:55 ` Alexander Duyck
1 sibling, 0 replies; 3+ messages in thread
From: Wei Yang @ 2020-08-18 9:09 UTC (permalink / raw)
To: Wei Yang; +Cc: alexander.h.duyck, akpm, linux-mm, linux-kernel, david
On Tue, Aug 18, 2020 at 04:44:48PM +0800, Wei Yang wrote:
>list_for_each_entry_safe() guarantees that we will never stumble over
>the list head; "&page->lru != list" will always evaluate to true. Let's
>simplify.
[david@redhat.com: Changelog refine.]
>
>Signed-off-by: Wei Yang <richard.weiyang@linux.alibaba.com>
>Reviewed-by: David Hildenbrand <david@redhat.com>
>---
> mm/page_reporting.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/mm/page_reporting.c b/mm/page_reporting.c
>index 3bbd471cfc81..aaaa3605123d 100644
>--- a/mm/page_reporting.c
>+++ b/mm/page_reporting.c
>@@ -178,7 +178,7 @@ page_reporting_cycle(struct page_reporting_dev_info *prdev, struct zone *zone,
> * the new head of the free list before we release the
> * zone lock.
> */
>- if (&page->lru != list && !list_is_first(&page->lru, list))
>+ if (!list_is_first(&page->lru, list))
> list_rotate_to_front(&page->lru, list);
>
> /* release lock before waiting on report processing */
>--
>2.20.1 (Apple Git-117)
--
Wei Yang
Help you, Help me
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Patch v2] mm/page_reporting: drop stale list head check in page_reporting_cycle
2020-08-18 8:44 [Patch v2] mm/page_reporting: drop stale list head check in page_reporting_cycle Wei Yang
2020-08-18 9:09 ` Wei Yang
@ 2020-08-18 14:55 ` Alexander Duyck
1 sibling, 0 replies; 3+ messages in thread
From: Alexander Duyck @ 2020-08-18 14:55 UTC (permalink / raw)
To: Wei Yang
Cc: Alexander Duyck, Andrew Morton, linux-mm, LKML, David Hildenbrand
On Tue, Aug 18, 2020 at 1:45 AM Wei Yang
<richard.weiyang@linux.alibaba.com> wrote:
>
> list_for_each_entry_safe() guarantees that we will never stumble over
> the list head; "&page->lru != list" will always evaluate to true. Let's
> simplify.
>
> Signed-off-by: Wei Yang <richard.weiyang@linux.alibaba.com>
> Reviewed-by: David Hildenbrand <david@redhat.com>
> ---
> mm/page_reporting.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/page_reporting.c b/mm/page_reporting.c
> index 3bbd471cfc81..aaaa3605123d 100644
> --- a/mm/page_reporting.c
> +++ b/mm/page_reporting.c
> @@ -178,7 +178,7 @@ page_reporting_cycle(struct page_reporting_dev_info *prdev, struct zone *zone,
> * the new head of the free list before we release the
> * zone lock.
> */
> - if (&page->lru != list && !list_is_first(&page->lru, list))
> + if (!list_is_first(&page->lru, list))
> list_rotate_to_front(&page->lru, list);
>
> /* release lock before waiting on report processing */
Reviewed-by: Alexander Duyck <alexander.h.duyck@linux.intel.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-08-18 14:55 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-18 8:44 [Patch v2] mm/page_reporting: drop stale list head check in page_reporting_cycle Wei Yang
2020-08-18 9:09 ` Wei Yang
2020-08-18 14:55 ` Alexander Duyck
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox