From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CF386C433E3 for ; Tue, 18 Aug 2020 05:09:13 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 73C9A20738 for ; Tue, 18 Aug 2020 05:09:13 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 73C9A20738 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id A452C6B0002; Tue, 18 Aug 2020 01:09:12 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 87DA06B0005; Tue, 18 Aug 2020 01:09:12 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 742EA6B0006; Tue, 18 Aug 2020 01:09:12 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0058.hostedemail.com [216.40.44.58]) by kanga.kvack.org (Postfix) with ESMTP id 5B4526B0002 for ; Tue, 18 Aug 2020 01:09:12 -0400 (EDT) Received: from smtpin30.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 0C6923631 for ; Tue, 18 Aug 2020 05:09:12 +0000 (UTC) X-FDA: 77162510544.30.field16_3d056162701c Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin30.hostedemail.com (Postfix) with ESMTP id D4C7B180B3AA7 for ; Tue, 18 Aug 2020 05:09:11 +0000 (UTC) X-HE-Tag: field16_3d056162701c X-Filterd-Recvd-Size: 3834 Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by imf42.hostedemail.com (Postfix) with ESMTP for ; Tue, 18 Aug 2020 05:09:11 +0000 (UTC) IronPort-SDR: zQyVziLUsjJfF3Avu6mWHWH2NCwcxuJ6BaJMK2b+ARfSVc3/cGOCD/Rfbhan6BTMbVS7RheBiI paKLjDVPa7XQ== X-IronPort-AV: E=McAfee;i="6000,8403,9716"; a="154100796" X-IronPort-AV: E=Sophos;i="5.76,326,1592895600"; d="scan'208";a="154100796" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Aug 2020 22:09:09 -0700 IronPort-SDR: ziaGWUr8V2D2f+nbYi83m8NhaLhf+LOFOtV1ZlsiIHVxSSqIOiBLxguavrTz/eGQ3Oc8FxO1Hh yBXL5N74MYFg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.76,326,1592895600"; d="scan'208";a="292652501" Received: from lcrossx-mobl1.ger.corp.intel.com (HELO localhost) ([10.249.46.217]) by orsmga003.jf.intel.com with ESMTP; 17 Aug 2020 22:09:05 -0700 From: Jarkko Sakkinen To: linux-kernel@vger.kernel.org Cc: Jarkko Sakkinen , linux-mm@kvack.org, Andi Kleen , Ard Biesheuvel , Jessica Yu , Mark Rutland , Masami Hiramatsu , Mike Rapoport , Peter Zijlstra , Russell King , Will Deacon , Steven Rostedt , Ingo Molnar Subject: [PATCH] kprobes: Use module_name() macro Date: Tue, 18 Aug 2020 08:08:57 +0300 Message-Id: <20200818050857.117998-1-jarkko.sakkinen@linux.intel.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-Rspamd-Queue-Id: D4C7B180B3AA7 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam05 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: It is advised to use module_name() macro instead of dereferencing mod->na= me directly. This makes sense for consistencys sake and also it prevents a hard dependency to CONFIG_MODULES. Cc: linux-mm@kvack.org Cc: Andi Kleen Cc: Ard Biesheuvel Cc: Jessica Yu Cc: Mark Rutland , Cc: Masami Hiramatsu Cc: Mike Rapoport Cc: Peter Zijlstra Cc: Russell King Cc: Will Deacon Signed-off-by: Jarkko Sakkinen --- I thought that to get things moving it would make sense to fix this low hanging fruit issue first. Similarly as Masami's fix kernel/kprobes.c this will make my patch set less rambling, and thus easier to follow. kernel/trace/trace_kprobe.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/kernel/trace/trace_kprobe.c b/kernel/trace/trace_kprobe.c index aefb6065b508..19c00ee90945 100644 --- a/kernel/trace/trace_kprobe.c +++ b/kernel/trace/trace_kprobe.c @@ -106,9 +106,10 @@ static nokprobe_inline bool trace_kprobe_has_gone(st= ruct trace_kprobe *tk) static nokprobe_inline bool trace_kprobe_within_module(struct trace_kpro= be *tk, struct module *mod) { - int len =3D strlen(mod->name); + int len =3D strlen(module_name(mod)); const char *name =3D trace_kprobe_symbol(tk); - return strncmp(mod->name, name, len) =3D=3D 0 && name[len] =3D=3D ':'; + + return strncmp(module_name(mod), name, len) =3D=3D 0 && name[len] =3D=3D= ':'; } =20 static nokprobe_inline bool trace_kprobe_module_exist(struct trace_kprob= e *tk) @@ -688,7 +689,7 @@ static int trace_kprobe_module_callback(struct notifi= er_block *nb, if (ret) pr_warn("Failed to re-register probe %s on %s: %d\n", trace_probe_name(&tk->tp), - mod->name, ret); + module_name(mod), ret); } } mutex_unlock(&event_mutex); --=20 2.25.1