From: Matthew Wilcox <willy@infradead.org>
To: Bean Huo <huobean@gmail.com>
Cc: akpm@linux-foundation.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, Bean Huo <beanhuo@micron.com>
Subject: Re: [PATCH] mm: change prev_offset type to unsigned long
Date: Mon, 17 Aug 2020 16:18:51 +0100 [thread overview]
Message-ID: <20200817151851.GK17456@casper.infradead.org> (raw)
In-Reply-To: <20200817150637.4244-1-huobean@gmail.com>
On Mon, Aug 17, 2020 at 05:06:37PM +0200, Bean Huo wrote:
> From: Bean Huo <beanhuo@micron.com>
There's no description. Please explain why this patch is needed.
> Signed-off-by: Bean Huo <beanhuo@micron.com>
> ---
> mm/filemap.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/filemap.c b/mm/filemap.c
> index cf4bdf7803b6..d736c7a4b826 100644
> --- a/mm/filemap.c
> +++ b/mm/filemap.c
> @@ -2025,7 +2025,7 @@ ssize_t generic_file_buffered_read(struct kiocb *iocb,
> pgoff_t last_index;
> pgoff_t prev_index;
> unsigned long offset; /* offset into pagecache page */
> - unsigned int prev_offset;
> + unsigned long prev_offset;
> int error = 0;
>
> if (unlikely(*ppos >= inode->i_sb->s_maxbytes))
> --
> 2.17.1
>
>
prev parent reply other threads:[~2020-08-17 15:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-17 15:06 Bean Huo
2020-08-17 15:18 ` Matthew Wilcox [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200817151851.GK17456@casper.infradead.org \
--to=willy@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=beanhuo@micron.com \
--cc=huobean@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox