From: kernel test robot <lkp@intel.com>
To: Peter Collingbourne <pcc@google.com>,
John Hubbard <jhubbard@nvidia.com>,
Matthew Wilcox <willy@infradead.org>,
"Kirill A . Shutemov" <kirill@shutemov.name>,
Andrew Morton <akpm@linux-foundation.org>,
Catalin Marinas <catalin.marinas@arm.com>,
Evgenii Stepanov <eugenis@google.com>
Cc: kbuild-all@lists.01.org, clang-built-linux@googlegroups.com,
Linux Memory Management List <linux-mm@kvack.org>,
Peter Collingbourne <pcc@google.com>,
Linux ARM <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v2] mm: introduce reference pages
Date: Fri, 14 Aug 2020 09:01:13 +0800 [thread overview]
Message-ID: <202008140841.cjsHFFxt%lkp@intel.com> (raw)
In-Reply-To: <20200813220937.40973-1-pcc@google.com>
[-- Attachment #1: Type: text/plain, Size: 4867 bytes --]
Hi Peter,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on linus/master]
[cannot apply to mmotm/master hnaz-linux-mm/master arm64/for-next/core tip/x86/asm v5.8 next-20200813]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Peter-Collingbourne/mm-introduce-reference-pages/20200814-061235
base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git dddcbc139e96bd18d8c65ef7b7e440f0d32457c2
config: x86_64-randconfig-a015-20200813 (attached as .config)
compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project 62ef1cb2079123b86878e4bfed3c14db448f1373)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install x86_64 cross compiling tool for clang build
# apt-get install binutils-x86-64-linux-gnu
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
In file included from arch/x86/kernel/asm-offsets.c:9:
In file included from include/linux/crypto.h:20:
In file included from include/linux/slab.h:136:
In file included from include/linux/kasan.h:14:
>> include/linux/pgtable.h:1063:17: error: implicit declaration of function 'page_to_section' [-Werror,-Wimplicit-function-declaration]
return pfn == page_to_pfn((struct page *)vma->vm_private_data);
^
include/asm-generic/memory_model.h:81:21: note: expanded from macro 'page_to_pfn'
#define page_to_pfn __page_to_pfn
^
include/asm-generic/memory_model.h:64:14: note: expanded from macro '__page_to_pfn'
int __sec = page_to_section(__pg); \
^
include/linux/pgtable.h:1063:17: note: did you mean '__nr_to_section'?
include/asm-generic/memory_model.h:81:21: note: expanded from macro 'page_to_pfn'
#define page_to_pfn __page_to_pfn
^
include/asm-generic/memory_model.h:64:14: note: expanded from macro '__page_to_pfn'
int __sec = page_to_section(__pg); \
^
include/linux/mmzone.h:1220:35: note: '__nr_to_section' declared here
static inline struct mem_section *__nr_to_section(unsigned long nr)
^
In file included from arch/x86/kernel/asm-offsets.c:13:
In file included from include/linux/suspend.h:5:
In file included from include/linux/swap.h:9:
In file included from include/linux/memcontrol.h:13:
In file included from include/linux/cgroup.h:28:
In file included from include/linux/cgroup-defs.h:22:
In file included from include/linux/bpf-cgroup.h:5:
In file included from include/linux/bpf.h:21:
In file included from include/linux/kallsyms.h:12:
>> include/linux/mm.h:1444:29: error: static declaration of 'page_to_section' follows non-static declaration
static inline unsigned long page_to_section(const struct page *page)
^
include/linux/pgtable.h:1063:17: note: previous implicit declaration is here
return pfn == page_to_pfn((struct page *)vma->vm_private_data);
^
include/asm-generic/memory_model.h:81:21: note: expanded from macro 'page_to_pfn'
#define page_to_pfn __page_to_pfn
^
include/asm-generic/memory_model.h:64:14: note: expanded from macro '__page_to_pfn'
int __sec = page_to_section(__pg); \
^
2 errors generated.
make[2]: *** [scripts/Makefile.build:117: arch/x86/kernel/asm-offsets.s] Error 1
make[2]: Target '__build' not remade because of errors.
make[1]: *** [Makefile:1203: prepare0] Error 2
make[1]: Target 'prepare' not remade because of errors.
make: *** [Makefile:185: __sub-make] Error 2
make: Target 'prepare' not remade because of errors.
vim +/page_to_section +1063 include/linux/pgtable.h
1056
1057 static inline int is_zero_or_refpage_pfn(struct vm_area_struct *vma,
1058 unsigned long pfn)
1059 {
1060 if (is_zero_pfn(pfn))
1061 return true;
1062 if (unlikely(!vma->vm_ops && vma->vm_private_data))
> 1063 return pfn == page_to_pfn((struct page *)vma->vm_private_data);
1064 return false;
1065 }
1066
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 34704 bytes --]
next prev parent reply other threads:[~2020-08-14 1:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-13 22:09 Peter Collingbourne
2020-08-13 22:20 ` Peter Collingbourne
2020-08-13 22:31 ` Matthew Wilcox
2020-08-13 23:46 ` Peter Collingbourne
2020-08-14 1:00 ` kernel test robot
2020-08-14 1:01 ` kernel test robot [this message]
2020-08-14 1:11 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202008140841.cjsHFFxt%lkp@intel.com \
--to=lkp@intel.com \
--cc=akpm@linux-foundation.org \
--cc=catalin.marinas@arm.com \
--cc=clang-built-linux@googlegroups.com \
--cc=eugenis@google.com \
--cc=jhubbard@nvidia.com \
--cc=kbuild-all@lists.01.org \
--cc=kirill@shutemov.name \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mm@kvack.org \
--cc=pcc@google.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox