From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 07663C433E0 for ; Wed, 12 Aug 2020 13:40:15 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id A8DBD207DA for ; Wed, 12 Aug 2020 13:40:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="hjsn9Qvx" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A8DBD207DA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 39EC18D001B; Wed, 12 Aug 2020 09:40:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 34EE98D0001; Wed, 12 Aug 2020 09:40:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 265E78D001B; Wed, 12 Aug 2020 09:40:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0176.hostedemail.com [216.40.44.176]) by kanga.kvack.org (Postfix) with ESMTP id 106678D0001 for ; Wed, 12 Aug 2020 09:40:14 -0400 (EDT) Received: from smtpin23.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id B3E173AB6 for ; Wed, 12 Aug 2020 13:40:13 +0000 (UTC) X-FDA: 77142025506.23.side53_6301fd826feb Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin23.hostedemail.com (Postfix) with ESMTP id 84F8F37606 for ; Wed, 12 Aug 2020 13:40:13 +0000 (UTC) X-HE-Tag: side53_6301fd826feb X-Filterd-Recvd-Size: 9408 Received: from mail-qk1-f196.google.com (mail-qk1-f196.google.com [209.85.222.196]) by imf47.hostedemail.com (Postfix) with ESMTP for ; Wed, 12 Aug 2020 13:40:12 +0000 (UTC) Received: by mail-qk1-f196.google.com with SMTP id 62so2014203qkj.7 for ; Wed, 12 Aug 2020 06:40:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=5sKEzQ3YqzLqSIu/D/i35blosR6a6kQLx1hfQqaz5GA=; b=hjsn9QvxVRJPT56Hnq5eZ2yb0blS8HQA3dcP6shQxTAE5Zr1hLy1XeJhNWnTfZ8xUW VbsXMyobe0i6EmunAnbzEAE6YL1OUfKpd1YzbQz/cBH8f/HMXZGJk9yTUN00Pv8H7lwS WkFaZQXQt2ZGMqKEKUwG62bwdszywhPabIhpw20TFXx0pvW8+HHmYtUvKzqLBFOlIsbD vL32i6AdLs75+F+V/69s89SbEQphuO2lsHozgAETjg3uRg/27mqMr5Qa3/969/2ttAf0 F2mByt5oH5y8HmrOWnvYC5u5aJp8dOcQqjnBcSSNwjacVAGFHlCYYWQEJMNRcek+a/KQ xy8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=5sKEzQ3YqzLqSIu/D/i35blosR6a6kQLx1hfQqaz5GA=; b=jPri/FSDR/kVrwXKoz4ygLnP+srPfdqPSdaZrR56F7rj59u6WdnyZK2wFEfSflZL1S Xq/isyU6htwBMSgeopc8cydPwF+R+Rm+v54YJImtuwvOSfyJ3EF9GfnhnhRlxb8Lwg5W myV3nC/Fw6X3AGpId/3bJtxoDsXq+DJ0fUlB5rqPGglY2WeZgz/4VpPfUEFysXAIX6Ta IhORRiFcLDdUKiwWa9dSwtZI2PcpPrgxn90jEtjoY/4Wr46e+iwMnbI7W9pB4VnT0n8t v3qRgfQSFwC6vjX4HwxFT+kzGwKcSBvMGV3WGVIF01FgUMceLNjMWmOFSbILUMQA/o0v mXcQ== X-Gm-Message-State: AOAM533wXDRrJi5oE/YsGe01rPFw5SXoT4U6clJZwtohynML/iMtZkEQ yRwUGhJKmWR/qknuONSLa8U= X-Google-Smtp-Source: ABdhPJyTuf9aJrlD1NhlcrN0g8Hk83PKCht7c/BE+z7FGLKxTjL/yTFvXnfUA/G1DP4cDBhHryMx4g== X-Received: by 2002:a37:556:: with SMTP id 83mr6147394qkf.208.1597239612262; Wed, 12 Aug 2020 06:40:12 -0700 (PDT) Received: from shinobu (072-189-064-225.res.spectrum.com. [72.189.64.225]) by smtp.gmail.com with ESMTPSA id z197sm2217654qkb.66.2020.08.12.06.40.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Aug 2020 06:40:11 -0700 (PDT) Date: Wed, 12 Aug 2020 09:39:55 -0400 From: William Breathitt Gray To: Andrew Morton Cc: andy.shevchenko@gmail.com, arnd@arndb.de, emil.l.velikov@gmail.com, geert@linux-m68k.org, keescook@chromium.org, linus.walleij@linaro.org, linux-mm@kvack.org, mm-commits@vger.kernel.org, rd.dunlap@gmail.com, rikard.falkeborn@gmail.com, syednwaris@gmail.com, torvalds@linux-foundation.org, weiyongjun1@huawei.com, yamada.masahiro@socionext.com Subject: Re: [patch 091/165] lib/test_bits.c: add tests of GENMASK Message-ID: <20200812133936.GA24794@shinobu> References: <20200811182949.e12ae9a472e3b5e27e16ad6c@linux-foundation.org> <20200812013503.D4sgoLZOW%akpm@linux-foundation.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="/NkBOFFp2J2Af1nK" Content-Disposition: inline In-Reply-To: <20200812013503.D4sgoLZOW%akpm@linux-foundation.org> X-Rspamd-Queue-Id: 84F8F37606 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam01 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: --/NkBOFFp2J2Af1nK Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Aug 11, 2020 at 06:35:03PM -0700, Andrew Morton wrote: > From: Rikard Falkeborn > Subject: lib/test_bits.c: add tests of GENMASK >=20 > Add tests of GENMASK and GENMASK_ULL. >=20 > A few test cases that should fail compilation are provided under #ifdef > TEST_GENMASK_FAILURES >=20 > [rd.dunlap@gmail.com: add MODULE_LICENSE()] > Link: http://lkml.kernel.org/r/dfc74524-0789-2827-4eff-476ddab65699@gma= il.com > [weiyongjun1@huawei.com: make some functions static] > Link: http://lkml.kernel.org/r/20200702150336.4756-1-weiyongjun1@huawei= =2Ecom > Link: http://lkml.kernel.org/r/20200621054210.14804-2-rikard.falkeborn@gm= ail.com > Link: http://lkml.kernel.org/r/20200608221823.35799-2-rikard.falkeborn@gm= ail.com > Signed-off-by: Rikard Falkeborn > Signed-off-by: Randy Dunlap > Signed-off-by: Wei Yongjun > Suggested-by: Andy Shevchenko > Reviewed-by: Andy Shevchenko > Cc: Emil Velikov > Cc: Syed Nayyar Waris > Cc: Andy Shevchenko > Cc: Arnd Bergmann > Cc: Emil Velikov > Cc: Geert Uytterhoeven > Cc: Kees Cook > Cc: Linus Walleij > Cc: William Breathitt Gray > Cc: Masahiro Yamada > Signed-off-by: Andrew Morton Acked-by: William Breathitt Gray > --- >=20 > lib/Kconfig.debug | 11 ++++++ > lib/Makefile | 1=20 > lib/test_bits.c | 75 ++++++++++++++++++++++++++++++++++++++++++++ > 3 files changed, 87 insertions(+) >=20 > --- a/lib/Kconfig.debug~bits-add-tests-of-genmask > +++ a/lib/Kconfig.debug > @@ -2236,6 +2236,17 @@ config LINEAR_RANGES_TEST > =20 > If unsure, say N. > =20 > +config BITS_TEST > + tristate "KUnit test for bits.h" > + depends on KUNIT > + help > + This builds the bits unit test. > + Tests the logic of macros defined in bits.h. > + For more information on KUnit and unit tests in general please refer > + to the KUnit documentation in Documentation/dev-tools/kunit/. > + > + If unsure, say N. > + > config TEST_UDELAY > tristate "udelay test driver" > help > --- a/lib/Makefile~bits-add-tests-of-genmask > +++ a/lib/Makefile > @@ -342,3 +342,4 @@ obj-$(CONFIG_PLDMFW) +=3D pldmfw/ > # KUnit tests > obj-$(CONFIG_LIST_KUNIT_TEST) +=3D list-test.o > obj-$(CONFIG_LINEAR_RANGES_TEST) +=3D test_linear_ranges.o > +obj-$(CONFIG_BITS_TEST) +=3D test_bits.o > --- /dev/null > +++ a/lib/test_bits.c > @@ -0,0 +1,75 @@ > +// SPDX-License-Identifier: GPL-2.0+ > +/* > + * Test cases for functions and macros in bits.h > + */ > + > +#include > +#include > + > + > +static void genmask_test(struct kunit *test) > +{ > + KUNIT_EXPECT_EQ(test, 1ul, GENMASK(0, 0)); > + KUNIT_EXPECT_EQ(test, 3ul, GENMASK(1, 0)); > + KUNIT_EXPECT_EQ(test, 6ul, GENMASK(2, 1)); > + KUNIT_EXPECT_EQ(test, 0xFFFFFFFFul, GENMASK(31, 0)); > + > +#ifdef TEST_GENMASK_FAILURES > + /* these should fail compilation */ > + GENMASK(0, 1); > + GENMASK(0, 10); > + GENMASK(9, 10); > +#endif > + > + > +} > + > +static void genmask_ull_test(struct kunit *test) > +{ > + KUNIT_EXPECT_EQ(test, 1ull, GENMASK_ULL(0, 0)); > + KUNIT_EXPECT_EQ(test, 3ull, GENMASK_ULL(1, 0)); > + KUNIT_EXPECT_EQ(test, 0x000000ffffe00000ull, GENMASK_ULL(39, 21)); > + KUNIT_EXPECT_EQ(test, 0xffffffffffffffffull, GENMASK_ULL(63, 0)); > + > +#ifdef TEST_GENMASK_FAILURES > + /* these should fail compilation */ > + GENMASK_ULL(0, 1); > + GENMASK_ULL(0, 10); > + GENMASK_ULL(9, 10); > +#endif > +} > + > +static void genmask_input_check_test(struct kunit *test) > +{ > + unsigned int x, y; > + int z, w; > + > + /* Unknown input */ > + KUNIT_EXPECT_EQ(test, 0, GENMASK_INPUT_CHECK(x, 0)); > + KUNIT_EXPECT_EQ(test, 0, GENMASK_INPUT_CHECK(0, x)); > + KUNIT_EXPECT_EQ(test, 0, GENMASK_INPUT_CHECK(x, y)); > + > + KUNIT_EXPECT_EQ(test, 0, GENMASK_INPUT_CHECK(z, 0)); > + KUNIT_EXPECT_EQ(test, 0, GENMASK_INPUT_CHECK(0, z)); > + KUNIT_EXPECT_EQ(test, 0, GENMASK_INPUT_CHECK(z, w)); > + > + /* Valid input */ > + KUNIT_EXPECT_EQ(test, 0, GENMASK_INPUT_CHECK(1, 1)); > + KUNIT_EXPECT_EQ(test, 0, GENMASK_INPUT_CHECK(39, 21)); > +} > + > + > +static struct kunit_case bits_test_cases[] =3D { > + KUNIT_CASE(genmask_test), > + KUNIT_CASE(genmask_ull_test), > + KUNIT_CASE(genmask_input_check_test), > + {} > +}; > + > +static struct kunit_suite bits_test_suite =3D { > + .name =3D "bits-test", > + .test_cases =3D bits_test_cases, > +}; > +kunit_test_suite(bits_test_suite); > + > +MODULE_LICENSE("GPL"); > _ --/NkBOFFp2J2Af1nK Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEk5I4PDJ2w1cDf/bghvpINdm7VJIFAl8z8SoACgkQhvpINdm7 VJIl6w/9HeX98npb/55g9tCUnX6HP2W7o6RpQNgg1yG4akHKmjSA3Z7TvgW06G7R byS8GRoSpiVZWcH9D+xXZA+atduENlp/4F6Lqd/BUVreBl+dp2VJr7sEGlRNCGUz r7zz/tAaVaiJ17xeOXaBN8MRq30hRdITCfZub1qf2Wo1/fIZx9VNwT9WBBoEWQ7u UhC7OGHTi5UeKrVI5d1QvEaAt5FJ8tOlfQepIq8NxTn5pFqRwKPhmcRvYZPiiLK3 MhS0kugpjsiE//xkVMkUOfYJe1+UNutBGicKakQK0T5eBENNlfirkXczXgRwUGVp a8g2EEq9McDOidyAM3pfnrzUvCBQGFwk0SEALfLGQfrRhi+Vu6XrbkJJ7+ccsqnY 7rLNdzA3gpeJvrwS7LEciXQw9amiZ7r9+ejzeBWN1m8iOw8lMxlDHEpN5laKVegk f0fM3psPau8lEFv6bH4VdWctslfrMUYqgws+cQPp5j9UrCgVZtX5iO+Fg+39dmhA 14nDJVrLp8bZ4VMBj6b9jerHAOC8oVXM5sB0Nr12ZRrgAtl1mv8cJK7jSoczPw8W I0/oP/dkcBGDBcb+n6jNp5OnknjBrJjKsoFWdkM/tVTxBuK7QVckoFHA9sAAuSNg QdBgXqn01x4dGvqY+JMe7glKqv9yHMyFDnTV5tf7NP1KP9I2TF4= =zA9V -----END PGP SIGNATURE----- --/NkBOFFp2J2Af1nK--