From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 56B03C433DF for ; Wed, 12 Aug 2020 01:33:57 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 118CD2080C for ; Wed, 12 Aug 2020 01:33:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="J0roobCi" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 118CD2080C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id AEF118D0030; Tue, 11 Aug 2020 21:33:56 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A9EB28D0001; Tue, 11 Aug 2020 21:33:56 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9B6918D0030; Tue, 11 Aug 2020 21:33:56 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0056.hostedemail.com [216.40.44.56]) by kanga.kvack.org (Postfix) with ESMTP id 81BA88D0001 for ; Tue, 11 Aug 2020 21:33:56 -0400 (EDT) Received: from smtpin08.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 4F81B2C81 for ; Wed, 12 Aug 2020 01:33:56 +0000 (UTC) X-FDA: 77140195272.08.war21_3d04aad26fe7 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin08.hostedemail.com (Postfix) with ESMTP id 2889A1819E764 for ; Wed, 12 Aug 2020 01:33:56 +0000 (UTC) X-HE-Tag: war21_3d04aad26fe7 X-Filterd-Recvd-Size: 3223 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf43.hostedemail.com (Postfix) with ESMTP for ; Wed, 12 Aug 2020 01:33:55 +0000 (UTC) Received: from localhost.localdomain (c-73-231-172-41.hsd1.ca.comcast.net [73.231.172.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 9919B2076C; Wed, 12 Aug 2020 01:33:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1597196035; bh=EKEA4pwdWZ5hpTSKkqIaHBuLjcJF511h/S+3ne8ycBY=; h=Date:From:To:Subject:In-Reply-To:From; b=J0roobCiWgKfasg4BV995+IgJgKvSyvK4HXpRvvZGCRktUHGCI8uSWKIYYdQE/nhN sfGbq8H9w0iKrg77IthZmLHRobQo4k7rPoxdT+OJireAd/QW3fuEdBnB2qppXnNpKo pzAp2+OYsDXJ694Ymqw1qX+QxdzFbnbKCdU3UIe8= Date: Tue, 11 Aug 2020 18:33:54 -0700 From: Andrew Morton To: akpm@linux-foundation.org, arnd@arndb.de, ink@jurassic.park.msu.ru, linux-mm@kvack.org, lkp@intel.com, luc.vanoostenryck@gmail.com, mattst88@gmail.com, mm-commits@vger.kernel.org, rth@twiddle.net, sboyd@kernel.org, torvalds@linux-foundation.org Subject: [patch 069/165] alpha: fix annotation of io{read,write}{16,32}be() Message-ID: <20200812013354.U9pSdlJwk%akpm@linux-foundation.org> In-Reply-To: <20200811182949.e12ae9a472e3b5e27e16ad6c@linux-foundation.org> User-Agent: s-nail v14.8.16 X-Rspamd-Queue-Id: 2889A1819E764 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam04 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: Luc Van Oostenryck Subject: alpha: fix annotation of io{read,write}{16,32}be() These accessors must be used to read/write a big-endian bus. The value returned or written is native-endian. However, these accessors are defined using be{16,32}_to_cpu() or cpu_to_be{16,32}() to make the endian conversion but these expect a __be{16,32} when none is present. Keeping them would need a force cast that would solve nothing at all. So, do the conversion using swab{16,32}, like done in asm-generic for similar situations. Link: http://lkml.kernel.org/r/20200622114232.80039-1-luc.vanoostenryck@gmail.com Signed-off-by: Luc Van Oostenryck Reported-by: kernel test robot Cc: Richard Henderson Cc: Ivan Kokshaysky Cc: Matt Turner Cc: Stephen Boyd Cc: Arnd Bergmann Signed-off-by: Andrew Morton --- arch/alpha/include/asm/io.h | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) --- a/arch/alpha/include/asm/io.h~fix-annotation-of-ioreadwrite1632be +++ a/arch/alpha/include/asm/io.h @@ -489,10 +489,10 @@ extern inline void writeq(u64 b, volatil } #endif -#define ioread16be(p) be16_to_cpu(ioread16(p)) -#define ioread32be(p) be32_to_cpu(ioread32(p)) -#define iowrite16be(v,p) iowrite16(cpu_to_be16(v), (p)) -#define iowrite32be(v,p) iowrite32(cpu_to_be32(v), (p)) +#define ioread16be(p) swab16(ioread16(p)) +#define ioread32be(p) swab32(ioread32(p)) +#define iowrite16be(v,p) iowrite16(swab16(v), (p)) +#define iowrite32be(v,p) iowrite32(swab32(v), (p)) #define inb_p inb #define inw_p inw _