From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6CECFC433E1 for ; Tue, 11 Aug 2020 19:32:11 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 1DA8F20771 for ; Tue, 11 Aug 2020 19:32:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Zup5i22j" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1DA8F20771 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 9C7EB6B0002; Tue, 11 Aug 2020 15:32:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9793A6B0005; Tue, 11 Aug 2020 15:32:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 867B16B0006; Tue, 11 Aug 2020 15:32:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0204.hostedemail.com [216.40.44.204]) by kanga.kvack.org (Postfix) with ESMTP id 718D86B0002 for ; Tue, 11 Aug 2020 15:32:10 -0400 (EDT) Received: from smtpin13.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id B5334824805A for ; Tue, 11 Aug 2020 19:32:09 +0000 (UTC) X-FDA: 77139283578.13.shelf62_6011e0926fe5 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin13.hostedemail.com (Postfix) with ESMTP id 73C6018140B69 for ; Tue, 11 Aug 2020 19:32:09 +0000 (UTC) X-HE-Tag: shelf62_6011e0926fe5 X-Filterd-Recvd-Size: 5832 Received: from mail-pg1-f193.google.com (mail-pg1-f193.google.com [209.85.215.193]) by imf11.hostedemail.com (Postfix) with ESMTP for ; Tue, 11 Aug 2020 19:32:08 +0000 (UTC) Received: by mail-pg1-f193.google.com with SMTP id v15so7115791pgh.6 for ; Tue, 11 Aug 2020 12:32:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=L1QCDqC1jeWEZjJgqKuh/PvlUoKdtPIRoCRlMgnSgkk=; b=Zup5i22jfTfst2Dd9AzeWzIIw+U7EsZCFQh3l8LsO9CjkJjfS3FJn20mcGyoGWKCbm VeUqLCo8GyxQ7xY9GfK9FlzIiVo6GY4rbzNgAo8c4F5/dx5BPM1UKzgHq97/RjraWvmc hjDQUGAeqD5EU9sCtHQY3+TjMETJtA5naF4CGkAk6uDWqtBucnajeCiASzxw2WHMF1Ov EVq4+EDngGWQZQ4Oq7Efz6tATDHiGyHPCPBQ7cqbIA3wdlcLH7+caOJTWIRX8RE+FIDr vg/JVUd+qXJv78k4MUs4IemYQpP/qqwK7sVKV8wqNWf2oSUsvMu65CuMgvNh0ou8Q0BB xCsg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=L1QCDqC1jeWEZjJgqKuh/PvlUoKdtPIRoCRlMgnSgkk=; b=XhohKwIJPLXUqKam1V38+v7bHqPyoFZhcI8AT0grcFzCjkpeM3ckhSfD2YOAnx6uZj Mv99xPdzAPzdnSvhjXhiFU0pDw962oFbYDwpR9ftLCJN/zooSZXQpjImS8LoRcfSBFZk NVpA0R9wReJXYRRtu04SMm/wU3ushPNd2tHBpOPORkNG3JHLQvdQ0Dt9Hms6DsbF2/5f CeViR9IfvSwyx8Y545mU/weWJdxCHuMb+Grwzj7SjVOATrZdXojiJJFKS0TEVud87sQf +y6DS/zo0lhMWxeZml0MBgl/iaBsGszwA0heNHwNR6v/tui7uJnvaWQVvV5dUX1t2crm qEsA== X-Gm-Message-State: AOAM533+ZAv9Z8MjaSXRrAVVxG5lCrB6qAdsB8MZB3XQ4G2yYrFbarz8 Xbg9qHu2xkqcdfm8EeuyiA== X-Google-Smtp-Source: ABdhPJyaa+AyUu5yMrX2PZZf5f/8RCTfXLIoKqj+U5eWAsuHEVf1Sm0q44cbwOoWVGmUMdkdq6HnTg== X-Received: by 2002:aa7:8608:: with SMTP id p8mr7464007pfn.62.1597174327916; Tue, 11 Aug 2020 12:32:07 -0700 (PDT) Received: from u2004 (h175-177-040-128.catv02.itscom.jp. [175.177.40.128]) by smtp.gmail.com with ESMTPSA id d80sm27121218pfd.22.2020.08.11.12.32.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Aug 2020 12:32:07 -0700 (PDT) Date: Wed, 12 Aug 2020 04:32:01 +0900 From: Naoya Horiguchi To: Qian Cai Cc: HORIGUCHI =?iso-2022-jp?B?TkFPWUEoGyRCS1k4fSEhRD5MaRsoQik=?= , "linux-mm@kvack.org" , "mhocko@kernel.org" , "akpm@linux-foundation.org" , "mike.kravetz@oracle.com" , "osalvador@suse.de" , "tony.luck@intel.com" , "david@redhat.com" , "aneesh.kumar@linux.vnet.ibm.com" , "zeil@yandex-team.ru" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "catalin.marinas@arm.com" , "will@kernel.org" Subject: Re: [PATCH v6 00/12] HWPOISON: soft offline rework Message-ID: <20200811193201.GA1410457@u2004> References: <20200806184923.7007-1-nao.horiguchi@gmail.com> <20200810152254.GC5307@lca.pw> <20200811031139.GA7145@hori.linux.bs1.fc.nec.co.jp> <20200811173923.GA39857@lca.pw> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-2022-jp Content-Disposition: inline In-Reply-To: <20200811173923.GA39857@lca.pw> X-Rspamd-Queue-Id: 73C6018140B69 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam01 X-Bogosity: Ham, tests=bogofilter, spamicity=0.001716, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Aug 11, 2020 at 01:39:24PM -0400, Qian Cai wrote: > On Tue, Aug 11, 2020 at 03:11:40AM +0000, HORIGUCHI NAOYA(堀口 直也) wrote: > > I'm still not sure why the test succeeded by reverting these because > > current mainline kernel provides similar mechanism to prevent reuse of > > soft offlined page. So this success seems to me something suspicious. > > > > To investigate more, I want to have additional info about the page states > > of the relevant pages after soft offlining. Could you collect it by the > > following steps? > > > > - modify random.c not to run hotplug_memory() in migrate_huge_hotplug_memory(), > > - compile it and run "./random 1" once, > > - to collect page state with hwpoisoned pages, run "./page-types -Nlr -b hwpoison", > > where page-types is available under tools/vm in kernel source tree. > > - choose a few pfns of soft offlined pages from kernel message > > "Soft offlining pfn ...", and run "./page-types -Nlr -a ". > > # ./page-types -Nlr -b hwpoison > offset len flags > 99a000 1 __________B________X_______________________ > 99c000 1 __________B________X_______________________ > 99e000 1 __________B________X_______________________ > 9a0000 1 __________B________X_______________________ > ba6000 1 __________B________X_______________________ > baa000 1 __________B________X_______________________ Thank you. It only shows 6 lines of records, which is unexpected to me because random.c iterates soft offline 2 hugepages with madvise() 1000 times. Somehow (maybe in arch specific way?) other hwpoisoned pages might be cleared? If they really are, the success of this test is a fake, and this patchset can be considered as a fix. > > Every single one of pfns was like this, > > # ./page-types -Nlr -a 0x99a000 > offset len flags > 99a000 1 __________B________X_______________________ > > # ./page-types -Nlr -a 0x99e000 > offset len flags > 99e000 1 __________B________X_______________________ > > # ./page-types -Nlr -a 0x99c000 > offset len flags > 99c000 1 __________B________X_______________________