From: Jason Gunthorpe <jgg@mellanox.com>
To: Randy Dunlap <rdunlap@infradead.org>,
Andrew Morton <akpm@linux-foundation.org>
Cc: Ralph Campbell <rcampbell@nvidia.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Jerome Glisse <jglisse@redhat.com>,
John Hubbard <jhubbard@nvidia.com>,
Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH] mm/migrate: fix migrate_pgmap_owner w/o CONFIG_MMU_NOTIFIER
Date: Thu, 6 Aug 2020 20:44:27 -0300 [thread overview]
Message-ID: <20200806234427.GR19097@mellanox.com> (raw)
In-Reply-To: <a093b5ed-4ea6-7e02-f9da-19799f3cd59a@infradead.org>
On Thu, Aug 06, 2020 at 04:39:58PM -0700, Randy Dunlap wrote:
> On 8/6/20 12:33 PM, Ralph Campbell wrote:
> > On x86_64, when CONFIG_MMU_NOTIFIER is not set/enabled, there is a
> > compiler error:
> >
> > ../mm/migrate.c: In function 'migrate_vma_collect':
> > ../mm/migrate.c:2481:7: error: 'struct mmu_notifier_range' has no member
> > named 'migrate_pgmap_owner'
> > range.migrate_pgmap_owner = migrate->pgmap_owner;
> > ^
> >
> > Fixes: 998427b3ad2c ("mm/notifier: add migration invalidation type")
> > Signed-off-by: Ralph Campbell <rcampbell@nvidia.com>
> > Reported-by: Randy Dunlap <rdunlap@infradead.org>
>
> Acked-by: Randy Dunlap <rdunlap@infradead.org> # build-tested
Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>
I thought it spent enough time in linux-next and for 0-day to catch
things like this, but I guess I was wrong.
Linus has already merged the hmm pull request.
Andrew Morton: Can you pick this fix up to forward to Linus?
Thanks,
Jason
prev parent reply other threads:[~2020-08-06 23:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-06 19:33 Ralph Campbell
2020-08-06 23:39 ` Randy Dunlap
2020-08-06 23:44 ` Jason Gunthorpe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200806234427.GR19097@mellanox.com \
--to=jgg@mellanox.com \
--cc=akpm@linux-foundation.org \
--cc=hch@lst.de \
--cc=jglisse@redhat.com \
--cc=jhubbard@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=rcampbell@nvidia.com \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox