From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C033FC433E0 for ; Wed, 5 Aug 2020 21:49:59 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 7F87D22CAE for ; Wed, 5 Aug 2020 21:49:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="CJwQDpWV" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7F87D22CAE Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id E4F636B0003; Wed, 5 Aug 2020 17:49:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DFF816B0005; Wed, 5 Aug 2020 17:49:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D15056B0006; Wed, 5 Aug 2020 17:49:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0242.hostedemail.com [216.40.44.242]) by kanga.kvack.org (Postfix) with ESMTP id BC3F16B0003 for ; Wed, 5 Aug 2020 17:49:58 -0400 (EDT) Received: from smtpin24.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 6548B1EF3 for ; Wed, 5 Aug 2020 21:49:58 +0000 (UTC) X-FDA: 77117858076.24.line70_4e0195b26fb2 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin24.hostedemail.com (Postfix) with ESMTP id 3C4631A4A5 for ; Wed, 5 Aug 2020 21:49:58 +0000 (UTC) X-HE-Tag: line70_4e0195b26fb2 X-Filterd-Recvd-Size: 5258 Received: from mail-ed1-f65.google.com (mail-ed1-f65.google.com [209.85.208.65]) by imf49.hostedemail.com (Postfix) with ESMTP for ; Wed, 5 Aug 2020 21:49:57 +0000 (UTC) Received: by mail-ed1-f65.google.com with SMTP id q4so30413018edv.13 for ; Wed, 05 Aug 2020 14:49:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:reply-to:references:mime-version :content-disposition:in-reply-to:user-agent; bh=vJ9PmFgHy+mjnk3jwf45tHLYYDcmg6ohwuwx1D1TvHM=; b=CJwQDpWVKAL+0tGtjAO+XWAFvRzU9QTjUClssnaocAIa6TcBKK4/vVSgBeczWa/SCD MO3rI4WJu20SYZnOcfyTwBjk8ngCL+Ku8SYOGfAxaMbIW5zzqgqyUFGhLVdRfaJWZjxZ 6EHN4yMaXHLR3ehvhbVqeqF3zZWEBFkopyGUXz8ks0I0t5wMTjLFEs2q1eFVvcmw/qB+ zrD/75c9AwmuO40JCASBKEDw9TARMy5GsbgzoDMX/AZun95JK+QWcjRZ9JOzE0610dPn qBGvqwU5Hmp5M7LktaNOjhJSUaCYvvZPRGC375QEUCTa9okEtjggNmv3ODGqHfT/CoVL fsAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:reply-to :references:mime-version:content-disposition:in-reply-to:user-agent; bh=vJ9PmFgHy+mjnk3jwf45tHLYYDcmg6ohwuwx1D1TvHM=; b=VPImJeuDFiU84CKBTPTfRYT36VuwUM5QTX+YAp/McjzMli6y8QMnR9jzMkqYnnSTSH Y7ydtBZirIDN3NNKgnyLfQlYMqYuEG3jDVKCNjJJ2zv2FQW8zj2ToscoeTyrYsWNq4n5 befzSwpTKHQs2iVkcuZ+AJrG9GcbqoZ+W+eW+L3Q+x7z53k3FJNhpAtuRyXIs+nf/hqC 3N/nysNJReqCDyQ7SpG+p8uhu7u4/Noh3qALvSNrf37fnuPXUOhbpnLZL1smsuxSuEVi nmzPQ41a4Q3VQPkIBYLKMkcn4isokH4wns9GJyAIhX3aN1ezsCVGv5ihMCBBH46icn2V p+KA== X-Gm-Message-State: AOAM531PLR4skdwty0Ft4tJ+QDAleVgiBBBu7YfOKR8R8I++6Tn7LolI ccVy2x7HjUxm0zKpYjCZjDc= X-Google-Smtp-Source: ABdhPJz5r8QPoURKmAsVxCLJTnRnz1Ap5frEF0F7Vnx3oFTkXmayzOykaYWbVMWiacVt4lI2dYI0yg== X-Received: by 2002:a50:a2e6:: with SMTP id 93mr1198873edm.147.1596664196721; Wed, 05 Aug 2020 14:49:56 -0700 (PDT) Received: from localhost ([185.92.221.13]) by smtp.gmail.com with ESMTPSA id gl20sm2345174ejb.86.2020.08.05.14.49.55 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 05 Aug 2020 14:49:56 -0700 (PDT) Date: Wed, 5 Aug 2020 21:49:55 +0000 From: Wei Yang To: Wei Yang Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, david@redhat.com Subject: Re: [Patch v2] mm/sparse: only sub-section aligned range would be populated Message-ID: <20200805214955.ds7y3nwjoz2ms37h@master> Reply-To: Wei Yang References: <20200703031828.14645-1-richard.weiyang@linux.alibaba.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200703031828.14645-1-richard.weiyang@linux.alibaba.com> User-Agent: NeoMutt/20170113 (1.7.2) X-Rspamd-Queue-Id: 3C4631A4A5 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam02 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Jul 03, 2020 at 11:18:28AM +0800, Wei Yang wrote: >There are two code path which invoke __populate_section_memmap() > > * sparse_init_nid() > * sparse_add_section() > >For both case, we are sure the memory range is sub-section aligned. > > * we pass PAGES_PER_SECTION to sparse_init_nid() > * we check range by check_pfn_span() before calling > sparse_add_section() > >Also, the counterpart of __populate_section_memmap(), we don't do such >calculation and check since the range is checked by check_pfn_span() in >__remove_pages(). > >Clear the calculation and check to keep it simple and comply with its >counterpart. > >Signed-off-by: Wei Yang > Hi, Andrew, Is this one picked up? >--- >v2: > * add a warn on once for unaligned range, suggested by David >--- > mm/sparse-vmemmap.c | 20 ++++++-------------- > 1 file changed, 6 insertions(+), 14 deletions(-) > >diff --git a/mm/sparse-vmemmap.c b/mm/sparse-vmemmap.c >index 0db7738d76e9..8d3a1b6287c5 100644 >--- a/mm/sparse-vmemmap.c >+++ b/mm/sparse-vmemmap.c >@@ -247,20 +247,12 @@ int __meminit vmemmap_populate_basepages(unsigned long start, > struct page * __meminit __populate_section_memmap(unsigned long pfn, > unsigned long nr_pages, int nid, struct vmem_altmap *altmap) > { >- unsigned long start; >- unsigned long end; >- >- /* >- * The minimum granularity of memmap extensions is >- * PAGES_PER_SUBSECTION as allocations are tracked in the >- * 'subsection_map' bitmap of the section. >- */ >- end = ALIGN(pfn + nr_pages, PAGES_PER_SUBSECTION); >- pfn &= PAGE_SUBSECTION_MASK; >- nr_pages = end - pfn; >- >- start = (unsigned long) pfn_to_page(pfn); >- end = start + nr_pages * sizeof(struct page); >+ unsigned long start = (unsigned long) pfn_to_page(pfn); >+ unsigned long end = start + nr_pages * sizeof(struct page); >+ >+ if (WARN_ON_ONCE(!IS_ALIGNED(pfn, PAGES_PER_SUBSECTION) || >+ !IS_ALIGNED(nr_pages, PAGES_PER_SUBSECTION))) >+ return NULL; > > if (vmemmap_populate(start, end, nid, altmap)) > return NULL; >-- >2.20.1 (Apple Git-117) -- Wei Yang Help you, Help me