From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EC384C433DF for ; Wed, 5 Aug 2020 06:23:53 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id B188A2245C for ; Wed, 5 Aug 2020 06:23:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=amazon.com header.i=@amazon.com header.b="vV7opS8n" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B188A2245C Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=amazon.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 325EE6B0006; Wed, 5 Aug 2020 02:23:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2D7556B0007; Wed, 5 Aug 2020 02:23:52 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1C6B98D0001; Wed, 5 Aug 2020 02:23:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0052.hostedemail.com [216.40.44.52]) by kanga.kvack.org (Postfix) with ESMTP id BE5BD6B0006 for ; Wed, 5 Aug 2020 02:23:51 -0400 (EDT) Received: from smtpin26.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 0422D3623 for ; Wed, 5 Aug 2020 06:23:51 +0000 (UTC) X-FDA: 77115524262.26.day06_49129bd26fac Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin26.hostedemail.com (Postfix) with ESMTP id CA6FF1804B655 for ; Wed, 5 Aug 2020 06:23:50 +0000 (UTC) X-HE-Tag: day06_49129bd26fac X-Filterd-Recvd-Size: 4775 Received: from smtp-fw-6001.amazon.com (smtp-fw-6001.amazon.com [52.95.48.154]) by imf42.hostedemail.com (Postfix) with ESMTP for ; Wed, 5 Aug 2020 06:23:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amazon.com; i=@amazon.com; q=dns/txt; s=amazon201209; t=1596608631; x=1628144631; h=from:to:cc:subject:date:message-id:in-reply-to: mime-version; bh=5lSVeMwhnW0MdPI/AZAXkR/tN0Rb+ZbTOxeir3z6Hzs=; b=vV7opS8nueCEYhqJ8HmQx1r9PMyGTqeVJAwX1JCNEw/KFt//WwMThp/F z7UOKxWYwe57VnDmUU0dmiXtqU+7WlFZrJXQgxVT5iIExkmOGNk1TBNJe EA7z8RAYGf/ZXtzr99v62WbM5Pp3gI356A3r01r44MW0C0SjFo/MPmdB3 Q=; IronPort-SDR: gcki4P2QkTT/fe4dxt/fYdBVnGC+8nZEmn8DHVMRm0+Vsl59PM3wewzuZd3fmCir5LjVkZJi06 ONABzTirvvEQ== X-IronPort-AV: E=Sophos;i="5.75,436,1589241600"; d="scan'208";a="47554303" Received: from iad12-co-svc-p1-lb1-vlan3.amazon.com (HELO email-inbound-relay-1e-303d0b0e.us-east-1.amazon.com) ([10.43.8.6]) by smtp-border-fw-out-6001.iad6.amazon.com with ESMTP; 05 Aug 2020 06:23:50 +0000 Received: from EX13MTAUEA002.ant.amazon.com (iad55-ws-svc-p15-lb9-vlan2.iad.amazon.com [10.40.159.162]) by email-inbound-relay-1e-303d0b0e.us-east-1.amazon.com (Postfix) with ESMTPS id E5E2CA26F6; Wed, 5 Aug 2020 06:23:38 +0000 (UTC) Received: from EX13D31EUA001.ant.amazon.com (10.43.165.15) by EX13MTAUEA002.ant.amazon.com (10.43.61.77) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 5 Aug 2020 06:23:38 +0000 Received: from u886c93fd17d25d.ant.amazon.com (10.43.162.140) by EX13D31EUA001.ant.amazon.com (10.43.165.15) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 5 Aug 2020 06:23:21 +0000 From: SeongJae Park To: Steven Rostedt CC: SeongJae Park , SeongJae Park , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , Subject: Re: [PATCH v19 08/15] mm/damon: Add a tracepoint Date: Wed, 5 Aug 2020 08:23:05 +0200 Message-ID: <20200805062305.9417-1-sjpark@amazon.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200804180147.16d34809@oasis.local.home> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.43.162.140] X-ClientProxiedBy: EX13D21UWB004.ant.amazon.com (10.43.161.221) To EX13D31EUA001.ant.amazon.com (10.43.165.15) X-Rspamd-Queue-Id: CA6FF1804B655 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam03 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, 4 Aug 2020 18:01:47 -0400 Steven Rostedt wrote: > On Tue, 4 Aug 2020 11:14:09 +0200 > SeongJae Park wrote: > > > From: SeongJae Park > > > > This commit adds a tracepoint for DAMON. It traces the monitoring > > results of each region for each aggregation interval. Using this, DAMON > > can easily integrated with tracepoints supporting tools such as perf. > > > > Signed-off-by: SeongJae Park > > Reviewed-by: Leonard Foerster > > --- > > include/trace/events/damon.h | 43 ++++++++++++++++++++++++++++++++++++ > > mm/damon.c | 4 ++++ > > 2 files changed, 47 insertions(+) > > create mode 100644 include/trace/events/damon.h > > [...] > > --- a/mm/damon.c > > +++ b/mm/damon.c > > @@ -20,6 +20,8 @@ > > > > #define pr_fmt(fmt) "damon: " fmt > > > > +#define CREATE_TRACE_POINTS > > + > > #include > > #include > > #include > > @@ -31,6 +33,7 @@ > > #include > > #include > > #include > > It's best to place the #define CREATE_TRACE_POINTS here, so that it > doesn't cause any side effects when including the other headers. Agreed, I will do so in the next spin! > > Other than that: > > Reviewed-by: Steven Rostedt (VMware) > > -- Steve Thanks, SeongJae Park