From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E015EC433E0 for ; Thu, 30 Jul 2020 23:07:02 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 8882522CAE for ; Thu, 30 Jul 2020 23:07:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=amazon.com header.i=@amazon.com header.b="Sy3nT18h" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8882522CAE Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=amazon.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id BC0AC8D0007; Thu, 30 Jul 2020 19:07:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B702E8D0005; Thu, 30 Jul 2020 19:07:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A12FF8D0007; Thu, 30 Jul 2020 19:07:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0023.hostedemail.com [216.40.44.23]) by kanga.kvack.org (Postfix) with ESMTP id 88C2B8D0005 for ; Thu, 30 Jul 2020 19:07:01 -0400 (EDT) Received: from smtpin20.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 271411EE6 for ; Thu, 30 Jul 2020 23:07:01 +0000 (UTC) X-FDA: 77096279442.20.drum96_280d5ec26f7f Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin20.hostedemail.com (Postfix) with ESMTP id E1D99180C07AF for ; Thu, 30 Jul 2020 23:07:00 +0000 (UTC) X-HE-Tag: drum96_280d5ec26f7f X-Filterd-Recvd-Size: 5201 Received: from smtp-fw-9102.amazon.com (smtp-fw-9102.amazon.com [207.171.184.29]) by imf08.hostedemail.com (Postfix) with ESMTP for ; Thu, 30 Jul 2020 23:07:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amazon.com; i=@amazon.com; q=dns/txt; s=amazon201209; t=1596150421; x=1627686421; h=date:from:to:cc:message-id:references:mime-version: in-reply-to:subject; bh=7vMrFvtUTBg/lhMoMFfi8NrSvzxD5ruFtgpTJwVUKIE=; b=Sy3nT18hAsrqiQ2zpjwTU5xG8Gfqb8e59l6yda9R0Hzsr7XoDr9m9nHD i3ELluJGFVhVBeD2iBNLK29S6Gs82hkerQnKxL9hzgd5Qfd0IcrOxxDKs vdy7k7C40AySq/0w22cGhPrBjTRJxr0WRIWiCA3EGd7hH0GNTEZ8JEiDn k=; IronPort-SDR: QtZ+XaoPa1wpxqYDTq2G1f0sXs4cmexTY/A+g/lEhuRJZ3WCcxB5sOu3b78fnTjQ8rKbrbn3ky jsdilpsZgCJg== X-IronPort-AV: E=Sophos;i="5.75,415,1589241600"; d="scan'208";a="64407396" Subject: Re: [PATCH v2 01/11] xen/manage: keep track of the on-going suspend mode Received: from sea32-co-svc-lb4-vlan3.sea.corp.amazon.com (HELO email-inbound-relay-1a-e34f1ddc.us-east-1.amazon.com) ([10.47.23.38]) by smtp-border-fw-out-9102.sea19.amazon.com with ESMTP; 30 Jul 2020 23:06:55 +0000 Received: from EX13MTAUEE002.ant.amazon.com (iad55-ws-svc-p15-lb9-vlan3.iad.amazon.com [10.40.159.166]) by email-inbound-relay-1a-e34f1ddc.us-east-1.amazon.com (Postfix) with ESMTPS id 143F3A2573; Thu, 30 Jul 2020 23:06:47 +0000 (UTC) Received: from EX13D08UEE001.ant.amazon.com (10.43.62.126) by EX13MTAUEE002.ant.amazon.com (10.43.62.24) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Thu, 30 Jul 2020 23:06:35 +0000 Received: from EX13MTAUEA001.ant.amazon.com (10.43.61.82) by EX13D08UEE001.ant.amazon.com (10.43.62.126) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Thu, 30 Jul 2020 23:06:35 +0000 Received: from dev-dsk-anchalag-2a-9c2d1d96.us-west-2.amazon.com (172.22.96.68) by mail-relay.amazon.com (10.43.61.243) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Thu, 30 Jul 2020 23:06:35 +0000 Received: by dev-dsk-anchalag-2a-9c2d1d96.us-west-2.amazon.com (Postfix, from userid 4335130) id BFA4640384; Thu, 30 Jul 2020 23:06:34 +0000 (UTC) Date: Thu, 30 Jul 2020 23:06:34 +0000 From: Anchal Agarwal To: Boris Ostrovsky CC: Stefano Stabellini , , , , , , , , , , , , , , , , , , , , , , , , , Message-ID: <20200730230634.GA17221@dev-dsk-anchalag-2a-9c2d1d96.us-west-2.amazon.com> References: <20200717191009.GA3387@dev-dsk-anchalag-2a-9c2d1d96.us-west-2.amazon.com> <5464f384-d4b4-73f0-d39e-60ba9800d804@oracle.com> <20200721000348.GA19610@dev-dsk-anchalag-2a-9c2d1d96.us-west-2.amazon.com> <408d3ce9-2510-2950-d28d-fdfe8ee41a54@oracle.com> <20200722180229.GA32316@dev-dsk-anchalag-2a-9c2d1d96.us-west-2.amazon.com> <20200723225745.GB32316@dev-dsk-anchalag-2a-9c2d1d96.us-west-2.amazon.com> <66a9b838-70ed-0807-9260-f2c31343a081@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <66a9b838-70ed-0807-9260-f2c31343a081@oracle.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Rspamd-Queue-Id: E1D99180C07AF X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam04 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jul 27, 2020 at 06:08:29PM -0400, Boris Ostrovsky wrote: > CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you can confirm the sender and know the content is safe. > > > > On 7/24/20 7:01 PM, Stefano Stabellini wrote: > > Yes, it does, thank you. I'd rather not introduce unknown regressions so > > I would recommend to add an arch-specific check on registering > > freeze/thaw/restore handlers. Maybe something like the following: > > > > #ifdef CONFIG_X86 > > .freeze = blkfront_freeze, > > .thaw = blkfront_restore, > > .restore = blkfront_restore > > #endif > > > > > > maybe Boris has a better suggestion on how to do it > > > An alternative might be to still install pm notifier in > drivers/xen/manage.c (I think as result of latest discussions we decided > we won't need it) and return -ENOTSUPP for ARM for > PM_HIBERNATION_PREPARE and friends. Would that work? > I think the question here is for registering driver specific freeze/thaw/restore callbacks for x86 only. I have dropped the pm_notifier in the v3 still pending testing. So I think just registering driver specific callbacks for x86 only is a good option. What do you think? Anchal > > -boris > > >