From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 54ADEC433DF for ; Thu, 30 Jul 2020 19:57:29 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 1822A2074B for ; Thu, 30 Jul 2020 19:57:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="FEzraYeM" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1822A2074B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 9BC9B6B0028; Thu, 30 Jul 2020 15:57:28 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 96CE26B0029; Thu, 30 Jul 2020 15:57:28 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 85BA06B002A; Thu, 30 Jul 2020 15:57:28 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0240.hostedemail.com [216.40.44.240]) by kanga.kvack.org (Postfix) with ESMTP id 701406B0028 for ; Thu, 30 Jul 2020 15:57:28 -0400 (EDT) Received: from smtpin09.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 25C983627 for ; Thu, 30 Jul 2020 19:57:28 +0000 (UTC) X-FDA: 77095801776.09.pigs33_1407b0326f7d Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin09.hostedemail.com (Postfix) with ESMTP id 00A84180AD806 for ; Thu, 30 Jul 2020 19:57:27 +0000 (UTC) X-HE-Tag: pigs33_1407b0326f7d X-Filterd-Recvd-Size: 1879 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf09.hostedemail.com (Postfix) with ESMTP for ; Thu, 30 Jul 2020 19:57:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=/3VtW7SquYEchxQCh33bttrlb5IJlhozRM59vlZwvg0=; b=FEzraYeMg6W36tFFrr6exmwcrN CBXWEHS6VzeQD24mfyWNv9nqCaL/fJ6Ft1XQO6/SGSMVwRiCobXoUiH2tOE8dnrSkGO6cM0YgZwxY TQH6TxIkHaevjogr/+1CUn7j3HsaeG/pHZ/UeyhqNOgfWRL/uvzs9fP0oSQCfOvmYa2mSsRBx66iv 3sMWW4t4A99yPFjDNk+zM96aKOY+IZjbEZHgFWQQt0Q1p2iJ6zISXZUCo8geUSvQzYx3uKKU6LpuQ bLgQ1IyL+p/hgADLfk/7wR/6DoOI/WXnLfwfNXW+527XEekVOhy99yd08nSl6V/2ZvPnXwEqaLe/L oGlrybWA==; Received: from willy by casper.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1k1Eg6-0005wG-5J; Thu, 30 Jul 2020 19:57:22 +0000 Date: Thu, 30 Jul 2020 20:57:22 +0100 From: Matthew Wilcox To: Peter Xu Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Andrew Morton , Andrea Arcangeli , Mike Kravetz Subject: Re: [PATCH] mm/hugetlb: Fix calculation of adjust_range_if_pmd_sharing_possible Message-ID: <20200730195722.GL23808@casper.infradead.org> References: <20200730195030.60616-1-peterx@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200730195030.60616-1-peterx@redhat.com> X-Rspamd-Queue-Id: 00A84180AD806 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam05 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000002, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jul 30, 2020 at 03:50:30PM -0400, Peter Xu wrote: > +#define MAX(a,b) (((a)>(b))?(a):(b)) > +#define MIN(a,b) (((a)<(b))?(a):(b)) What's wrong with max() and min() defined in kernel.h?