From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1BBEAC433DF for ; Wed, 29 Jul 2020 11:46:00 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id D75BF206D8 for ; Wed, 29 Jul 2020 11:45:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="J+A4zrhh" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D75BF206D8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 7AE5E6B0006; Wed, 29 Jul 2020 07:45:59 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 75EC76B0007; Wed, 29 Jul 2020 07:45:59 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 676AE6B000A; Wed, 29 Jul 2020 07:45:59 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0157.hostedemail.com [216.40.44.157]) by kanga.kvack.org (Postfix) with ESMTP id 519866B0006 for ; Wed, 29 Jul 2020 07:45:59 -0400 (EDT) Received: from smtpin01.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 0513185280A1 for ; Wed, 29 Jul 2020 11:45:59 +0000 (UTC) X-FDA: 77090934438.01.smell42_450ae7526f72 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin01.hostedemail.com (Postfix) with ESMTP id D993F101DFD18 for ; Wed, 29 Jul 2020 11:45:58 +0000 (UTC) X-HE-Tag: smell42_450ae7526f72 X-Filterd-Recvd-Size: 5596 Received: from mail-pg1-f194.google.com (mail-pg1-f194.google.com [209.85.215.194]) by imf26.hostedemail.com (Postfix) with ESMTP for ; Wed, 29 Jul 2020 11:45:58 +0000 (UTC) Received: by mail-pg1-f194.google.com with SMTP id o13so14138970pgf.0 for ; Wed, 29 Jul 2020 04:45:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=rnSHWpSGzohq9BhD/C5rl6PYPh18BOuLPWnyUBOdMSk=; b=J+A4zrhh/K095SpdzjX1CgPX766Epnk6LbUcVSeK3q5d0KW6pywZilp6N76R34FIlg VqLOX/UjD3jVuyeRpAPygMZp/nq5EulAg2VVaJ7aroMRYqeuIwBI6egsPGPVrBHUDJkD /aE2w6XsNBtY884+iLTCYWY81p2t4BQb+si4l+o7hOWx2mNZOLSnIa694qtY6oDKiA04 04tkBtLi+CZK1xV7bS1dB4+sHL+KaS4cLVI/H2CroCmCFQSHErwzCwxRyAFXP+MSKXV5 +m7F5PbmbIFc7q8wkYErNJJLFTNvDvJ+mgKbvTTkypkEEXIfPf95yfMvkw7dCsu4aZ4H vBOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=rnSHWpSGzohq9BhD/C5rl6PYPh18BOuLPWnyUBOdMSk=; b=GKfRNrg/lmqpI08fz3oFtvgMBsmGXKXaSYoalrlEz4kzkMM9A0pqJYWADQAczRP6qm Y7dHbAnQkxaUBVJh4J9GQotOyAo6utMx6nxKQ3nZBZDbJgBXIG/9cdRiQaxjKXeQq51k yOip42q7FMLi/1+0WrPGlIAdydxSzBo9Y0ud3cXgzvRgr3gqZeVaxDkA4bis+Qha0Z67 mHaTjaCOqrr/DblXVo7aAmZ2wtKFIeVo2S9/UtODH1Z77b7jLuh30IrJA83dspde/XsF 9AWxk9qTPSvn+WjcDV6CYv4yw04Bu4U/7X2uw7/DiVss1Yaw5kVcPY9rahykz6SMdWfi fOSA== X-Gm-Message-State: AOAM533UZtDc+OlS0PdHEskp+DYCtBmzseM15t46rYL1Vxn2H8aSqcnm GIwL3rpiN19oz2S43PzZnFE= X-Google-Smtp-Source: ABdhPJyjQVFbxP+CyHoZIHRWD+Yqf5j/tnegtYmAsoD0wYfkwzMe5cQTFyjC3B/OV628Iaka0B/EeQ== X-Received: by 2002:a63:6486:: with SMTP id y128mr27631994pgb.82.1596023157675; Wed, 29 Jul 2020 04:45:57 -0700 (PDT) Received: from localhost (g155.222-224-148.ppp.wakwak.ne.jp. [222.224.148.155]) by smtp.gmail.com with ESMTPSA id i14sm2050136pjz.25.2020.07.29.04.45.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Jul 2020 04:45:56 -0700 (PDT) Date: Wed, 29 Jul 2020 20:45:54 +0900 From: Stafford Horne To: Nicholas Piggin Cc: linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Arnd Bergmann , Jonas Bonn , Stefan Kristiansson , openrisc@lists.librecores.org Subject: Re: [PATCH 14/24] openrisc: use asm-generic/mmu_context.h for no-op implementations Message-ID: <20200729114554.GG80756@lianli.shorne-pla.net> References: <20200728033405.78469-1-npiggin@gmail.com> <20200728033405.78469-15-npiggin@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200728033405.78469-15-npiggin@gmail.com> X-Rspamd-Queue-Id: D993F101DFD18 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam03 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jul 28, 2020 at 01:33:55PM +1000, Nicholas Piggin wrote: > Cc: Jonas Bonn > Cc: Stefan Kristiansson > Cc: Stafford Horne > Cc: openrisc@lists.librecores.org > Signed-off-by: Nicholas Piggin > --- > arch/openrisc/include/asm/mmu_context.h | 8 +++----- > arch/openrisc/mm/tlb.c | 2 ++ > 2 files changed, 5 insertions(+), 5 deletions(-) > > diff --git a/arch/openrisc/include/asm/mmu_context.h b/arch/openrisc/include/asm/mmu_context.h > index ced577542e29..a6702384c77d 100644 > --- a/arch/openrisc/include/asm/mmu_context.h > +++ b/arch/openrisc/include/asm/mmu_context.h > @@ -17,13 +17,13 @@ > > #include > > +#define init_new_context init_new_context > extern int init_new_context(struct task_struct *tsk, struct mm_struct *mm); > +#define destroy_context destroy_context > extern void destroy_context(struct mm_struct *mm); > extern void switch_mm(struct mm_struct *prev, struct mm_struct *next, > struct task_struct *tsk); > > -#define deactivate_mm(tsk, mm) do { } while (0) > - > #define activate_mm(prev, next) switch_mm((prev), (next), NULL) > > /* current active pgd - this is similar to other processors pgd > @@ -32,8 +32,6 @@ extern void switch_mm(struct mm_struct *prev, struct mm_struct *next, > > extern volatile pgd_t *current_pgd[]; /* defined in arch/openrisc/mm/fault.c */ > > -static inline void enter_lazy_tlb(struct mm_struct *mm, struct task_struct *tsk) > -{ > -} > +#include This looks ok. > #endif > diff --git a/arch/openrisc/mm/tlb.c b/arch/openrisc/mm/tlb.c > index 4b680aed8f5f..821aab4cf3be 100644 > --- a/arch/openrisc/mm/tlb.c > +++ b/arch/openrisc/mm/tlb.c > @@ -159,6 +159,7 @@ void switch_mm(struct mm_struct *prev, struct mm_struct *next, > * instance. > */ > > +#define init_new_context init_new_context > int init_new_context(struct task_struct *tsk, struct mm_struct *mm) > { > mm->context = NO_CONTEXT; > @@ -170,6 +171,7 @@ int init_new_context(struct task_struct *tsk, struct mm_struct *mm) > * drops it. > */ > > +#define destroy_context destroy_context > void destroy_context(struct mm_struct *mm) > { > flush_tlb_mm(mm); I don't think we need the #define's in the .c file. Do we? -Stafford > -- > 2.23.0 >