From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2787FC433E1 for ; Sat, 25 Jul 2020 09:46:21 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id C64CD2063A for ; Sat, 25 Jul 2020 09:46:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="FJhTvJlu" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C64CD2063A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 043C16B0002; Sat, 25 Jul 2020 05:46:20 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F36726B0003; Sat, 25 Jul 2020 05:46:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E4D956B0006; Sat, 25 Jul 2020 05:46:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0203.hostedemail.com [216.40.44.203]) by kanga.kvack.org (Postfix) with ESMTP id CFE376B0002 for ; Sat, 25 Jul 2020 05:46:19 -0400 (EDT) Received: from smtpin19.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 3A2A582499B9 for ; Sat, 25 Jul 2020 09:46:19 +0000 (UTC) X-FDA: 77076117678.19.wash41_5b0de4f26f4f Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin19.hostedemail.com (Postfix) with ESMTP id 162DE15457 for ; Sat, 25 Jul 2020 09:46:19 +0000 (UTC) X-HE-Tag: wash41_5b0de4f26f4f X-Filterd-Recvd-Size: 3345 Received: from us-smtp-delivery-1.mimecast.com (us-smtp-1.mimecast.com [205.139.110.61]) by imf16.hostedemail.com (Postfix) with ESMTP for ; Sat, 25 Jul 2020 09:46:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1595670377; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=PN2Xs/Q3DnIYM6SWZ/xYcx0QxiDyrNCnXxiRaYTtKSY=; b=FJhTvJluchvoj0+xfU/MglEGmQI+NF+iV7Qmjj4nHngE9zdFCZCqqMuiWOqobXYL2CRgqJ xJmnBsVLqY71M6QTfNanklnS8jI4p2Y8BYQHvfDbTsOZGU22E1rWQtbDl1aFAmerLduXhA GZEKaKQsyCfqoIK+v4fkSYBYmOZmRU8= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-444-47sI9bpKMlmEqrHyB9koyw-1; Sat, 25 Jul 2020 05:46:13 -0400 X-MC-Unique: 47sI9bpKMlmEqrHyB9koyw-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 88AC480BCAC; Sat, 25 Jul 2020 09:39:08 +0000 (UTC) Received: from dhcp-27-174.brq.redhat.com (unknown [10.40.192.25]) by smtp.corp.redhat.com (Postfix) with SMTP id 7DBA05F1EF; Sat, 25 Jul 2020 09:39:05 +0000 (UTC) Received: by dhcp-27-174.brq.redhat.com (nbSMTP-1.00) for uid 1000 oleg@redhat.com; Sat, 25 Jul 2020 11:39:08 +0200 (CEST) Date: Sat, 25 Jul 2020 11:39:03 +0200 From: Oleg Nesterov To: Linus Torvalds Cc: Hugh Dickins , Michal Hocko , Linux-MM , LKML , Andrew Morton , Tim Chen , Michal Hocko Subject: Re: [RFC PATCH] mm: silence soft lockups from unlock_page Message-ID: <20200725093902.GA3870@redhat.com> References: <20200723124749.GA7428@redhat.com> <20200724152424.GC17209@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Rspamd-Queue-Id: 162DE15457 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam02 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 07/24, Linus Torvalds wrote: > > And in fact, once you do it on top of that, it becomes obvious that we > can share even more code: move the WQ_FLAG_WOKEN logic _into_ the > trylock_page_bit_common() function. Ah, indeed, somehow I didn't realize this, > I added your reviewed-by, but maybe you should double-check my changes. Still looks correct to me, thanks. Oleg.