From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D0B85C433E0 for ; Fri, 24 Jul 2020 14:26:34 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 9C2362063A for ; Fri, 24 Jul 2020 14:26:34 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9C2362063A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 04A2A6B0032; Fri, 24 Jul 2020 10:26:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F3CD86B0037; Fri, 24 Jul 2020 10:26:33 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E53196B0055; Fri, 24 Jul 2020 10:26:33 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0195.hostedemail.com [216.40.44.195]) by kanga.kvack.org (Postfix) with ESMTP id CFA9E6B0032 for ; Fri, 24 Jul 2020 10:26:33 -0400 (EDT) Received: from smtpin24.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 8DB028248D7C for ; Fri, 24 Jul 2020 14:26:33 +0000 (UTC) X-FDA: 77073195066.24.jeans17_360f7aa26f48 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin24.hostedemail.com (Postfix) with ESMTP id 71C1118F70 for ; Fri, 24 Jul 2020 14:26:33 +0000 (UTC) X-HE-Tag: jeans17_360f7aa26f48 X-Filterd-Recvd-Size: 3451 Received: from mail-ed1-f65.google.com (mail-ed1-f65.google.com [209.85.208.65]) by imf34.hostedemail.com (Postfix) with ESMTP for ; Fri, 24 Jul 2020 14:26:32 +0000 (UTC) Received: by mail-ed1-f65.google.com with SMTP id h28so7180523edz.0 for ; Fri, 24 Jul 2020 07:26:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=fQc6a55htIZJuQwps2J4GcOYjRoEwiPLJFT6XTUnmHQ=; b=cMTY2qezIsiAcu7eKGM+MIVJj+NZsFGz9RaHM61CzVSSkgoHALMDPLyNrOAMf0w+Y9 UamGYJtxJKnnFjcXpokXoSHAN+KSksZl80PUYekjfbxkt718o5MhnGJ37BhvUeJHDjmX 6Lwu6DHWMdBFc/PWlL79rhY0KVpcJOvBGQoueyZ0sKI8knBQNByPDxz+gYAylfBfg0QE od5GexedrlTIhC6vCFBGRN/jA/pvVSkTXrTsBwtj3GPSR4Gn6uCvyRGlGyCKYGN9+1k8 d9+9dUZ66rCLPtYUl2jep7kT2Ol3m1+h9K0PVrZo4RoMBIggfNyhXczX7bNG66YN2pG6 W42Q== X-Gm-Message-State: AOAM532m+3clqK1RTA6J06jGDAAurDPj4o/B6dR+waKQJHdz+6KsMldw ZhA86WEpEZamoy78LR1IiOo= X-Google-Smtp-Source: ABdhPJxT/FT7VCkOSUSQBSY40kqmPgw0t7WYcwoSmE1x+0nvVqgkavSXxCfqTks2iqxN2EDg6+Xfbw== X-Received: by 2002:a05:6402:b99:: with SMTP id cf25mr8889248edb.291.1595600791843; Fri, 24 Jul 2020 07:26:31 -0700 (PDT) Received: from localhost (ip-37-188-169-187.eurotel.cz. [37.188.169.187]) by smtp.gmail.com with ESMTPSA id v24sm789166eds.71.2020.07.24.07.26.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Jul 2020 07:26:30 -0700 (PDT) Date: Fri, 24 Jul 2020 16:26:29 +0200 From: Michal Hocko To: Muchun Song Cc: mike.kravetz@oracle.com, Andrew Morton , David Rientjes , mgorman@suse.de, walken@google.com, Linux Memory Management List , LKML , Jianchao Guo Subject: Re: [Phishing Risk] [External] Re: [PATCH v2] mm/hugetlb: add mempolicy check in the reservation routine Message-ID: <20200724142629.GA31772@dhcp22.suse.cz> References: <20200724100306.33457-1-songmuchun@bytedance.com> <20200724113415.GG4061@dhcp22.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 71C1118F70 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam01 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri 24-07-20 21:56:29, Muchun Song wrote: > On Fri, Jul 24, 2020 at 7:34 PM Michal Hocko wrote: [...] > > I believe you can simplify this and use a similar pattern as the page > > allocator. Something like > > > > for_each_node_mask(node, mpol_allowed) { > > if (node_isset(node, &cpuset_current_mems_allowed)) > > nr += array[node]; > > } > > > > There shouldn't be any need to allocate a potentially large nodemask on > > the stack. > > An unsigned long can satisfy 64 nodes. So I think that nodemask is using > little stack memory. Right? CONFIG_NODES_SHIFT=10 is not something surprising. E.g. SLES is using that default for a long time because those kernels tend to run on very large machines. -- Michal Hocko SUSE Labs